Git-Mirrors/onionshare
1
0
Fork 0
mirror of https://github.com/onionshare/onionshare.git synced 2025-01-23 21:21:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

When building the self.files, use forward slashes instead of backslashes in Windows

Browse Source
This commit is contained in:
Micah Lee 2021-05-04 20:01:30 -07:00
parent 659ed83853
commit 34771e3ea9
No known key found for this signature in database
GPG Key ID: 403C2657CD994F73
1 changed files with 27 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
cli/onionshare_cli/web/send_base_mode.py
View File

@ -55,6 +55,15 @@ class SendBaseModeWeb:
self.define_routes() self.define_routes()
self.init() self.init()
def fix_windows_paths(self, path):
"""
If on Windows, replace backslashes with slashes
"""
if self.common.platform == "Windows":
return path.replace("\\", "/")
return path
def set_file_info(self, filenames, processed_size_callback=None): def set_file_info(self, filenames, processed_size_callback=None):
""" """
Build a data structure that describes the list of files Build a data structure that describes the list of files
@ -70,40 +79,48 @@ class SendBaseModeWeb:
self.root_files = ( self.root_files = (
{} {}
) # This is only the root files and dirs, as opposed to all of them ) # This is only the root files and dirs, as opposed to all of them
self.cleanup_filenames = []
self.cur_history_id = 0 self.cur_history_id = 0
self.file_info = {"files": [], "dirs": []} self.file_info = {"files": [], "dirs": []}
self.gzip_individual_files = {} self.gzip_individual_files = {}
self.init() self.init()
# Windows paths use backslashes, but website paths use forward slashes. We have to
# make sure we're stripping the correct type of slash
if self.common.platform == "Windows":
slash = "\\"
else:
slash = "/"
# Build the file list # Build the file list
for filename in filenames: for filename in filenames:
basename = os.path.basename(filename.rstrip("/")) basename = os.path.basename(filename.rstrip(slash))
# If it's a filename, add it # If it's a filename, add it
if os.path.isfile(filename): if os.path.isfile(filename):
self.files[basename] = filename self.files[self.fix_windows_paths(basename)] = filename
self.root_files[basename] = filename self.root_files[self.fix_windows_paths(basename)] = filename
# If it's a directory, add it recursively # If it's a directory, add it recursively
elif os.path.isdir(filename): elif os.path.isdir(filename):
self.root_files[basename] = filename self.root_files[self.fix_windows_paths(basename)] = filename
for root, _, nested_filenames in os.walk(filename): for root, _, nested_filenames in os.walk(filename):
# Normalize the root path. So if the directory name is "/home/user/Documents/some_folder", # Normalize the root path. So if the directory name is "/home/user/Documents/some_folder",
# and it has a nested folder foobar, the root is "/home/user/Documents/some_folder/foobar". # and it has a nested folder foobar, the root is "/home/user/Documents/some_folder/foobar".
# The normalized_root should be "some_folder/foobar" # The normalized_root should be "some_folder/foobar"
normalized_root = os.path.join( normalized_root = os.path.join(
basename, root[len(filename) :].lstrip("/") basename, root[len(filename) :].lstrip(slash)
).rstrip("/") ).rstrip(slash)
# Add the dir itself # Add the dir itself
self.files[normalized_root] = root self.files[self.fix_windows_paths(normalized_root)] = root
# Add the files in this dir # Add the files in this dir
for nested_filename in nested_filenames: for nested_filename in nested_filenames:
self.files[ self.files[
self.fix_windows_paths(
os.path.join(normalized_root, nested_filename) os.path.join(normalized_root, nested_filename)
)
] = os.path.join(root, nested_filename) ] = os.path.join(root, nested_filename)
self.set_file_info_custom(filenames, processed_size_callback) self.set_file_info_custom(filenames, processed_size_callback)
@ -177,7 +194,7 @@ class SendBaseModeWeb:
self.gzip_individual_files[filesystem_path] = gzip_filename self.gzip_individual_files[filesystem_path] = gzip_filename
# Make sure the gzip file gets cleaned up when onionshare stops # Make sure the gzip file gets cleaned up when onionshare stops
self.cleanup_filenames.append(gzip_filename) self.web.cleanup_filenames.append(gzip_filename)
file_to_download = self.gzip_individual_files[filesystem_path] file_to_download = self.gzip_individual_files[filesystem_path]
filesize = os.path.getsize(self.gzip_individual_files[filesystem_path]) filesize = os.path.getsize(self.gzip_individual_files[filesystem_path])