Git-Mirrors/onionshare
1
0
Fork 0
mirror of https://github.com/onionshare/onionshare.git synced 2025-07-25 15:45:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Rename 'Advanced settings' to 'Scheduling settings' and move all time-based settings there.

Browse source 
This includes the 'Automatically start this (persistent) onion when OnionShare starts' and 'stop sharing after files have been downloaded'.

Make the 'Custom title' be the first field in all modes, and make sure mode-specific settings are shown after others but before the Scheduling toggle, for a more consistent view of settings for each mode.
This commit is contained in:
Miguel Jacq 2025-02-28 14:25:24 +11:00
parent 73f153af3b
commit 22b04ed733
No known key found for this signature in database
GPG key ID: 59B3F0C24135C6A9
51 changed files with 132 additions and 131 deletions
Download patch file Download diff file Expand all files Collapse all files

17
desktop/tests/test_gui_share.py
View file

@ -256,7 +256,7 @@ class TestShare(GuiBaseTest):
If autostart timer is after autostop timer, a warning should be thrown
"""
tab = self.new_share_tab()
tab.get_mode().mode_settings_widget.toggle_advanced_button.click()
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
tab.get_mode().mode_settings_widget.autostart_timer_checkbox.click()
tab.get_mode().mode_settings_widget.autostop_timer_checkbox.click()
@ -280,7 +280,7 @@ class TestShare(GuiBaseTest):
Autostart timer should automatically start
"""
tab = self.new_share_tab()
tab.get_mode().mode_settings_widget.toggle_advanced_button.click()
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
tab.get_mode().mode_settings_widget.autostart_timer_checkbox.click()
self.run_all_common_setup_tests()
@ -301,7 +301,7 @@ class TestShare(GuiBaseTest):
Autostart timer should throw a warning if the scheduled time is too soon
"""
tab = self.new_share_tab()
tab.get_mode().mode_settings_widget.toggle_advanced_button.click()
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
tab.get_mode().mode_settings_widget.autostart_timer_checkbox.click()
def accept_dialog():
@ -325,7 +325,7 @@ class TestShare(GuiBaseTest):
Test canceling a scheduled share
"""
tab = self.new_share_tab()
tab.get_mode().mode_settings_widget.toggle_advanced_button.click()
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
tab.get_mode().mode_settings_widget.autostart_timer_checkbox.click()
self.run_all_common_setup_tests()
@ -440,7 +440,7 @@ class TestShare(GuiBaseTest):
Test the autostop timer
"""
tab = self.new_share_tab()
tab.get_mode().mode_settings_widget.toggle_advanced_button.click()
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
tab.get_mode().mode_settings_widget.autostop_timer_checkbox.click()
self.run_all_common_setup_tests()
@ -458,7 +458,7 @@ class TestShare(GuiBaseTest):
Test the autostop timer when the timeout is too short
"""
tab = self.new_share_tab()
tab.get_mode().mode_settings_widget.toggle_advanced_button.click()
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
tab.get_mode().mode_settings_widget.autostop_timer_checkbox.click()
def accept_dialog():
@ -504,7 +504,7 @@ class TestShare(GuiBaseTest):
clipboard contains the ClientAuth string
"""
tab = self.new_share_tab()
tab.get_mode().mode_settings_widget.toggle_advanced_button.click()
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
self.run_all_common_setup_tests()
self.run_all_share_mode_setup_tests(tab)
@ -587,7 +587,8 @@ class TestShare(GuiBaseTest):
# Click on persistence
tab.get_mode().mode_settings_widget.persistent_checkbox.click()
# Autostart on launch is now visible
# Autostart on launch is now visible if you click the Scheduling settings
tab.get_mode().mode_settings_widget.toggle_scheduling_button.click()
self.assertTrue(tab.get_mode().mode_settings_widget.persistent_autostart_on_launch_checkbox.isVisible())
# Click off persistence