From 109d63a10c90c656409c6a3d66e146becc151b0b Mon Sep 17 00:00:00 2001 From: Micah Lee Date: Wed, 1 Dec 2021 20:10:51 -0800 Subject: [PATCH] Use NamedTemporaryFile instead of TemporaryFile, to fix crash when sharing one file --- cli/onionshare_cli/web/share_mode.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/onionshare_cli/web/share_mode.py b/cli/onionshare_cli/web/share_mode.py index 09799679..75c11a83 100644 --- a/cli/onionshare_cli/web/share_mode.py +++ b/cli/onionshare_cli/web/share_mode.py @@ -467,7 +467,7 @@ class ShareModeWeb(SendBaseModeWeb): return self.web.error404(history_id) def build_zipfile_list(self, filenames, processed_size_callback=None): - self.common.log("ShareModeWeb", "build_zipfile_list") + self.common.log("ShareModeWeb", "build_zipfile_list", f"filenames={filenames}") for filename in filenames: info = { "filename": filename, @@ -492,7 +492,7 @@ class ShareModeWeb(SendBaseModeWeb): self.download_etag = make_etag(f) # Compress the file with gzip now, so we don't have to do it on each request - self.gzip_file = tempfile.TemporaryFile( + self.gzip_file = tempfile.NamedTemporaryFile( "wb+", dir=self.common.build_tmp_dir() ) self._gzip_compress(