mirror of
https://github.com/monero-project/monero.git
synced 2024-12-15 10:24:20 -05:00
d5472bd87b
The "everything refreshed" state was detected when a refresh call did not return any new blocks. This can be detected without that extra "empty" call by comparing the claimed node height to the height of the last block retrieved. Doing this avoids that last call, saves some bandwidth, and makes the common refresh case use only one call rather than two. As a side effect, it prevents an information leak reported by Tramèr et al: if the wallet retrieves a set of blocks which includes an output sent to the refreshing wallet, the wallet will prompt the user for the password to decode the amount and calculate the key image for the new output, and this will delay subsequent calls to getblocks.bin, allowing a passive adversary to note the delay and deduce when the wallet receives at least one output. This can still happen if the wallet downloads more than 1000 blocks, since this will be split in several calls, but then the most the adversary can tell is which 1000 block section the user received some monero (the adversary can estimate the heights of the blocks by calculating how many "large" transfers are done, which will be sections of blocks, the last of which will usually be below 1000, but the size of the data should allow the actual number of blocks sent to be determined fairly accurately). This timing trick still be used via the subsequent scan for incoming txes in the txpool, which will be fixed later. |
||
|---|---|---|
| .. | ||
| api | ||
| CMakeLists.txt | ||
| message_store.cpp | ||
| message_store.h | ||
| message_transporter.cpp | ||
| message_transporter.h | ||
| node_rpc_proxy.cpp | ||
| node_rpc_proxy.h | ||
| ringdb.cpp | ||
| ringdb.h | ||
| wallet2.cpp | ||
| wallet2.h | ||
| wallet_args.cpp | ||
| wallet_args.h | ||
| wallet_errors.h | ||
| wallet_light_rpc.h | ||
| wallet_rpc_helpers.h | ||
| wallet_rpc_payments.cpp | ||
| wallet_rpc_server_commands_defs.h | ||
| wallet_rpc_server_error_codes.h | ||
| wallet_rpc_server.cpp | ||
| wallet_rpc_server.h | ||