Commit Graph

11768 Commits

Author SHA1 Message Date
jeffro256
262ef473db
BlockchainDB: remove lock/unlock methods 2024-04-11 12:12:35 -05:00
jeffro256
bc05e724cb
common: add va_args.h
This PR is upstreaming changes in the Seraphis lib here: https://github.com/UkoeHB/monero/pull/39. This header adds a macro `VA_ARGS_COMMAPREFIX`
which, when passed `__VA_ARGS__`, expands to `, __VA_ARGS__` unless the length of `__VA_ARGS__` is 0, in which case it expands to nothing. This
macro is useful for passing/declaring optional function arguments.
2024-04-11 11:32:07 -05:00
Dusan Klinec
4689ad2d3c
trezor: support c++17 and protobuf v25, libusb fix
- fix If there is no protobuf version installed, if fails
- passphrase test fix, wallet keys init was missing
2024-04-10 18:19:22 +02:00
selsta
b27fda269e
src: update checkpoints to match latest release 2024-04-06 00:53:05 +02:00
jeffro256
ff49444ee8
@tobtoht: undo rebase changes tx.dsts -> tx_dsts 2024-04-05 13:12:34 -05:00
SNeedlewoods
18fbe54729 add sum of amounts for unspent_outputs 2024-03-30 13:18:12 +01:00
Lee *!* Clagett
463228b961 Skip privacy networks (on tx sends) that don't have outgoing connections 2024-03-29 13:01:58 -04:00
j-berman
427ba7702f wallet2: ensure transfers and sweeps use same fee calc logic rnd2
Looks like the logic from #8882 was accidentally removed in #8861
(regressing to the behavior noted in the #8882 description).
This commit brings that logic back.
2024-03-22 14:05:17 -07:00
koe
e151ff711f update blake2b test vectors 2024-03-21 09:51:40 -05:00
jeffro256
d6609b83d6
serialization: do any N-tuple 2024-03-19 14:49:36 -05:00
0xFFFC0000
c56ee140df
Cleanup string_tools.
1. Use boost::filesystem for already available operations.
2. Use boost::string for already available operations.
2024-03-15 14:54:23 +03:30
luigi1111
c8214782fb
Merge pull request #9243
c4e1c5a ringct: fix trunc_amount field name change (jeffro256)
2024-03-12 12:45:35 -04:00
jeffro256
8e80585ef5
functional_tests: test HTTP digest auth
Test:
  1. Can't login to RPC server with --rpc-login enabled, but no auth provided
  2. Can access RPC server with correct login
  3. Can use internal HTTP client to access RPC server with correct login

With commit 0ae5c91e50 not reverted, we fail test 3.
2024-03-11 23:54:50 -05:00
jeffro256
c4e1c5a640
ringct: fix trunc_amount field name change
Caused in commit 05231400ce, PR #9035.
2024-03-11 20:21:22 -05:00
luigi1111
2d855f8d67
Merge pull request #9237
bcb15d3 Revert 'http_client: reduce number of packets sent for small bodies' (jeffro256)
2024-03-11 15:55:37 -04:00
luigi1111
8e61ddb413
Merge pull request #9228
c40d8b2 depends: add riscv64 linux build tag (selsta)
2024-03-11 15:52:09 -04:00
jeffro256
bcb15d3b00
Revert "http_client: reduce number of packets sent for small bodies"
This reverts commit 0ae5c91e50.
2024-03-10 23:04:44 -05:00
jeffro256
9d101d5ea0
serialization: protect blob serialization from undefined behavior
There is currently no compiler protection when someone tries to
do (for example) `BLOB_SERIALIZER(std::vector<int>)`. You just
get runtime allocation errors. This has already eaten up dev time
before, so this PR adds a static assertion that the type must be
trivially copyable, as defined by the C++ standard. Types can
override this if applicable if they use `BLOB_SERIALIZER_FORCED`.
2024-03-10 14:15:48 -05:00
jeffro256
7194506792
Blockchain: remove old fee calc logic 2024-03-10 13:30:46 -05:00
selsta
c40d8b213c
depends: add riscv64 linux build tag 2024-03-09 21:15:28 +01:00
luigi1111
1bec71279e
Merge pull request #9225
a01d7cc Fixed mempool pruning (SChernykh)
2024-03-08 20:27:34 -05:00
luigi1111
769202bc52
Merge pull request #9219
e6f4875 wallet2: adjust fee during backlog, fix set priority (selsta)
2024-03-08 20:26:58 -05:00
SyntheticBird45
9b946ae527 Removed default cryptonote address
- Removed `localhost:8080` default value to address string in wallet rpc
- Added an error response in case string is empty

fixed indentation

removed if and errors, default to localhost and port based on nettype

Forgot ":"

forgot ; and m_

removed wallet_rpc_server_error_codes.h
2024-03-08 21:32:26 +01:00
SChernykh
a01d7ccbfd Fixed mempool pruning
- Fixed undefined behavior after a call to `remove_tx_from_transient_lists` (it used an invalid iterator)
- Fixed `txCompare` (it wasn't strictly weak ordered)
2024-03-08 21:04:16 +01:00
luigi1111
d6d55b507a
Merge pull request #9222
66e5081 get_block_template_backlog: better sorting logic (SChernykh)
2024-03-08 13:45:41 -05:00
luigi1111
c23951f339
Merge pull request #9218
7815023 tx_memory_pool: make double spends a no-drop offense (jeffro256)
2024-03-08 10:43:20 -05:00
SChernykh
66e5081eae get_block_template_backlog: better sorting logic
std::sort is unstable, so it can return random sets of transactions when mempool has many transactions with the same fee/byte. It can result in p2pool mining empty blocks sometimes because it doesn't pick up "new" transactions immediately.
2024-03-08 14:50:01 +01:00
selsta
e6f4875219
wallet2: adjust fee during backlog, fix set priority 2024-03-08 14:13:58 +01:00
luigi1111
4b255808d0
Merge pull request #9214
399b884 unit_tests: fix strtoul unit test (jeffro256)
2024-03-07 21:37:42 -05:00
luigi1111
6ade592adf
Merge pull request #9195
2a2da79 free function serialization DSL (jeffro256)
2024-03-07 21:37:05 -05:00
luigi1111
2dced15f85
Merge pull request #9187
695084e depends: add download commands for freebsd & android sources (tobtoht)
2024-03-07 21:35:02 -05:00
luigi1111
ce88edc3f7
Merge pull request #9184
7043238 Remove instructions for Void Linux, add NixOS (Siren)
2024-03-07 21:34:39 -05:00
luigi1111
c3ebfb132f
Merge pull request #9179
e499e74 actions: update to v4 actions (tobtoht)
2024-03-07 21:34:13 -05:00
luigi1111
e2cf644bef
Merge pull request #9170
1bc09fc depends: add riscv64 to gitignore (tobtoht)
2024-03-07 21:25:00 -05:00
luigi1111
4582656f60
Merge pull request #9169
119e341 depends: remove unwind (tobtoht)
2024-03-07 21:24:30 -05:00
luigi1111
6e4ef12e50
Merge pull request #9168
0c9a5c5 depends: remove ccache (tobtoht)
2024-03-07 21:23:43 -05:00
luigi1111
1d24774b5b
Merge pull request #9167
442146a depends: libusb: update to 1.0.27 (tobtoht)
2024-03-07 21:22:17 -05:00
luigi1111
20dbf99795
Merge pull request #9166
5f1b5c2 depends: eudev: update to 3.2.14 (tobtoht)
2024-03-07 21:21:42 -05:00
jeffro256
7815023117
tx_memory_pool: make double spends a no-drop offense
Nodes who see different txs in a double spend attack will drop each other, splitting the network.
Issue found by @boog900.
2024-03-07 09:23:51 -06:00
jeffro256
399b884a9c
unit_tests: fix strtoul unit test 2024-03-07 09:05:09 -06:00
tobtoht
5dbaace1e8
depends: fix ar zero timestamp for openssl & unbound on android targets 2024-03-05 09:15:24 +01:00
tobtoht
358d27c2e4
depends: native_libtapi: don't embed git hash 2024-02-26 15:33:21 +01:00
jeffro256
38f354e89f
Enforce Tx unlock_time is Zero by Relay Rule
Related to https://github.com/monero-project/research-lab/issues/78

Added a relay rule that enforces the `unlock_time` field is equal to 0 for non-coinbase transactions.

UIs changed:
* Removed `locked_transfer` and `locked_sweep_all` commands from `monero-wallet-cli`

APIs changed:
* Removed `unlock_time` parameters from `wallet2` transfer methods
* Wallet RPC transfer endpoints send error codes when requested unlock time is not 0
* Removed `unlock_time` parameters from `construct_tx*` cryptonote core functions
2024-02-24 14:27:17 -06:00
jeffro256
2a2da79943
free function serialization DSL
Example usage for Seraphis types (in global or `sp` namespace):

```
BEGIN_SERIALIZE_OBJECT_FN(sp::SpCoinbaseEnoteCore)
    FIELD_F(onetime_address)
    VARINT_FIELD_F(amount)
END_SERIALIZE()

BEGIN_SERIALIZE_OBJECT_FN(sp::SpEnoteCore)
    FIELD_F(onetime_address)
    FIELD_F(amount_commitment)
END_SERIALIZE()
```
2024-02-24 11:24:47 -06:00
luigi1111
7b7958bbd9
Merge pull request #9004
cdab0d4 cmake: require libsodium (tobtoht)
684bfca depends: move sodium to packages (tobtoht)
2024-02-24 10:46:59 -05:00
tobtoht
cdab0d489c
cmake: require libsodium 2024-02-24 16:26:43 +01:00
tobtoht
684bfca765
depends: move sodium to packages 2024-02-24 16:25:13 +01:00
luigi1111
9c9cb6e458
Merge pull request #9191
3313933 docs: omit i2p port number from ANONYMITY_NETWORKS (selsta)
2024-02-24 10:17:48 -05:00
luigi1111
b12766a652
Merge pull request #9189
f7670c9 cryptonote_core: early out on out of bounds scaling parameter (selsta)
2024-02-24 10:16:54 -05:00
luigi1111
7c22754432
Merge pull request #9182
538f19b depends: android_ndk: update to 18b (tobtoht)
2024-02-24 10:15:34 -05:00