jeffro256
8af33c71cf
epee: syncobj: replace shims with Boost classes
...
a. `critical_section` is functionally identical to a `boost::recursive_mutex`
b. `critical_region_t` is functionally identical to a `boost::unique_lock`
c. remove some vestigial definitons `g_test_dbg_lock_sleep` as a variable
2025-04-01 11:09:26 -05:00
jeffro256
18376ca57d
epee: remove reg_exp_definer.h
...
Locking to initialize static block variables isn't necessary since C++11:
https://en.cppreference.com/w/cpp/language/storage_duration#Static_block_variables
2025-03-31 14:02:15 -05:00
tzadiko
fd08594caa
wallet: fix monero-wallet-rpc ignoring calls during sync
2025-03-28 20:13:02 -05:00
jeffro256
f728c963c1
CMakeLists: add cache option for MANUAL_SUBMODULES
2025-03-28 13:14:06 -05:00
SNeedlewoods
c848e21c43
fix: multisig stale data after failed refresh
2025-03-28 12:48:38 +01:00
tobtoht
b81b387606
easylogging: replace NULL with empty string literal
2025-03-27 10:48:51 +01:00
jeffro256
6d6e8e1733
construct_tx_and_get_tx_key: don't erase exception trace
2025-03-26 15:10:09 -05:00
tobtoht
977dedce2c
Merge pull request #9865
...
0e243a4ac
checkpoints: update to a recent block height (selsta)
2025-03-26 12:37:06 +00:00
tobtoht
4b127d9c6b
Merge pull request #9842
...
30ae2deed
Correct Max / Min Block Waiting Periods (tzadiko)
2025-03-26 12:35:32 +00:00
tzadiko
30ae2deed5
Correct Max / Min Block Waiting Periods
2025-03-25 16:55:43 -05:00
selsta
0e243a4ac0
checkpoints: update to a recent block height
2025-03-25 21:28:20 +01:00
iamamyth
cb91dcee36
tests: Speed up p2p reorg test
...
Use a fixed, 240s deadline for the daemons to reach agreement and poll
with a suitable frequency (.25s), rather than polling up to 100 times at
roughly 10s intervals.
2025-03-24 11:18:57 -07:00
tobtoht
7ea8bcdc91
Merge pull request #9808
...
446d9622f
logging: Generalize terminal color detection (iamamyth)
2025-03-24 14:06:18 +00:00
iamamyth
446d9622f8
logging: Generalize terminal color detection
...
Assume the terminal supports color codes if TERM ends with `-color` or
`-256color`, rather than special-casing a handful of such terminals.
Add tests for terminal color detection.
Co-authored-by: laanwj <126646+laanwj@users.noreply.github.com>
2025-03-24 11:07:33 -07:00
tobtoht
9b2031d244
Merge pull request #9861
...
55e6ba49c
Fix expected hash check (Lee *!* Clagett)
2025-03-24 13:59:18 +00:00
Lee *!* Clagett
55e6ba49cb
Fix expected hash check
2025-03-24 10:56:53 -04:00
tobtoht
84685492e6
Merge pull request #9840
...
8024d43e6
trezor: fix cmake variables (ComputeryPony)
2025-03-24 03:27:14 +00:00
tobtoht
642db87007
Merge pull request #9791
...
ef509e1c0
ci: introduce rust toolchain (tobtoht)
2025-03-24 03:26:20 +00:00
tobtoht
902b664e26
Merge pull request #9821
...
665316708
Fix HTTP unit tests (broken with new Boost versions) (Lee *!* Clagett)
2025-03-24 03:05:09 +00:00
tobtoht
f2d765afc4
Merge pull request #9809
...
8c43e33e3
logging: Fix easylogging++ init with blank config (iamamyth)
2025-03-24 03:02:46 +00:00
tobtoht
ef128a80e1
Merge pull request #9846
...
834438acb
Remove hidden transaction copy in add_block (Lee *!* Clagett)
2025-03-24 02:54:20 +00:00
tobtoht
ba77342faa
Merge pull request #9845
...
51a72c120
Blockchain: remove skip for pruned txs in `check_tx_inputs()` (jeffro256)
2025-03-24 02:53:13 +00:00
tobtoht
2d20c4a9b7
Merge pull request #9844
...
528664b1c
cryptonote_protocol: fix handling of pruned blocks during sync (jeffro256)
2025-03-24 02:50:17 +00:00
tobtoht
227e503922
Merge pull request #9832
...
5393bef13
wallet: fix different-signedness int comparison warnings (jeffro256)
2025-03-24 02:46:29 +00:00
tobtoht
dfa92d6031
Merge pull request #9824
...
da8907974
chore: fix some typos in comments (shenpengfeng)
2025-03-24 02:45:18 +00:00
tobtoht
3c6f1c7748
Merge pull request #9839
...
a5fabe513
trezor: fix protobuf 30 compatibility (tobtoht)
2025-03-23 16:20:39 +00:00
jeffro256
332d92ffbe
epee: span::operator[] allow mut ref from const span
...
Changes the `operator[]` method so we can get mutable
references to elements even if the span is `const`.
The operator is now also `constexpr`.
This behavior matches `std::span`.
C++ standard reference: https://en.cppreference.com/w/cpp/container/span/operator_at
2025-03-22 16:53:17 -05:00
Lee *!* Clagett
70fe289d82
Improve move/copy/default constructor semantics for tx and block
2025-03-21 14:02:12 -04:00
Lee *!* Clagett
f8ecd31743
Fix copies in ZMQ input/output
2025-03-18 01:11:12 -04:00
Lee *!* Clagett
834438acb8
Remove hidden transaction copy in add_block
2025-03-17 19:19:20 -04:00
jeffro256
51a72c1209
Blockchain: remove skip for pruned txs in check_tx_inputs()
...
I can't see how this would trigger in the current codebase, so it's not a *current* safety issue,
but I can very well see it becoming on in the future if downstream code doesn't handle the passing
of pruned transactions correctly. I think the safe/good choice would be to remove this skip now
that all transactions that pass into the mempool are supposed to be unpruned. And for all in-block
txs, `check_tx_inputs()` isn't called for checkpointed blocks, and we sync pruned blocks only if
syncing checkpointed blocks.
2025-03-17 09:31:50 -05:00
jeffro256
528664b1c8
cryptonote_protocol: fix handling of pruned blocks during sync
2025-03-17 09:09:25 -05:00
ComputeryPony
8024d43e6f
trezor: fix cmake variables
2025-03-16 18:57:44 -05:00
tobtoht
a5fabe5134
trezor: fix protobuf 30 compatibility
2025-03-16 23:02:45 +01:00
jeffro256
5393bef139
wallet: fix different-signedness int comparison warnings
2025-03-13 04:10:29 -05:00
tobtoht
f90a267fa3
Merge pull request #9820
...
50897a687
Limit scope of TCP checks to incoming only (Lee *!* Clagett)
2025-03-11 19:13:41 +00:00
tobtoht
44523cafff
Merge pull request #9135
...
c069c04ed
blockchain sync: reduce disk writes from 2 to 1 per tx (jeffro256)
2025-03-10 16:16:18 +00:00
jeffro256
c069c04ede
blockchain sync: reduce disk writes from 2 to 1 per tx
2025-03-10 01:02:37 -05:00
shenpengfeng
da8907974e
chore: fix some typos in comments
...
Signed-off-by: shenpengfeng <xinhangzhou@icloud.com>
2025-02-28 00:40:29 +08:00
Lee *!* Clagett
665316708c
Fix HTTP unit tests (broken with new Boost versions)
2025-02-25 18:51:56 -05:00
Lee *!* Clagett
50897a6871
Limit scope of TCP checks to incoming only
2025-02-24 21:55:35 -05:00
tobtoht
8d6aff9590
Merge pull request #9538
...
c461b3c67
make: remove static targets (tobtoht)
2025-02-24 18:16:13 +00:00
0xFFFC0000
f4672c2595
cryptonote_core: only verify txpool when the hardfork value has changed.
...
Co-authored-by: Boog900 <boog900@tutanota.com>
2025-02-24 17:25:27 +00:00
iamamyth
8c43e33e35
logging: Fix easylogging++ init with blank config
...
The upstream version of el::base::TypedConfigurations::unsafeGetConfigByRef
accesses uninitialized memory if a key doesn't exist.
Commit b2c59af84d
patched the library to
throw in this case, avoiding the invalid access, but the more suitable
pattern, both logically, and as evidenced by the behavior of
unsafeGetConfigByVal, would be to return a const reference to a
default-initialized value with static storage duration.
2025-02-19 15:02:08 -08:00
tobtoht
97c0ce73c4
Merge pull request #9804
...
418a9adb1
BlockchainLMDB: fix data.mdb nuking on Windows (jeffro256)
2025-02-17 18:23:06 +00:00
jeffro256
418a9adb13
BlockchainLMDB: fix data.mdb nuking on Windows
2025-02-17 11:57:32 -06:00
tobtoht
802844de23
Merge pull request #9802
...
c3fc0ffc3
common: add missing iomanip include (tobtoht)
2025-02-17 16:33:52 +00:00
tobtoht
c3fc0ffc37
common: add missing iomanip include
2025-02-17 17:20:03 +01:00
tobtoht
aae0c7743a
Merge pull request #9439
...
02e2a4f4c
assign default port for http and https clients (woodser)
2025-02-17 16:03:37 +00:00
woodser
02e2a4f4cd
assign default port for http and https clients
2025-02-17 08:11:44 -05:00