5851 Commits

Author	SHA1	Message	Date
Riccardo Spagni	52eb454d7b	Merge pull request #5491 ... 98fb98f9 wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero) 9074c0d8 wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero) 968848a7 wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)	2019-05-02 11:30:11 +02:00
Riccardo Spagni	efd2412e77	Merge pull request #5489 ... 64983fce wallet2: default to trying to keep 5 outputs of 2+ monero (moneromooo-monero)	2019-05-02 11:29:25 +02:00
Riccardo Spagni	08ab0cbdda	Merge pull request #5476 ... 0aaf5e2a device/trezor: device sorting and filtering improved (Dusan Klinec)	2019-05-02 11:28:51 +02:00
moneromooo-monero	e980938210	fix wide difficulty conversion with some versions of boost	2019-05-01 19:58:09 +00:00
moneromooo-monero	1c44e65863	wallet2: reject standalone short payment IDs in monero: URI API	2019-05-01 18:41:39 +00:00
moneromooo-monero	7e5158aa97	mnemonics: fix 4 byte UTF-8 rewriting	2019-04-30 21:10:54 +00:00
moneromooo-monero	ccc1e311dc	wallet_rpc_server: reject standalone short payment id in address book	2019-04-30 21:07:37 +00:00
moneromooo-monero	b4ca72dde9	wallet2: fix infinite loop picking outputs in corner case ... If we have fewer outputs available on the chain than what we require, but the output we're spending already has a ring, it would loop picking outputs randomly, but never find enough. Also tune logs for better debugging this kind of thing.	2019-04-29 10:02:20 +00:00
moneromooo-monero	5e0da6fb68	change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 ... SHA1 is too close to bruteforceable	2019-04-26 11:37:15 +00:00
moneromooo-monero	98fb98f93f	wallet_rpc_server: adding missing return on error in set_daemon	2019-04-25 23:35:37 +00:00
moneromooo-monero	9074c0d8cf	wallet_rpc_server: return false on error in set_log_categories ... Reported by SmajeNz0	2019-04-25 23:35:37 +00:00
moneromooo-monero	968848a77b	wallet_rpc_server: fix crash in validate_address if no wallet is loaded ... Reported by SmajeNz0	2019-04-25 23:35:37 +00:00
moneromooo-monero	0eb0d6b802	rpc: improve get_output_distribution ... It can now handle small reorgs without having to rescan the whole blockchain. Also add a test for it.	2019-04-25 16:49:29 +00:00
Dusan Klinec	0aaf5e2ac8	device/trezor: device sorting and filtering improved ... - Trezor type detection refactored, T1 disabled (was enabled before which was a bug) - Sort connected devices by env TREZOR_PATH - Compatibility with Trezor ecosystem using TREZOR_PATH env var - Enables to pick particular Trezor to use in GUI as we don't have the multi-device selection yet - Dump all detected devices to log for better debugging / troubleshooting	2019-04-25 00:31:10 +02:00
Riccardo Spagni	581994b61c	Merge pull request #5486 ... 4be18df3 tx_sanity_check: relax uniqueness check a bit (moneromooo-monero) b386ae57 wallet2: add missing "sanity check failed" reason message (moneromooo-monero)	2019-04-24 22:41:40 +02:00
Riccardo Spagni	2e2ee3d823	Merge pull request #5485 ... c519d1df wallet2: fix wrong change being recorded in sweep_all (moneromooo-monero)	2019-04-24 22:41:18 +02:00
Riccardo Spagni	2aa7fbd1d6	Merge pull request #5480 ... 7af49ef0 daemonizer: add --non-interactive for windows (moneromooo-monero)	2019-04-24 22:39:50 +02:00
Riccardo Spagni	edcb0cfff2	Merge pull request #5477 ... 97e1c927 wallet: fix key image computation signaling to the device (Dusan Klinec)	2019-04-24 22:38:36 +02:00
Riccardo Spagni	fd7ed93526	Merge pull request #5470 ... 31a9aa83 wallet_rpc_server: add block_height and frozen to incoming_transfers (moneromooo-monero)	2019-04-24 22:37:43 +02:00
moneromooo-monero	28a7d31565	p2p: do not send last_seen timestamp to peers ... This can be used for fingerprinting and working out the network topology. Instead of sending the first N (which are sorted by last seen time), we sent a random subset of the first N+N/5, which ensures reasonably recent peers are used, while preventing repeated calls from deducing new entries are peers the target node just connected to. The list is also randomly shuffled so the original set of timestamps cannot be approximated.	2019-04-24 17:56:12 +00:00
moneromooo-monero	64983fcee4	wallet2: default to trying to keep 5 outputs of 2+ monero ... In the case where previously a second unneeded output would be added to a transaction. This should help *some* of the cases where outputs are slowly being consolidated, leading to the whole balance being locked when sending monero.	2019-04-24 12:25:43 +00:00
moneromooo-monero	4be18df32a	tx_sanity_check: relax uniqueness check a bit ... It triggers easily on testnet	2019-04-23 21:59:57 +00:00
moneromooo-monero	b386ae5725	wallet2: add missing "sanity check failed" reason message	2019-04-23 21:59:57 +00:00
moneromooo-monero	c519d1df34	wallet2: fix wrong change being recorded in sweep_all ... leading to the sanity check triggering	2019-04-23 21:58:55 +00:00
moneromooo-monero	7af49ef0c2	daemonizer: add --non-interactive for windows ... The RPC functional tests need it Thanks to iDunk for debugging/testing	2019-04-23 00:26:51 +00:00
Dusan Klinec	97e1c9278c	wallet: fix key image computation signaling to the device	2019-04-22 16:14:50 +02:00
moneromooo-monero	31a9aa83af	wallet_rpc_server: add block_height and frozen to incoming_transfers	2019-04-20 08:44:09 +00:00
moneromooo-monero	375fde9454	hardfork: fix off by one updating fork index after popping	2019-04-20 00:05:35 +00:00
Riccardo Spagni	71c6b24893	Merge pull request #5464 ... 0f52fe4c Windows: work around a boost 1.70 and cmake SNAFU (iDunk5400) b414b69f Windows: fix a build error in MSYS2 with boost 1.70.0 (iDunk5400)	2019-04-18 22:04:11 +02:00
Riccardo Spagni	2267f110b2	Merge pull request #5463 ... fbbe75d7 device/trezor: button request callback fix (Dusan Klinec)	2019-04-18 22:03:30 +02:00
Riccardo Spagni	950f79dc03	Merge pull request #5389 ... 588e6700 simplewallet: fix output representation offset (moneromooo-monero) 35e0a968 wallet2: "output lineup" fake out selection (moneromooo-monero)	2019-04-18 22:01:51 +02:00
Riccardo Spagni	2e342d8df6	Merge pull request #5458 ... 84047cb7 wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)	2019-04-18 22:01:22 +02:00
Riccardo Spagni	b8f1709684	Merge pull request #5456 ... 58eade68 simplewallet: add the change amount to the prompt when locking (moneromooo-monero)	2019-04-18 22:01:03 +02:00
Riccardo Spagni	55807141f2	Merge pull request #5453 ... 71102267 wallet_rpc_server: set suggested_confirmations_threshold for pool txes (moneromooo-monero)	2019-04-18 21:59:01 +02:00
Dusan Klinec	fbbe75d75f	device/trezor: button request callback fix	2019-04-18 18:04:54 +02:00
moneromooo-monero	588e670089	simplewallet: fix output representation offset	2019-04-18 15:14:41 +00:00
moneromooo-monero	35e0a968bd	wallet2: "output lineup" fake out selection ... Based on python code by sarang: https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py	2019-04-18 15:14:38 +00:00
iDunk5400	b414b69f5c	Windows: fix a build error in MSYS2 with boost 1.70.0	2019-04-18 17:00:13 +02:00
moneromooo-monero	84047cb729	wallet_rpc_server: add unlocked field to incoming_transfers output	2019-04-17 15:30:49 +00:00
moneromooo-monero	58eade689c	simplewallet: add the change amount to the prompt when locking	2019-04-17 11:05:18 +00:00
Riccardo Spagni	e9464eb5e3	Merge pull request #5413 ... 5fafb90e testdb: add override keyword where missing (stoffu)	2019-04-17 08:27:36 +02:00
stoffu	5fafb90e91	testdb: add override keyword where missing ... and delete obsolete BlockchainBDB::get_tx_output_indices along the way	2019-04-17 10:26:25 +09:00
moneromooo-monero	b0a346689b	daemon: fix absolute/relative log file test for windows	2019-04-16 22:15:36 +00:00
moneromooo-monero	7110226794	wallet_rpc_server: set suggested_confirmations_threshold for pool txes	2019-04-16 20:59:57 +00:00
moneromooo-monero	294e858d57	wallet_rpc_server: add set_log_level/set_log_categories	2019-04-16 20:50:15 +00:00
Riccardo Spagni	1b092f3a44	Merge pull request #5452 ... c30d93fc rpc: add a pruned bool to the prune_blockchain call (moneromooo-monero)	2019-04-16 22:48:50 +02:00
Riccardo Spagni	810dd0a5f6	Merge pull request #5450 ... 926e0472 simplewallet: add another warning about long payment ids (moneromooo-monero)	2019-04-16 22:48:18 +02:00
Riccardo Spagni	68d131615e	Merge pull request #5448 ... d009f6dd rpc: fix get_block_hashes.bin from wallet on pruned blockchain (moneromooo-monero) bb0ef5b1 blockchain: lock the blockchain while pruning (moneromooo-monero)	2019-04-16 22:47:36 +02:00
Riccardo Spagni	c8ce4217cf	Merge pull request #5445 ... b18f0b10 wallet: new --offline option (moneromooo-monero)	2019-04-16 22:46:53 +02:00
Riccardo Spagni	f376cd5605	Merge pull request #5446 ... 7d79222f daemon: remove debug info (moneromooo-monero) 8fec0f98 functional_tests: add sweep_single test (moneromooo-monero) 9880d61b wallet_rpc_server: remove unused code (moneromooo-monero) 8a61b33d rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero) 56508524 rpc: add relayed in get_transaction output (moneromooo-monero) 82e510f1 rpc: set default log category in core_rpc_server.h (moneromooo-monero)	2019-04-16 22:46:29 +02:00
Riccardo Spagni	e98cbfbdfe	Merge pull request #5444 ... 6643b047 Increment m_threads_active when mining thread starts (Doyle)	2019-04-16 22:45:42 +02:00
Riccardo Spagni	c5f64bf170	Merge pull request #5443 ... 07dd5536 hardfork: remove "no hf version db" recreation check (moneromooo-monero)	2019-04-16 22:45:23 +02:00
Riccardo Spagni	8af1a89e4c	Merge pull request #5441 ... b3648232 daemon: fix ratio not being floating point (moneromooo-monero) e1b097b9 core_rpc_server: remove dummy assigning int to bool (moneromooo-monero)	2019-04-16 22:44:41 +02:00
Riccardo Spagni	1fc20ba48a	Merge pull request #5439 ... f26e0b5d cryptonote_protocol: warn when the last connection goes (moneromooo-monero)	2019-04-16 22:44:19 +02:00
Riccardo Spagni	ac8e2a7819	Merge pull request #5437 ... acb68dba bulletproofs: cut down on keyV allocations (moneromooo-monero)	2019-04-16 22:44:00 +02:00
Riccardo Spagni	b0472c43a1	Merge pull request #5435 ... 5140c15e daemon: if a log file has a /, interpret it from the cwd (moneromooo-monero)	2019-04-16 22:42:26 +02:00
Riccardo Spagni	1f01070a0c	Merge pull request #5434 ... ccb996af rpc: new sanity check on relayed transactions (moneromooo-monero)	2019-04-16 22:41:40 +02:00
Riccardo Spagni	8deee24cbb	Merge pull request #5431 ... 34f8c237 simplewallet: fix warning about long payment id using the old option (moneromooo-monero)	2019-04-16 22:40:34 +02:00
Riccardo Spagni	35b3d754e8	Merge pull request #5429 ... bcb86ae6 wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)	2019-04-16 22:39:37 +02:00
Riccardo Spagni	45e1f7c292	Merge pull request #5428 ... f3425f8d rpc.getblocktemplate: set reserved_offset to zero when reserve_size==0 (stoffu)	2019-04-16 22:39:18 +02:00
Riccardo Spagni	8d16e92dcb	Merge pull request #5425 ... 58585986 p2p: fix integer overflow in host bans (moneromooo-monero)	2019-04-16 22:38:56 +02:00
Riccardo Spagni	a1ea611e24	Merge pull request #5424 ... 93bb2f48 ringct: prevent use of full ringct signatures for more than one input (moneromooo-monero)	2019-04-16 22:38:32 +02:00
Riccardo Spagni	8966ac314c	Merge pull request #5422 ... 2c221d1b wallet2: update estimate_rct_tx_size for smaller rct proofs (moneromooo-monero)	2019-04-16 22:38:11 +02:00
Riccardo Spagni	96696d1e75	Merge pull request #5418 ... 374f388d wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)	2019-04-16 22:37:52 +02:00
Riccardo Spagni	0d2aaac15b	Merge pull request #5414 ... e9fac29a unit_tests/long_term_block_weight: some tweaks that seem to make more sense (stoffu) 467f4c7e tests/block_weight: use integer division when computing median (stoffu) 815d08dc tests/block_weight: remove unused MULTIPLIER_SMALL (stoffu) 661f1fb8 blockchain: remove unused calc of short_term_constraint (stoffu)	2019-04-16 22:37:02 +02:00
Riccardo Spagni	313a56a2da	Merge pull request #5406 ... bea1918a blockchain_import: error out if preparing to handle blocks fails (moneromooo-monero)	2019-04-16 22:32:27 +02:00
Riccardo Spagni	ce2f46f76b	Merge pull request #5405 ... ffdbcfb6 core: don't check block rate nor fork time in regtest mode (moneromooo-monero)	2019-04-16 22:32:06 +02:00
Riccardo Spagni	46c477ab30	Merge pull request #5400 ... 5e673c03 blockchain_db: fix db txn ending too early (moneromooo-monero)	2019-04-16 22:30:40 +02:00
moneromooo-monero	c30d93fcd9	rpc: add a pruned bool to the prune_blockchain call	2019-04-16 15:15:14 +00:00
moneromooo-monero	926e047288	simplewallet: add another warning about long payment ids	2019-04-16 10:11:02 +00:00
moneromooo-monero	7d79222f5c	daemon: remove debug info	2019-04-15 22:32:09 +00:00
moneromooo-monero	d009f6dd61	rpc: fix get_block_hashes.bin from wallet on pruned blockchain ... We want to get all blocks here, even pruned ones	2019-04-15 22:27:15 +00:00
moneromooo-monero	bb0ef5b1f2	blockchain: lock the blockchain while pruning	2019-04-15 22:27:12 +00:00
moneromooo-monero	b18f0b1051	wallet: new --offline option ... It will avoid connecting to a daemon (so useful for cold signing using a RPC wallet), and not perform DNS queries.	2019-04-15 09:14:12 +00:00
moneromooo-monero	9880d61b98	wallet_rpc_server: remove unused code	2019-04-15 09:13:12 +00:00
moneromooo-monero	8a61b33d8e	rpc: omit irrelevant fields for pool txes in gettransactions	2019-04-15 09:11:54 +00:00
moneromooo-monero	565085245a	rpc: add relayed in get_transaction output	2019-04-15 09:11:50 +00:00
moneromooo-monero	82e510f15e	rpc: set default log category in core_rpc_server.h	2019-04-15 09:10:29 +00:00
Riccardo Spagni	e89aa2ec56	Merge pull request #5421 ... e78cea74 rpc: fix off by one in get_height (moneromooo-monero)	2019-04-15 09:22:50 +02:00
Riccardo Spagni	64a4aa4f60	Merge pull request #5408 ... c4f8a8a6 build fix: combinator.h stdexcept missing include (Dusan Klinec)	2019-04-15 09:21:00 +02:00
Riccardo Spagni	9bd0983d5e	Merge pull request #5402 ... cbf32241 rpc: make wide_difficulty hexadecimal (moneromooo-monero)	2019-04-15 09:18:10 +02:00
Riccardo Spagni	e31559d319	Merge pull request #5398 ... 41901b8d device/trezor: env-configurable ports (Dusan Klinec) c97a1f79 tests: trezor tests fixes and improvements (Dusan Klinec)	2019-04-15 09:17:47 +02:00
Riccardo Spagni	8bf0a3f123	Merge pull request #5396 ... b40392fb wallet2: add --no-dns flag (moneromooo-monero)	2019-04-15 09:17:26 +02:00
Riccardo Spagni	98f4c8af98	Merge pull request #5395 ... 15f27c80 wallet2: support multi out txes without change in sanity check (moneromooo-monero)	2019-04-15 09:17:07 +02:00
Riccardo Spagni	89b8ecfc7c	Merge pull request #5392 ... a2195b9b crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) (stoffu)	2019-04-15 09:14:28 +02:00
Riccardo Spagni	3f46c5b4e1	Merge pull request #5365 ... 383c38fd fix init warning on whatever compiler version (italocoin)	2019-04-15 09:12:50 +02:00
Riccardo Spagni	37aea526a9	Merge pull request #5355 ... c68fe787 device/trezor: add button pressed request (Dusan Klinec) 827f52ad wallet: API changes to enable passphrase entry (Dusan Klinec)	2019-04-15 09:12:20 +02:00
Doyle	6643b04737	Increment m_threads_active when mining thread starts	2019-04-15 13:08:33 +10:00
moneromooo-monero	07dd55363c	hardfork: remove "no hf version db" recreation check ... This is now obsolete, and this removes the warning on startup on a new db that confuses some people	2019-04-14 10:34:29 +00:00
moneromooo-monero	f26e0b5d11	cryptonote_protocol: warn when the last connection goes	2019-04-14 10:30:01 +00:00
moneromooo-monero	b364823286	daemon: fix ratio not being floating point ... Coverity 197648	2019-04-14 09:26:12 +00:00
moneromooo-monero	e1b097b99b	core_rpc_server: remove dummy assigning int to bool ... Coverity 197653	2019-04-14 09:26:12 +00:00
moneromooo-monero	5e673c03fe	blockchain_db: fix db txn ending too early ... The db txn in add_block ending caused the entire overarching batch txn to stop. Also add a new guard class so a db txn can be stopped in the face of exceptions. Also use a read only db txn in init when the db itself is read only, and do not save the max tx size in that case.	2019-04-14 08:35:38 +00:00
moneromooo-monero	acb68dbaa9	bulletproofs: cut down on keyV allocations	2019-04-13 22:37:08 +00:00
moneromooo-monero	5140c15e56	daemon: if a log file has a /, interpret it from the cwd ... rather than from data dir where it normally is. It makes things like --log-file ./foo.log behave as you'd expect.	2019-04-13 11:21:08 +00:00
moneromooo-monero	ccb996afc6	rpc: new sanity check on relayed transactions ... This will weed out some transactions with silly rings	2019-04-12 20:22:09 +00:00
moneromooo-monero	34f8c237c2	simplewallet: fix warning about long payment id using the old option	2019-04-12 14:09:26 +00:00
moneromooo-monero	bcb86ae651	wallet_rpc_server: fix inconsistent wallet caches on reload ... Loading the same wallet as the currently loaded one would autosave the current state after loading it, leading to some kind of rollback effect. We now save before loading to avoid this. If loading fails, it means the current wallet will be saved (or maybe not, depending on where the failure occurs: most of the sanity checks occur before saving). There is a new autosave_current flag to open/restore calls so the (enabled by default) autosave can be skipped.	2019-04-12 13:40:42 +00:00
stoffu	f3425f8d32	rpc.getblocktemplate: set reserved_offset to zero when reserve_size==0	2019-04-12 18:55:38 +09:00
moneromooo-monero	5858598604	p2p: fix integer overflow in host bans	2019-04-11 21:59:27 +00:00