jeffro256
eb0e4052b7
gamma picker: relax constructor requirements and test for selecting outputs from first spendable block
2023-04-02 20:06:09 -05:00
moneromooo-monero
7a4a03d9d3
wallet2: do not commit transactions more than once
...
Fixes #8793
2023-03-21 21:05:53 +00:00
Jeffrey Ryan
7159f92a57
verRctNonSemanticsSimpleCached: fix fragility
2023-03-17 18:45:35 -05:00
koe
8d94d08816
replace 'multisig()' with 'get_multisig_status()' using multisig_account_status and including '.kex_is_done' member
2023-02-28 12:54:40 -06:00
koe
2a7435e026
variant: add mutable unwrap and visitation
2023-02-12 13:00:53 -06:00
koe
bc3cec4634
add variant class with cleaner interface than boost::variant<>
2023-01-30 22:03:35 -06:00
mj-xmr
5b4fea72cf
Copyright: Update to 2023
...
Co-authored-by: plowsof <plowsof@protonmail.com>
extra files
2023-01-16 13:00:18 +01:00
luigi1111
75d80d431a
Merge pull request #8686
...
7a3a593
2023-01-11 12:13:48 -05:00
luigi1111
9489586add
Merge pull request #8648
...
8687da6
2023-01-11 11:41:11 -05:00
luigi1111
b363eebd52
Merge pull request #8643
...
faaf2af
2023-01-11 11:39:42 -05:00
Jeffrey Ryan
7a3a593a77
common: move boost_serialization_helper.h out and cleanup includes
2022-12-22 12:18:02 -06:00
koe
5c505bda29
performance test framework updates: allow custom test parameters, better error reporting
2022-12-01 17:07:52 -06:00
luigi1111
7275a4d23b
Merge pull request #8627
...
a7bf3af
2022-12-01 01:10:20 -06:00
luigi1111
2f168da7f7
Merge pull request #8618
...
1114e7e
2022-12-01 01:08:53 -06:00
luigi1111
12489c69cb
Merge pull request #8572
...
50b7492
2022-12-01 01:01:34 -06:00
Jeffrey Ryan
8687da6276
common: DNSResolver can handle hostnames without dot characters
...
Unrelated, but similar code-wise to #8643 . There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
2022-11-21 15:54:23 -06:00
Jeffrey Ryan
faaf2af43b
p2p: fix exclusive node DNS resolution for certain hosts
...
Fixes #8633 . The function `append_net_address` did not parse hostname + port addresses (e.g. `bar:29080`) correctly if the hostname did not contain a `'.'` character.
@vtnerd comments 1
clear up 2nd conditional statement
2022-11-17 18:55:09 -06:00
Dusan Klinec
1114e7eed7
fix(trezor-tests): fix trezor tests build, fix integrated addr test
...
- fix integrated address test, it was not testing integrated address suport
- fix trezor test build as dependent classes were changed
- add a friend test class for Monero::WalletImpl to support wallet api tests
When using wallet_api in tests, synthetic chain is used. Without being able to set `allow_mismatched_daemon_version` in the underlying wallet, we are not able to use a synthetic chain with the tests
2022-11-17 12:12:23 +01:00
Lee Clagett
a7bf3aff2c
Fix dandelion++ fluff/stem bug with local txes
2022-10-25 16:09:55 -04:00
luigi1111
fc907a9570
Merge pull request #8587
...
8e7c7af
2022-09-26 15:00:35 -05:00
luigi1111
239d210a18
Merge pull request #8576
...
28f25c0
2022-09-26 14:50:56 -05:00
luigi1111
0a10a4f870
Merge pull request #8329
...
4b0785f
2022-09-26 14:46:06 -05:00
SChernykh
8e7c7af05f
Move update_checkpoints() to a later stage
...
update_checkpoints() makes a few DNS requests and can take up to 20-30 seconds to complete (3-6 seconds on average). It is currently called from core::handle_incoming_block() which holds m_incoming_tx_lock, so it blocks all incoming transactions and blocks processing while update_checkpoints() is running. This PR moves it to until after a new block has been processed and relayed, to avoid full monerod locking.
2022-09-22 13:04:50 +02:00
koe
4b0785f1c9
add an option to force-update multisig key exchange under some circumstances
2022-09-21 12:38:35 -05:00
SChernykh
28f25c0dbc
Second thread pool for IO
2022-09-20 09:59:58 +02:00
Jeffrey Ryan
50b7492e67
unit_tests: suppress memwipe unit warning
...
Fixes warning:
```
warning: ‘*(uint32_t*)quux’ may be used uninitialized [-Wmaybe-uninitialized]
49 | MDEBUG(std::hex << std::setw(8) << std::setfill('0') << *(uint32_t*)quux);
warning: ‘quux’ may be used uninitialized [-Wmaybe-uninitialized]
50 | if (wipe) { ASSERT_TRUE(memcmp(quux, "bar", 3)); }
```
2022-09-16 10:47:00 -05:00
luigi1111
c9cfa25183
Merge pull request #8556
...
b8271ab
2022-09-15 00:35:03 -05:00
luigi1111
df37c148d4
Merge pull request #8551
...
eca7f6af713c3c564a7a3fix #8537 seed restore (suggestions by @UkoeHB) (j-berman)
2022-09-15 00:34:05 -05:00
j-berman
b8271ab881
wallet2: check wallet compatibility with daemon's hard fork version
2022-09-12 21:24:24 -06:00
luigi1111
ed150fa821
Merge pull request #8538
...
3987827
2022-09-09 12:53:51 -05:00
luigi1111
c89d06341a
Merge pull request #8513
...
959a3e6a098504c5579ac1e912ec692f1d467b6d6ad9fc666
2022-09-09 12:48:47 -05:00
j-berman
564a7a31e8
multisig: fix #8537 seed restore (suggestions by @UkoeHB)
...
- spend secret key is no longer the sum of multisig key shares;
no need to check that is the case upon restore.
- restoring a multisig wallet from multisig info means that the
wallet must have already completed all setup rounds. Upon restore,
set the number of rounds completed accordingly.
2022-09-06 11:59:25 -06:00
Lee Clagett
3987827517
Fix shared_ptr cycle in test_epee_connection.test_lifetime
2022-08-26 20:12:13 -04:00
luigi1111
77053298ed
Merge pull request #8450
...
600de07ac6db92
2022-08-22 22:47:45 -05:00
luigi1111
ce80747c58
Merge pull request #8427
...
1fc60ca
2022-08-22 22:45:14 -05:00
luigi1111
080fc69435
Merge pull request #8299
...
a0df140
2022-08-22 22:37:08 -05:00
moneromooo-monero
a0985044d9
wallet2: better test on whether to allow output import
...
Being offline is not a good enough heuristic, so we keep track
of whether the wallet ever refreshed from a daemon, which is a
lot better, and probably the best we can do without manual user
designation (which would break existing cold wallet setups till
the user designates those wallets)
2022-08-18 19:29:03 +00:00
moneromooo-monero
c5579ac236
allow exporting outputs in chunks
...
this will make it easier huge wallets to do so without hitting
random limits (eg, max string size in node).
2022-08-18 06:53:41 +00:00
j-berman
1e912ecd8a
wallet2: fixes for export/import output flow
...
- only allow offline wallets to import outputs
- don't import empty outputs
- export subaddress indexes when exporting outputs
2022-08-16 14:22:42 +00:00
moneromooo-monero
e0b3507c88
tests: update block_weight for 2021 scaling
...
the test was still performed with consensus rules from before
that change
2022-08-08 06:04:54 +00:00
j-berman
1fc60cac58
Publish submitted txs via zmq
2022-07-21 11:36:00 -07:00
moneromooo-monero
ac6db928c2
functional_tests: silence the cpu power test program
...
it's very spammy and drowns the test output
2022-07-21 12:00:05 +00:00
luigi1111
9df069f4ce
Merge pull request #8426
...
a82fba43be1dbd724ff21
2022-07-15 11:25:11 -04:00
koe
edcc094558
derive multisig tx secret keys from an entropy source plus the tx inputs' key images
2022-07-13 12:40:34 -05:00
j-berman
a82fba4b7b
address PR comments
2022-07-08 15:10:03 -07:00
anon
724ff21447
connection: add segfault and deadlocks demo
2022-07-05 22:31:26 -07:00
anon
c7b2944f89
multisig: fix critical vulnerabilities in signing
2022-06-30 12:56:40 -05:00
moneromooo-monero
7f3e31d797
unit_tests: fix accessing invalid memory in tree_hash test
2022-06-21 11:34:26 +00:00
Dusan Klinec
a0df140fd6
feat(trezor): add HF15 support, BP+
...
- BP+ support added for Trezor
- old Trezor firmware version support removed, code cleanup
2022-06-20 19:42:56 +02:00
luigi1111
9750e1fa10
Merge pull request #8340
...
08080dfa66a52d
2022-05-26 21:26:42 -05:00
luigi1111
f9d789d68c
Merge pull request #8330
...
2dab31f
2022-05-26 21:23:38 -05:00
j-berman
2dab31f62f
Don't exclusively drop tor/i2p outgoing cxns in idle loop
2022-05-18 09:54:21 -07:00
Jeffrey Ryan
08080df2d9
unit_tests: add more sha256sum test cases
2022-05-18 01:34:20 +02:00
moneromooo-monero
2979474221
disable multisig by default
...
There are vulnerabilities in multisig protocol if the parties do not
trust each other, and while there is a patch for it, it has not been
throroughly reviewed yet, so it is felt safer to disable multisig by
default for now.
If all parties in a multisig setup trust each other, then it is safe
to enable multisig.
2022-05-17 19:52:03 +00:00
luigi1111
c76e33bc44
Merge pull request #8304
...
0226df9
2022-05-10 16:57:23 -05:00
luigi1111
d58ea37a8d
Merge pull request #8302
...
41da2fe
2022-05-10 16:56:39 -05:00
luigi1111
436ca13722
Merge pull request #8277
...
baee2c0
2022-05-10 16:49:13 -05:00
luigi1111
c1625a8928
Merge pull request #8220
...
0d6ecb1
2022-05-10 16:41:02 -05:00
SChernykh
0226df9fae
More tests for view tags
...
P2Pool can create transactions with more than 128 outputs, which make output_index's varint larger than 1 byte. Added this test case.
2022-04-29 22:53:59 +02:00
koe
0d6ecb1136
multisig: add post-kex verification round to check that all participants have completed the multisig address
2022-04-29 14:04:59 -05:00
Akrit
41da2fe6f3
Update copyright to 2022 for Hardfork files
...
Update Makefile and LICENSE
2022-04-29 11:12:36 +02:00
luigi1111
e13244ea9c
Merge pull request #8178
...
5d388eb
2022-04-25 10:18:26 -05:00
Luke Parker
baee2c06ec
Preserve commitment format inside transactions
2022-04-21 18:58:47 -04:00
luigi1111
96758a7d05
Merge pull request #8061
...
ea87b30
2022-04-19 22:14:03 -05:00
j-berman
5d388eb74d
Bump ring size to 16 for v15 & remove set default in wallet cli
2022-04-18 14:36:28 -07:00
Jeffrey
40f02f9d73
Add Include statements
2022-04-18 09:55:20 -05:00
j-berman
ea87b30f89
Add view tags to outputs to reduce wallet scanning time
...
Implements view tags as proposed by @UkoeHB in MRL issue
https://github.com/monero-project/research-lab/issues/73
At tx construction, the sender adds a 1-byte view tag to each
output. The view tag is derived from the sender-receiver
shared secret. When scanning for outputs, the receiver can
check the view tag for a match, in order to reduce scanning
time. When the view tag does not match, the wallet avoids the
more expensive EC operations when deriving the output public
key using the shared secret.
2022-04-18 00:49:53 -07:00
moneromooo-monero
b030f20751
Fee changes from ArticMine
...
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf
with a change to use 1.7 instead of 2.0 for the max long term increase rate
2022-04-10 18:13:34 +00:00
moneromooo-monero
9f786f0550
epee: allow copying a rolling_median_t object
2022-04-10 18:13:31 +00:00
reemuru
6abe3fee19
tests: integrated_address: remove missing payment id assertion
...
The integrated address functional test fails in the workflows due
to an assertion for missing payment id that is no longer needed.
Remove the assertion and update the assertion count.
Fixes 7dcfccb
2022-04-06 06:49:01 -05:00
luigi1111
c11385591e
Merge pull request #8228
...
1ce9e9c
2022-04-06 00:22:23 -04:00
luigi1111
04e490c8da
Merge pull request #8205
...
0d6fce8
2022-04-06 00:11:14 -04:00
luigi1111
0eb1b570b6
Merge pull request #8197
...
da9aa1f
2022-04-06 00:08:53 -04:00
moneromooo-monero
4c94cfecfc
store outPk/8 in the tx for speed
...
It avoids dividing by 8 when deserializing a tx, which is a slow
operation, and multiplies by 8 when verifying and extracing the
amount, which is much faster as well as less frequent
2022-04-05 18:50:22 +00:00
moneromooo-monero
a0d80b1f95
plug bulletproofs plus into consensus
2022-04-05 18:50:17 +00:00
Sarang Noether
bd27debb2d
Bulletproofs+
2022-04-04 08:23:21 +00:00
Jeffrey
1ce9e9cda4
Remove dead code from parserse_base_utils and fix unit tests
...
* Remove `match_string()`, `match_number()`, and `match_word()`
* Remove `match_word_with_extrasymb()` and `match_word_til_equal_mark()`
* Adapt unit test for `match_number()` to `match_number2()`
* Adapt unit test for `match_string()` to `match_string2()`
Note: the unit tests were testing for the old version of the functions, and
the interfaces for these functions changed slightly, so I had to also edit
the tests.
As of writing, this PR has no merge conflicts with #8211
Additional changes during review:
* Explicitly set up is_[float/signed]_val to be changed before each call
* Structify the tests and fix uninitialized variables
2022-03-30 13:29:32 -05:00
luigi1111
d9e6baac42
Merge pull request #8158
...
e5000a9
2022-03-18 16:28:16 -05:00
mj-xmr
0d6fce8995
Compil. time: cryptonote_core minus portable_storage header
2022-03-04 12:48:35 +01:00
mj-xmr
da9aa1f7f8
Copyright: Update to 2022
2022-03-04 06:59:20 +01:00
luigi1111
abae63c37d
Merge pull request #8052
...
c36ea26
2022-03-02 18:52:51 -05:00
luigi1111
5eaa4434e8
Merge pull request #7877
...
e08abaa
2022-03-02 18:51:54 -05:00
koe
e08abaa43f
multisig key exchange update and refactor
2022-02-22 16:37:42 -06:00
woodser
e5000a9f0c
Balance includes unconfirmed transfers to self
2022-01-31 07:52:38 -05:00
koe
c36ea26e5c
fix ge_p3_is_point_at_infinity(), which is evaluating field elements that haven't been reduced by the field order
2022-01-25 07:14:46 -06:00
selsta
e9156d78a3
functional_tests: update uri test with external pid
2021-12-14 23:35:48 +01:00
moneromooo-monero
bbe3b276b8
tx_pool: full tx revalidation on fork boundaries
...
avoids mining txes after a fork that are invalid by this fork's
rules, but were valid by the previous fork rules at the time
they were verified and added to the txpool.
2021-11-01 20:56:38 +00:00
luigi1111
45920c36f1
Merge pull request #7874
...
91548838922f96
2021-10-11 12:56:14 -05:00
luigi1111
e7a1a095ac
Merge pull request #7923
...
5eaedb5
2021-09-23 22:16:38 -05:00
anon
9154883f3e
node_server: fix race condition
2021-09-20 20:58:23 +00:00
anon
8922f96e61
node_server: add race condition demo
2021-09-20 20:58:23 +00:00
mj-xmr
1b7a708fa3
Mac: UT node server fix IP localhost by aliasing
2021-09-12 15:51:14 +02:00
luigi1111
e48e909911
Merge pull request #7880
...
573a025
2021-09-09 15:18:17 -04:00
luigi1111
acfe3f8ded
Merge pull request #7828
...
b2c59af
2021-09-09 15:16:06 -04:00
moneromooo-monero
5eaedb51b9
unit_tests: fix use after free in serialization test
2021-09-08 01:03:34 +00:00
selsta
573a0255a8
core_tests: remove unused typedef, fix warning
2021-08-19 15:57:13 +02:00
luigi1111
82149bfe44
Merge pull request #7818
...
9c8e3e8
2021-08-11 22:40:13 -04:00
luigi1111
521b4d9ded
Merge pull request #7809
...
7354ffb
2021-08-11 22:35:15 -04:00
moneromooo-monero
7354ffb8a7
p2p: remove blocked addresses/hosts from peerlist
2021-08-05 17:29:25 +00:00
mj-xmr
b2c59af84d
EasyLogging++: new anti-UB test and propagating exception
2021-08-03 17:10:21 +02:00
anon
9c8e3e832e
unit_tests: fix broken tests
...
boosted_tcp_server: check condition before sleep too
cryptonote_protocol_handler: each instance of BlockchainLMDB requires separate thread due to private thread local fields
2021-07-28 13:38:24 +00:00
mj-xmr
5e6762d459
EasyLogging++: Add UTests, that protect against regressions
2021-07-06 06:50:52 +02:00
moneromooo-monero
4251cc0b4d
unit_tests: check for ge_frombytes_vartime failure
...
CID 1446559
2021-06-11 07:51:45 +00:00
luigi1111
7499837a6f
Merge pull request #7661
...
08e4497
2021-06-10 12:00:54 -05:00
luigi1111
08726ff0f3
Merge pull request #7723
...
3450f4b
2021-06-01 22:09:54 -05:00
luigi1111
fcb347820d
Merge pull request #7713
...
b40129e
2021-06-01 22:08:40 -05:00
mj-xmr
3450f4bc04
Doc: funtional_tests add new mining env vars and how to use them
2021-05-14 11:27:56 +02:00
luigi1111
b7ee587ddb
Merge pull request #7691
...
cbd54ea
2021-05-12 16:59:17 -05:00
luigi1111
342f8c8b97
Merge pull request #7690
...
3cc4428
2021-05-12 16:58:34 -05:00
luigi1111
c1a1f2a6ea
Merge pull request #7688
...
451b5a5
2021-05-12 16:57:32 -05:00
mj-xmr
b40129e253
Warnings: unused var in core_tests:chaingen.h
2021-05-11 10:22:06 +02:00
selsta
3cc4428d45
clang: fix -Wpessimizing-move warning
2021-04-28 11:33:37 +02:00
selsta
cbd54ea524
cmake: set 3.5 as minimum version
2021-04-27 11:02:05 +02:00
mj-xmr
6799e212cc
Tests: Mining test uses a parametric path for finding the calculation app
...
MINING_SILENT and MINING_NO_MEASUREMENT env vars
2021-04-27 06:21:02 +02:00
selsta
451b5a510e
clang: fix -Wrange-loop-analysis warnings
2021-04-27 05:30:27 +02:00
luigi1111
0a1ddc2eff
Merge pull request #7669
...
679d055
2021-04-22 01:51:01 -04:00
mj-xmr
dc81e23e60
Split epee/string_tools.h and encapsulate boost::lexical_cast
2021-04-16 20:54:20 +02:00
luigi1111
e45619e61e
Revert "Merge pull request #7136 "
...
This reverts commit 63c7ca07fb2218e23e84
2021-04-16 13:52:44 -05:00
luigi1111
d544fd0f52
Merge pull request #7653
...
73d3b00
2021-04-16 12:52:42 -05:00
luigi1111
63c7ca07fb
Merge pull request #7136
...
23aae55
2021-04-16 12:45:30 -05:00
anon
73d3b00b35
unit_tests: fix boost 1.58 compatibility
2021-04-08 11:45:27 +00:00
luigi1111
4834bd8aa0
Merge pull request #7646
...
176cea0
2021-04-06 12:25:00 -05:00
luigi1111
1475236810
Merge pull request #7639
...
53683d7
2021-04-06 12:24:29 -05:00
luigi1111
3c69596bc9
Merge pull request #7321
...
f9b5b52
2021-04-06 12:20:15 -05:00
mj-xmr
176cea0ec6
Tests: Fix test node_server.bind_same_p2p_port from randomly crashing
2021-04-05 17:36:13 +02:00
mj-xmr
45f01f577c
[CI] Adaptive mining timeout, depending on available CPU power
...
Printing also available RAM. Add comprehensive description.
2021-03-30 05:48:55 +02:00
luigi1111
b12e195fba
Merge pull request #7620
...
fe63256ded2f3a
2021-03-29 21:55:11 -04:00
luigi1111
a2b046dafc
Merge pull request #7460
...
2935a0cc877705
2021-03-29 21:46:29 -04:00
mj-xmr
53683d7f90
Warnings: fix ut/levin.cpp missing braces
2021-03-27 09:26:44 +01:00
anon
ded2f3aa85
cryptonote_protocol_handler: add race condition demo
2021-03-22 19:42:46 +00:00
mj-xmr
c836dc11c9
[CI] Use Python3 for funcional tests, instead of Python2
2021-03-20 10:30:57 +01:00
luigi1111
1707cab1a4
Merge pull request #7401
...
b5209a0
2021-03-20 01:44:52 -04:00
luigi1111
7bf89dcbd3
Merge pull request #7005
...
249eae5
2021-03-20 01:35:13 -04:00
luigi1111
8d7c1135b8
Merge pull request #6810
...
19b2283
2021-03-20 01:33:10 -04:00
anon
c877705a53
async_protocol_handler_config: add deadlock demo
2021-03-12 11:59:06 +00:00
moneromooo-monero
f9b5b521e8
fix serialization being different on mac
...
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.
There's a nasty hack for backward compatibility, which can
go after a couple forks.
2021-03-05 23:42:33 +00:00
moneromooo-monero
b5209a09d2
functional_tests: hide check_missing_rpc_methods behind requests check
2021-02-23 20:10:03 +00:00
anon
1b51d398fb
async_protocol_handler_config: add segfault demo
2021-02-19 22:27:28 +00:00
luigi1111
1614be4a41
Merge pull request #7371
...
1aecdcf
2021-02-18 14:11:55 -05:00
luigi1111
6556c33f13
Merge pull request #7355
...
bd129841572df9
2021-02-18 14:06:47 -05:00
luigi1111
906a62c6b2
Merge pull request #7352
...
a60d3d8
2021-02-18 14:05:58 -05:00
luigi1111
ce5800a225
Merge pull request #7346
...
85db173
2021-02-18 14:03:31 -05:00
luigi1111
9f6dcbd568
Merge pull request #7308
...
df2f00f3833624
2021-02-15 21:53:43 -05:00
mj-xmr
1aecdcf536
Increase timeout for the mining test 4 times (to 240s)
2021-02-11 13:42:43 +01:00
moneromooo-monero
19b228393f
New add_aux_pow RPC to support merge mining
2021-02-09 11:58:21 +00:00
Kevin Barbour
85db1734e7
Remove unused variables in monero codebase
...
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
2021-02-09 08:05:05 +01:00
mj-xmr
dc48de74e8
Reduce compilation time of epee/portable_storage.h
2021-02-06 08:18:42 +01:00
Lee Clagett
bd129849f0
Remove copies from foreach loops (thanks to Clang)
2021-01-28 23:42:40 -05:00
xiphon
a60d3d8ff7
unit_tests: fix wipeable_string parse_hexstr test with latest gtest
...
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973196
2021-01-27 13:04:08 +00:00
Lee Clagett
08e4497c6e
Improve cryptonote (block and tx) binary read performance
2021-01-23 06:23:39 +00:00
