j-berman
84c52571ed
Decrease the "recent spend window" in gamma re-select to 15 blocks
...
- combined with patching integer truncation (#7798 ), this gets the algorithm marginally closer to mirroring empirically observed output ages
- 50 was originally chosen assuming integer truncation would remain in the client for that client release version. But patching integer truncation causes the client to select more outputs in the 10-100 block range, and therefore the benefit of choosing a larger recent spend window of 50 has less merit
- 15 seems well-suited to cover the somewhat sizable observable gap in the early window of blocks
2021-10-04 20:12:42 -07:00
luigi1111
298c9a357f
Merge pull request #7891
...
dfee15e
RPC and ZeroMQ APIs to support p2pool (SChernykh)
2021-09-23 22:10:03 -05:00
luigi1111
237acd120e
Merge pull request #7890
...
2a8a511
Quicker resource cleanup on p2p socks timeout (Lee *!* Clagett)
2021-09-23 22:06:35 -05:00
Howard Chu
5f54dea4ec
LMDB: fix deadlock in resized detection
2021-09-22 15:47:04 +01:00
Nathan Dorfman
2e8936f614
rpc: Fix get_transactions failing when not found
2021-09-20 17:32:01 -06:00
anon
9154883f3e
node_server: fix race condition
2021-09-20 20:58:23 +00:00
selsta
3a90be4bd6
rpc: don't set error code as status string
2021-09-15 08:57:41 +02:00
j-berman
76542ea709
Fix precision of average_output_time
...
The fix as suggested by <jberman> on IRC. Before the fix, it would truncate 1.9 to 1 skewing the output selection.
2021-09-12 10:07:31 +02:00
SChernykh
dfee15eee1
RPC and ZeroMQ APIs to support p2pool
...
Adds the following:
- "get_miner_data" to RPC API
- "json-miner-data" to ZeroMQ subscriber contexts
Both provide the necessary data to create a custom block template. They are used by p2pool.
Data provided:
- major fork version
- current height
- previous block id
- RandomX seed hash
- network difficulty
- median block weight
- coins mined by the network so far
- mineable mempool transactions
2021-09-11 15:15:07 +02:00
luigi1111
a39b1d56c8
Merge pull request #7899
...
cd76eb7
wallet: fix unused lambda capture warning (selsta)
2021-09-09 15:21:10 -04:00
luigi1111
9273530bff
Merge pull request #7898
...
f353c29
wallet_rpc_server: fix help text remaining bold (selsta)
2021-09-09 15:20:43 -04:00
luigi1111
e72eedd1ce
Merge pull request #7883
...
d749e0d
ringct: silence unused variable warning (selsta)
2021-09-09 15:18:42 -04:00
luigi1111
be94a2fb06
Merge pull request #7875
...
15936bf
Device: remove unused and incorrect non-default constructor (mj-xmr)
2021-09-09 15:17:41 -04:00
luigi1111
dfa6b58d4d
Merge pull request #7823
...
24d3d65
monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir (Kermit Alexander II)
2021-09-09 15:14:17 -04:00
luigi1111
2a02cd0a5f
Merge pull request #7773 from selsta/unbound
...
external: remove unbound submodule
2021-09-09 15:13:06 -04:00
luigi1111
7848a467c5
Merge pull request #7616
...
4ced092
daemon: allow proxy configuration (anon, selsta, tobtoht)
2021-09-09 15:09:51 -04:00
luigi1111
b7315efc1c
Merge pull request #7342
...
520ce1c
Attempt to carve the fee from a partial payment early (lxop)
2021-09-09 15:06:46 -04:00
mj-xmr
ad9fde46a3
UB: virtual methods in destructor at Trezor
2021-09-08 14:44:35 +02:00
mj-xmr
514f8fab14
LMDB: protection against UB, by not calling virtual methods from destructor
2021-09-08 14:08:40 +02:00
mj-xmr
eed7e79c04
UB: Not calling virtual method in destructor of WalletImpl
2021-09-07 14:24:53 +02:00
selsta
ae85ec0285
external: remove unbound submodule
2021-09-03 07:47:35 +02:00
selsta
cd76eb7b8c
wallet: fix unused lambda capture warning
2021-08-28 15:18:32 +02:00
selsta
f353c295f9
wallet_rpc_server: fix help text remaining bold
2021-08-27 02:59:36 +02:00
SChernykh
e52802baef
Wallet2: fix optimize-coinbase for p2pool payouts
...
RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet.
When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now.
With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction.
Fix it by applying this optimization only to pre-RingCT transactions (version < 2).
2021-08-26 11:50:15 +02:00
luigi1111
0061da9e63
Merge pull request #7878
...
a9aaa47
wallet_api: add make_uri (tobtoht)
2021-08-20 16:50:24 -04:00
luigi1111
8b9eea92f1
Merge pull request #7849
...
6f15a0c
Make sure node returns to wallet that real output is unlocked (j-berman)
2021-08-20 16:49:59 -04:00
luigi1111
1b079e5195
Merge pull request #7845
...
e1af8dc
Protect client from divide by 0 caused by integer truncation (j-berman)
2021-08-20 16:45:15 -04:00
luigi1111
5812b757e0
Merge pull request #7821
...
da2955f
Apply gamma distr from chain tip when selecting decoys (j-berman)
2021-08-20 16:33:53 -04:00
anon
4ced092aae
daemon: allow proxy configuration
...
Co-authored-by: selsta <selsta@sent.at>
Co-authored-by: tobtoht <thotbot@protonmail.com>
2021-08-20 21:24:29 +02:00
Kermit Alexander II
24d3d65d42
monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir
2021-08-20 08:54:41 -05:00
j-berman
e1af8dc02c
Protect client from divide by 0 caused by integer truncation
2021-08-19 14:56:36 -07:00
j-berman
da2955feae
Apply gamma distr from chain tip when selecting decoys
...
- matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time
- if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor
2021-08-19 14:51:20 -07:00
selsta
d749e0d97c
ringct: silence unused variable warning
2021-08-19 22:00:44 +02:00
mj-xmr
15936bfa0f
Device: remove unused and incorrect non-default constructor
2021-08-19 21:56:12 +02:00
tobtoht
a9aaa47abb
wallet_api: add make_uri
2021-08-19 15:35:37 +02:00
luigi1111
89664fcee5
Merge pull request #7811
...
3d3a671
Daemon: Update average block size table (rbrunner7)
2021-08-11 22:37:56 -04:00
luigi1111
521b4d9ded
Merge pull request #7809
...
7354ffb
p2p: remove blocked addresses/hosts from peerlist (moneromooo-monero)
2021-08-11 22:35:15 -04:00
luigi1111
cb08466394
Merge pull request #7802
...
a3d2b71
wallet_api: expose offline mode status (rating89us)
2021-08-11 22:33:38 -04:00
luigi1111
5cebb8edc0
Merge pull request #7800
...
b48074f
Fixed json serialization of rct::RCTTypeNull (SChernykh)
2021-08-11 22:32:39 -04:00
luigi1111
1bb8ec1b97
Merge pull request #7795
...
87a0928
rpc: source file extensions must be explicit (cmake warning) (selsta)
2021-08-11 22:31:34 -04:00
luigi1111
62844a776d
Merge pull request #7786
...
9c6e094
fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)
2021-08-11 22:30:11 -04:00
j-berman
6f15a0c8d3
Make sure node returns to wallet that real output is unlocked
2021-08-11 07:28:10 -07:00
moneromooo-monero
7354ffb8a7
p2p: remove blocked addresses/hosts from peerlist
2021-08-05 17:29:25 +00:00
Dusan Klinec
13a8a576ed
trezor: try empty passphrase first
...
- Try empty passphrase first when opening a wallet, as all Trezors will have passphrase enabled by default by Trezor Suite by default.
This feature enables easier access to all users using disabled passphrase (or empty passhprase)
- If wallet address differs from device address with empty passphrase, another opening attempt is made, without passphrase suppression,
so user can enter his passhprase if using some. In this scenario, nothing changes to user, wallet opening just consumes one more call
to Trezor (get wallet address with empty passphrase)
- also change how m_passphrase is used. Previous version did not work well with recent passphrase entry mechanism change (made in Trezor),
thus this commit fixes the behaviour).
2021-08-03 13:54:04 +02:00
luigi1111
ed506006d2
Merge pull request #7796
...
0c6e1d3
wallet2: chunk get_outs.bin calls to avoid sanity limits (moneromooo-monero)
2021-08-02 18:54:46 -04:00
luigi1111
eeda76570c
Merge pull request #7790
...
bc8d764
wallet: rephrase error message on invalid device address (Dusan Klinec)
2021-08-02 18:53:05 -04:00
luigi1111
8c41d14ad5
Merge pull request #7788
...
f5eb2ce
wallet2: Don't auto lock device on process parsed blocks (tobtoht)
2021-08-02 18:50:25 -04:00
luigi1111
894e5b2794
Merge pull request #7767
...
5fa1c90
Fix describe_transfer for multiple txes in a txset (Alex Opie)
2021-08-02 18:47:05 -04:00
luigi1111
0cdb8d02e8
Merge pull request #7757
...
d689b94
protocol: fix delayed 'you are now synchronized...' message (moneromooo-monero)
2021-08-02 18:43:44 -04:00
luigi1111
9aa2d4c16e
Merge pull request #7747
...
8cf95c8
wallet2: refresh: check error and throw before potentially breaking out of loop (tobtoht)
2021-08-02 18:42:32 -04:00
Alex Opie
5fa1c90102
Fix describe_transfer for multiple txes in a txset
...
This ensures each list of recipients is only the recipients
for one transaction. It also adds a new field "summary"
that describes the txset as a whole.
Fixes #7344
2021-08-02 20:39:49 +02:00
Lee *!* Clagett
2a8a51129f
Quicker resource cleanup on p2p socks timeout
2021-07-29 08:54:13 +00:00
selsta
979d121ed7
blocks: fix cmake syntax
2021-07-28 00:39:48 +02:00
luigi1111
960376b960
Merge pull request #7782
...
a48db50
device_trezor_base: fix typo (anon)
2021-07-27 17:04:14 -04:00
luigi1111
d9c9a11c54
Merge pull request #7772
...
eda5c30
Doc: Update blockchain stats with review comments (mj-xmr)
2021-07-27 17:01:42 -04:00
luigi1111
69e714c749
Merge pull request #7745
...
d52d21b
ledger: don't lock for software device (tobtoht)
2021-07-27 16:56:37 -04:00
luigi1111
62bcdc1d3c
Merge pull request #7744
...
ce40c33
ledger: use software device if we have view key (tobtoht)
2021-07-27 16:56:09 -04:00
luigi1111
2d5b8a6ff7
Merge pull request #7740
...
8cea9d8
wallet: Reset RPC Pay ID on node switch (tobtoht)
2021-07-27 16:55:14 -04:00
luigi1111
ca4de5f96d
Merge pull request #7698
...
7359d51
cmake: fix non portable code (selsta)
2021-07-27 16:53:55 -04:00
rbrunner7
3d3a67142c
Daemon: Update average block size table
2021-07-27 13:45:55 +02:00
rating89us
a3d2b71ee9
wallet_api: expose offline mode status
2021-07-19 00:30:36 +02:00
SChernykh
b48074fb8d
Fixed json serialization of rct::RCTTypeNull
...
rct::RCTTypeNull doesn't have these fields (ecdhInfo, outPk, txnFee).
2021-07-18 10:52:14 +02:00
moneromooo-monero
0c6e1d343e
wallet2: chunk get_outs.bin calls to avoid sanity limits
2021-07-15 17:25:07 +00:00
selsta
87a092811d
rpc: source file extensions must be explicit (cmake warning)
2021-07-15 09:42:57 +02:00
tobtoht
f5eb2ce968
wallet2: Don't auto lock device on process parsed blocks
2021-07-14 13:02:54 +02:00
Dusan Klinec
bc8d7644d2
wallet: rephrase error message on invalid device address
2021-07-14 11:02:29 +02:00
Dusan Klinec
9c6e0941cb
fix #7784 - deinit wallet in wallet dtor
2021-07-14 10:46:16 +02:00
anon
fe76d7dee7
cmake: fix undefined symbols and multiple definitions
2021-07-13 08:00:20 +02:00
anon
a48db50b1c
device_trezor_base: fix typo
2021-07-10 23:52:15 +00:00
luigi1111
de3456e127
Merge pull request #7764
...
e24875e
simplewallet: don't truncate integ. address in export_transfers (selsta)
2021-07-10 18:01:35 -04:00
luigi1111
1e8cbc995f
Merge pull request #7762
...
8ae6c85
trezor: add #if for ByteSizeLong (selsta)
2021-07-10 18:00:45 -04:00
luigi1111
3c8c8e5a5b
Merge pull request #7761
...
8ef51dc
wallet_api: fix typo in exportKeyImages (selsta)
2021-07-10 17:59:56 -04:00
luigi1111
9903b35345
Merge pull request #7754
...
8ff21e1
doc: update IRC references to Libera (fdov)
2021-07-10 17:59:23 -04:00
luigi1111
6043c85afe
Merge pull request #7753
...
f0df726
add singapore.node.xmr.pm to seed nodes (lza_menace)
2021-07-10 17:58:22 -04:00
luigi1111
c53e22c40a
Merge pull request #7748
...
bbeb555
wallet_api: getPassword (tobtoht)
2021-07-10 17:57:39 -04:00
mj-xmr
eda5c303cd
Doc: Update blockchain stats with review comments
2021-07-06 07:12:33 +02:00
tobtoht
bbeb555f00
wallet_api: getPassword
2021-07-05 02:49:27 +02:00
selsta
8ae6c85efd
trezor: add #if for ByteSizeLong
...
Turns out Ubuntu 18.04 ships with an old protobuf version.
2021-06-27 23:43:36 +02:00
tobtoht
8a67724218
wallet_api: get bytes sent/received
2021-06-24 21:32:03 +02:00
selsta
e24875e572
simplewallet: don't truncate integ. address in export_transfers
2021-06-24 21:21:26 +02:00
luigi1111
14a1b89122
Merge pull request #7752
...
4251cc0
unit_tests: check for ge_frombytes_vartime failure (moneromooo-monero)
67b97a5
easylogging++: do not delete uninitialized objects (moneromooo-monero)
7b6d959
trezor: fix potential use of uninitialized memory (moneromooo-monero)
2021-06-24 14:13:19 -05:00
luigi1111
4f08d52dfa
Merge pull request #7750
...
8e0b8dd
wallet/api: remove Bitmonero namespace alias (selsta)
2021-06-24 14:12:37 -05:00
luigi1111
0a9d218044
Merge pull request #7749
...
e63c110
wallet_api: address_book: don't lose pid on setDescription (tobtoht)
2021-06-24 14:11:45 -05:00
luigi1111
99aa45fd34
Merge pull request #7746
...
1aa1850
wallet_api: signMessage: add sign with subaddress (tobtoht)
2021-06-24 14:06:13 -05:00
luigi1111
7c3629a5ee
Merge pull request #7742
...
f174a8f
wallet_api: reconnectDevice (tobtoht)
2021-06-24 14:05:35 -05:00
luigi1111
ce129599d0
Merge pull request #7739
...
6914d5b
wallet_api: move adjust_mixin call within try block (tobtoht)
2021-06-24 14:04:42 -05:00
luigi1111
48e59b8064
Merge pull request #7672
...
5bf91fc
add documentation for monero-blockchain-stats (donkeydonkey)
2021-06-24 14:03:03 -05:00
luigi1111
ad9956d987
Merge pull request #7634
...
5a2edea
db_lmdb: catch exceptions testing for mmap support (moneromooo-monero)
2021-06-24 14:01:42 -05:00
luigi1111
f8abb225fc
Merge pull request #7633
...
f6e2636
blockchain_db: harden code against invalid input types (moneromooo-monero)
2021-06-24 14:00:59 -05:00
luigi1111
3366bd81eb
Merge pull request #7612
...
254a133
core: speed up print_coinbase_tx_sum (moneromooo-monero)
2021-06-24 13:59:44 -05:00
luigi1111
1796b44c67
Merge pull request #7611
...
71741a1
blockchain_import: fix wrong reported block/tx hashes on error (moneromooo-monero)
2021-06-24 13:59:12 -05:00
selsta
8ef51dc546
wallet_api: fix typo in exportKeyImages
2021-06-23 20:44:13 +02:00
moneromooo-monero
d689b946f9
protocol: fix delayed "you are now synchronized..." message
2021-06-21 15:37:40 +00:00
fdov
8ff21e1e84
doc: update IRC references to Libera
2021-06-20 21:44:45 +02:00
lza_menace
f0df72688f
add singapore.node.xmr.pm to seed nodes
2021-06-18 11:14:03 -07:00
luigi1111
b63442da21
Merge pull request #7730
...
e761577
provide key images of spent outputs in wallet rpc (woodser)
2021-06-16 14:38:06 -05:00
woodser
e7615772fa
provide key images of spent outputs in wallet rpc
2021-06-15 15:54:39 -04:00
mj-xmr
41297c10f0
CMake: strip targets (optional) with -D STRIP_TARGETS=ON
2021-06-11 21:19:37 +02:00
moneromooo-monero
7b6d959596
trezor: fix potential use of uninitialized memory
...
CID 1446575
2021-06-11 07:11:23 +00:00
luigi1111
7499837a6f
Merge pull request #7661
...
08e4497
Improve cryptonote (block and tx) binary read performance (Lee Clagett)
2021-06-10 12:00:54 -05:00