Merge pull request #4041

df9d50a8 wallet2: fix read buffer overflow in import_key_images (moneromooo-monero)
This commit is contained in:
Riccardo Spagni 2018-07-03 15:20:42 +02:00
commit f449dbe8eb
No known key found for this signature in database
GPG Key ID: 55432DF31CCD4FCD

View File

@ -9827,7 +9827,7 @@ uint64_t wallet2::import_key_images(const std::vector<std::pair<crypto::key_imag
std::unordered_set<crypto::hash> spent_txids; // For each spent key image, search for a tx in m_transfers that uses it as input. std::unordered_set<crypto::hash> spent_txids; // For each spent key image, search for a tx in m_transfers that uses it as input.
std::vector<size_t> swept_transfers; // If such a spending tx wasn't found in m_transfers, this means the spending tx std::vector<size_t> swept_transfers; // If such a spending tx wasn't found in m_transfers, this means the spending tx
// was created by sweep_all, so we can't know the spent height and other detailed info. // was created by sweep_all, so we can't know the spent height and other detailed info.
for(size_t i = 0; i < m_transfers.size(); ++i) for(size_t i = 0; i < signed_key_images.size(); ++i)
{ {
transfer_details &td = m_transfers[i]; transfer_details &td = m_transfers[i];
uint64_t amount = td.amount(); uint64_t amount = td.amount();