src: fix clangd warnings

contrib/epee/include/net/abstract_tcp_server2.inl

@@ -30,6 +30,7 @@
 // SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 // 
 
+#pragma once
 
 #include <boost/asio/post.hpp>
 #include <boost/foreach.hpp>
@@ -45,6 +46,7 @@
 #include "warnings.h"
 #include "string_tools_lexical.h"
 #include "misc_language.h"
+#include "net/abstract_tcp_server2.h"
 
 #include <sstream>
 #include <iomanip>

src/blockchain_db/locked_txn.h

@@ -30,6 +30,8 @@
 
 #pragma once
 
+#include "blockchain_db.h"
+
 namespace cryptonote
 {
     // This class is meant to create a batch when none currently exists.

src/blockchain_db/testdb.h

@@ -34,6 +34,8 @@
 #include <vector>
 #include <map>
 
+#include <cryptonote_basic/cryptonote_format_utils.h>
+
 #include "blockchain_db.h"
 
 namespace cryptonote

src/common/aligned.h

@@ -30,8 +30,16 @@
 #pragma once 
 
 #ifdef __cplusplus
+
+#include <cstddef>
+
 extern "C" {
-#endif
+
+#else // C compiler
+
+#include <stddef.h>
+
+#endif // __cplusplus
 
 void *aligned_malloc(size_t bytes, size_t align);
 void *aligned_realloc(void *ptr, size_t bytes, size_t align);

src/common/download.h

@@ -29,6 +29,8 @@
 #pragma once 
 
 #include <string>
+#include <memory>
+#include <functional>
 
 namespace tools
 {

src/common/i18n.h

@@ -28,6 +28,8 @@
 
 #pragma once
 
+#include <string>
+
 #define QT_TRANSLATE_NOOP(context,str) i18n_translate(str,context)
 
 std::string i18n_get_language();

src/common/sfinae_helpers.h

@@ -28,6 +28,8 @@
 
 #pragma once
 
+#include <string>
+
 // the loose definitions of types in this file are, well, loose.
 //
 // these helpers aren't here for absolute type certainty at compile-time,

src/common/spawn.h

@@ -29,6 +29,9 @@
 
 #pragma once 
 
+#include <string>
+#include <vector>
+
 namespace tools
 {
 

src/crypto/CryptonightR_JIT.h

@@ -1,6 +1,9 @@
 #ifndef CRYPTONIGHTR_JIT_H
 #define CRYPTONIGHTR_JIT_H
 
+#include <stdint.h>
+#include <stddef.h>
+
 // Minimalistic JIT code generator for random math sequence in CryptonightR
 //
 // Usage:

src/crypto/hash-extra-groestl.c

@@ -34,5 +34,5 @@
 #include "groestl.h"
 
 void hash_extra_groestl(const void *data, size_t length, char *hash) {
-  groestl(data, length * 8, (uint8_t*)hash);
+  groestl((const BitSequence *)data, length * 8, (uint8_t*)hash);
 }

src/crypto/hash-extra-jh.c

@@ -40,5 +40,5 @@
 
 void hash_extra_jh(const void *data, size_t length, char *hash) {
   // No need to check for failure b/c jh_hash only fails for invalid hash size
-  jh_hash(JH_HASH_BITLEN, data, 8 * length, (uint8_t*)hash);
+  jh_hash(JH_HASH_BITLEN, (const BitSequence *)data, 8 * length, (uint8_t*)hash);
 }

src/crypto/hash-extra-skein.c

@@ -38,5 +38,5 @@
 
 void hash_extra_skein(const void *data, size_t length, char *hash) {
   // No need to check for failure b/c skein_hash only fails for invalid hash size
-  skein_hash(SKEIN_HASH_BITLEN, data, 8 * length, (uint8_t*)hash);
+  skein_hash(SKEIN_HASH_BITLEN, (const BitSequence *)data, 8 * length, (uint8_t*)hash);
 }

src/crypto/hash-ops.h

@@ -30,7 +30,12 @@
 
 #pragma once
 
-#if !defined(__cplusplus)
+#if defined(__cplusplus)
+
+#include <cstddef>
+#include <cstdint>
+
+#else
 
 #include <assert.h>
 #include <stdbool.h>

src/crypto/variant2_int_sqrt.h

@@ -3,6 +3,7 @@
 
 #include <math.h>
 #include <float.h>
+#include <stdint.h>
 
 #define VARIANT2_INTEGER_MATH_SQRT_STEP_SSE2() \
   do { \

src/crypto/variant4_random_math.h

@@ -1,6 +1,13 @@
 #ifndef VARIANT4_RANDOM_MATH_H
 #define VARIANT4_RANDOM_MATH_H
 
+#include <stdint.h>
+#include <stddef.h>
+#include <memory.h>
+
+#include "int-util.h"
+#include "hash-ops.h"
+
 // Register size can be configured to either 32 bit (uint32_t) or 64 bit (uint64_t)
 typedef uint32_t v4_reg;
 

src/crypto/wallet/crypto.h

@@ -31,6 +31,7 @@
 
 #include <cstddef>
 #include "crypto/wallet/ops.h"
+#include "crypto/crypto.h"
 
 namespace crypto {
   namespace wallet {

src/cryptonote_basic/miner.h

@@ -37,6 +37,8 @@
 #include "verification_context.h"
 #include "difficulty.h"
 #include "math_helper.h"
+#include "syncobj.h"
+#include "cryptonote_basic/blobdatatype.h"
 #ifdef _WIN32
 #include <windows.h>
 #endif

src/cryptonote_basic/subaddress_index.h

@@ -28,6 +28,7 @@
 
 #pragma once
 
+#include "serialization/serialization.h"
 #include "serialization/keyvalue_serialization.h"
 #include <boost/serialization/serialization.hpp>
 #include <boost/serialization/version.hpp>

src/cryptonote_basic/tx_extra.h

@@ -30,6 +30,15 @@
 
 #pragma once
 
+#include <cstdint>
+#include <cstddef>
+
+#include <boost/variant/variant.hpp>
+
+#include "serialization/serialization.h"
+#include "serialization/binary_archive.h"
+#include "serialization/variant.h"
+#include "crypto/crypto.h"
 
 #define TX_EXTRA_PADDING_MAX_COUNT          255
 #define TX_EXTRA_NONCE_MAX_COUNT            255

src/cryptonote_core/tx_verification_utils.h

@@ -28,6 +28,7 @@
 
 #pragma once
 
+#include "cryptonote_basic/blobdatatype.h"
 #include "common/data_cache.h"
 #include "cryptonote_basic/cryptonote_basic.h"
 #include "cryptonote_basic/verification_context.h"

src/cryptonote_protocol/block_queue.h

@@ -37,6 +37,7 @@
 #include <boost/thread/recursive_mutex.hpp>
 #include <boost/uuid/uuid.hpp>
 #include "net/net_utils_base.h"
+#include "crypto/crypto.h"
 
 #undef MONERO_DEFAULT_LOG_CATEGORY
 #define MONERO_DEFAULT_LOG_CATEGORY "cn.block_queue"

src/cryptonote_protocol/cryptonote_protocol_handler.inl

@@ -36,9 +36,13 @@
 // developer rfree: this code is caller of our new network code, and is modded; e.g. for rate limiting
 
 #include <boost/optional/optional.hpp>
+#include <boost/uuid/uuid.hpp>
+#include <boost/uuid/uuid_generators.hpp>
 #include <list>
 #include <ctime>
 
+#include <cryptonote_core/cryptonote_core.h>
+#include "cryptonote_protocol/cryptonote_protocol_handler.h"
 #include "cryptonote_basic/cryptonote_format_utils.h"
 #include "profile_tools.h"
 #include "net/network_throttle-detail.hpp"

src/daemon/command_line_args.h

@@ -32,6 +32,7 @@
 #include "common/command_line.h"
 #include "cryptonote_config.h"
 #include "daemonizer/daemonizer.h"
+#include "cryptonote_core/cryptonote_core.h"
 
 namespace daemon_args
 {

src/daemon/protocol.h

@@ -30,6 +30,10 @@
 
 #pragma once
 
+#include "cryptonote_protocol/cryptonote_protocol_handler.h"
+#include "daemon/core.h"
+#include "p2p/net_node.h"
+
 #undef MONERO_DEFAULT_LOG_CATEGORY
 #define MONERO_DEFAULT_LOG_CATEGORY "daemon"
 

src/daemon/rpc.h

@@ -31,6 +31,9 @@
 #pragma once
 
 #include "rpc/core_rpc_server.h"
+#include "daemon/command_line_args.h"
+#include "cryptonote_protocol/cryptonote_protocol_handler.h"
+#include "p2p.h"
 
 #undef MONERO_DEFAULT_LOG_CATEGORY
 #define MONERO_DEFAULT_LOG_CATEGORY "daemon"

src/daemonizer/daemonizer.h

@@ -32,6 +32,8 @@
 #include <boost/program_options/options_description.hpp>
 #include <boost/program_options/variables_map.hpp>
 
+#include "common/command_line.h"
+
 namespace daemonizer
 {
   void init_options(

src/daemonizer/posix_daemonizer.inl

@@ -28,8 +28,10 @@
 
 #pragma once
 
+#include "daemonizer/daemonizer.h"
 #include "common/scoped_message_writer.h"
 #include "common/util.h"
+#include "common/command_line.h"
 #include "daemonizer/posix_fork.h"
 
 #include <boost/filesystem/operations.hpp>

src/lmdb/util.h

@@ -31,6 +31,7 @@
 #include <cstring>
 #include <lmdb.h>
 #include <type_traits>
+#include <cassert>
 #include <utility>
 
 #include "span.h"

src/p2p/net_node.inl

@@ -57,6 +57,7 @@
 #include "storages/levin_abstract_invoke2.h"
 #include "cryptonote_core/cryptonote_core.h"
 #include "net/parse.h"
+#include "p2p/net_node.h"
 
 #include <miniupnp/miniupnpc/miniupnpc.h>
 #include <miniupnp/miniupnpc/upnpcommands.h>

src/p2p/net_node_common.h

@@ -33,6 +33,7 @@
 #include <boost/uuid/uuid.hpp>
 #include <utility>
 #include <vector>
+#include "net/levin_base.h"
 #include "cryptonote_basic/blobdatatype.h"
 #include "cryptonote_protocol/enums.h"
 #include "cryptonote_protocol/fwd.h"

src/p2p/net_peerlist_boost_serialization.h

@@ -31,6 +31,7 @@
 #pragma once
 
 #include <cstring>
+#include <boost/serialization/split_free.hpp>
 
 #include "common/expect.h"
 #include "net/net_utils_base.h"

src/rpc/core_rpc_server_error_codes.h

@@ -30,6 +30,8 @@
 
 #pragma  once 
 
+#include "misc_log_ex.h"
+#include <cstddef>
 
 #define CORE_RPC_ERROR_CODE_WRONG_PARAM           -1
 #define CORE_RPC_ERROR_CODE_TOO_BIG_HEIGHT        -2

src/rpc/daemon_rpc_version.h

@@ -28,6 +28,8 @@
 
 #pragma once
 
+#include <cstdint>
+
 namespace cryptonote
 {
 

src/serialization/binary_utils.h

@@ -31,6 +31,7 @@
 #pragma once
 
 #include <sstream>
+#include "serialization/serialization.h"
 #include "binary_archive.h"
 
 namespace serialization {

src/serialization/container.h

@@ -28,6 +28,13 @@
 // 
 // Parts of this file are originally copyright (c) 2012-2013 The Cryptonote developers
 
+#pragma once
+
+#include <cstdint>
+#include <cstddef>
+#include <string>
+#include <type_traits>
+
 namespace serialization
 {
   namespace detail

src/serialization/tuple.h

@@ -31,6 +31,7 @@
 #pragma once
 #include <tuple>
 #include "serialization.h"
+#include <cstdint>
 
 namespace serialization
 {