Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-08-06 05:04:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

logging: Fix easylogging++ init with blank config

Browse source 
The upstream version of el::base::TypedConfigurations::unsafeGetConfigByRef
accesses uninitialized memory if a key doesn't exist.
Commit b2c59af84d patched the library to
throw in this case, avoiding the invalid access, but the more suitable
pattern, both logically, and as evidenced by the behavior of
unsafeGetConfigByVal, would be to return a const reference to a
default-initialized value with static storage duration.
This commit is contained in:
iamamyth 2025-02-19 11:20:53 -08:00
parent 915c5dc1d9
commit 8c43e33e35
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/unit_tests/logging.cpp
View file

@ -209,9 +209,10 @@ TEST(logging, operator_equals_segfault)
log2 = log1;
}
TEST(logging, empty_configurations_throws)
TEST(logging, empty_configuration)
{
el::Logger log1("id1", nullptr);
const el::Configurations cfg;
EXPECT_ANY_THROW(log1.configure(cfg));
EXPECT_NO_THROW(log1.configure(cfg));
EXPECT_EQ(log1.typedConfigurations()->filename(el::Level::Info), "");
}