Merge pull request #4877

c25260f5 protocol: fix incorrect tx hash in log (moneromooo-monero)
This commit is contained in:
Riccardo Spagni 2018-12-04 17:16:52 +02:00
commit 868630c1db
No known key found for this signature in database
GPG Key ID: 55432DF31CCD4FCD

View File

@ -1077,8 +1077,10 @@ skip:
if(tvc[i].m_verifivation_failed) if(tvc[i].m_verifivation_failed)
{ {
if (!m_p2p->for_connection(span_connection_id, [&](cryptonote_connection_context& context, nodetool::peerid_type peer_id, uint32_t f)->bool{ if (!m_p2p->for_connection(span_connection_id, [&](cryptonote_connection_context& context, nodetool::peerid_type peer_id, uint32_t f)->bool{
cryptonote::transaction tx;
parse_and_validate_tx_from_blob(*it, tx); // must succeed if we got here
LOG_ERROR_CCONTEXT("transaction verification failed on NOTIFY_RESPONSE_GET_OBJECTS, tx_id = " LOG_ERROR_CCONTEXT("transaction verification failed on NOTIFY_RESPONSE_GET_OBJECTS, tx_id = "
<< epee::string_tools::pod_to_hex(get_blob_hash(*it)) << ", dropping connection"); << epee::string_tools::pod_to_hex(cryptonote::get_transaction_hash(tx)) << ", dropping connection");
drop_connection(context, false, true); drop_connection(context, false, true);
return 1; return 1;
})) }))