Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-10-01 11:49:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

daemon: catch out of range exceptions too when calling stoll/stoi

Browse Source 
And any other exception, just to be safe
This commit is contained in:
moneromooo-monero 2017-10-03 15:48:18 +01:00
parent a2041c9874
commit 7e7acdc32b
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/daemon/command_parser_executor.cpp
View File

@ -343,7 +343,7 @@ bool t_command_parser_executor::set_limit(const std::vector<std::string>& args)
try { try {
limit = std::stoll(args[0]); limit = std::stoll(args[0]);
} }
catch(const std::invalid_argument& ex) { catch(const std::exception& ex) {
std::cout << "failed to parse argument" << std::endl; std::cout << "failed to parse argument" << std::endl;
return false; return false;
} }
@ -363,7 +363,7 @@ bool t_command_parser_executor::set_limit_up(const std::vector<std::string>& arg
try { try {
limit = std::stoll(args[0]); limit = std::stoll(args[0]);
} }
catch(const std::invalid_argument& ex) { catch(const std::exception& ex) {
std::cout << "failed to parse argument" << std::endl; std::cout << "failed to parse argument" << std::endl;
return false; return false;
} }
@ -383,7 +383,7 @@ bool t_command_parser_executor::set_limit_down(const std::vector<std::string>& a
try { try {
limit = std::stoll(args[0]); limit = std::stoll(args[0]);
} }
catch(const std::invalid_argument& ex) { catch(const std::exception& ex) {
std::cout << "failed to parse argument" << std::endl; std::cout << "failed to parse argument" << std::endl;
return false; return false;
} }
@ -402,7 +402,7 @@ bool t_command_parser_executor::out_peers(const std::vector<std::string>& args)
limit = std::stoi(args[0]); limit = std::stoi(args[0]);
} }
catch(std::invalid_argument& ex) { catch(std::exception& ex) {
_erro("stoi exception"); _erro("stoi exception");
return false; return false;
} }
@ -432,7 +432,7 @@ bool t_command_parser_executor::hard_fork_info(const std::vector<std::string>& a
try { try {
version = std::stoi(args[0]); version = std::stoi(args[0]);
} }
catch(std::invalid_argument& ex) { catch(std::exception& ex) {
return false; return false;
} }
if (version <= 0 || version > 255) if (version <= 0 || version > 255)
@ -456,8 +456,15 @@ bool t_command_parser_executor::ban(const std::vector<std::string>& args)
std::string ip = args[0]; std::string ip = args[0];
time_t seconds = P2P_IP_BLOCKTIME; time_t seconds = P2P_IP_BLOCKTIME;
if (args.size() > 1) if (args.size() > 1)
{
try
{ {
seconds = std::stoi(args[1]); seconds = std::stoi(args[1]);
}
catch (const std::exception &e)
{
return false;
}
if (seconds == 0) if (seconds == 0)
{ {
return false; return false;