Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-08-06 08:24:21 -04:00
Code Issues Projects Releases Packages Wiki Activity

core: faster find_blockchain_supplement

Browse source 
Since this queries block heights for blocks that may or may not
exist, queries for non existing blocks would throw an exception,
and that would slow down the loop a lot. 7 seconds to go through
a 30 hash list.

Fix this by adding an optional return block height to block_exists
and using this instead. Actual errors will still throw an
exception.

This also cuts down on log exception spam.
This commit is contained in:
moneromooo-monero 2016-08-30 16:39:33 +01:00
parent c3ba844f03
commit 6cf8ca2a7f
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
7 changed files with 19 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/unit_tests/hardfork.cpp
View file

@ -58,7 +58,7 @@ public:
virtual void block_txn_stop() {}
virtual void block_txn_abort() {}
virtual void drop_hard_fork_info() {}
virtual bool block_exists(const crypto::hash& h) const { return false; }
virtual bool block_exists(const crypto::hash& h, uint64_t *height) const { return false; }
virtual block get_block(const crypto::hash& h) const { return block(); }
virtual uint64_t get_block_height(const crypto::hash& h) const { return 0; }
virtual block_header get_block_header(const crypto::hash& h) const { return block_header(); }