Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-27 00:49:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

get_block_template_backlog: better sorting logic

Browse Source 
std::sort is unstable, so it can return random sets of transactions when mempool has many transactions with the same fee/byte. It can result in p2pool mining empty blocks sometimes because it doesn't pick up "new" transactions immediately.
This commit is contained in:
SChernykh 2024-03-08 14:50:01 +01:00
parent 4b255808d0
commit 66e5081eae
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cryptonote_core/tx_pool.cpp
View File

@ -1073,7 +1073,7 @@ namespace cryptonote
// If the total weight is too high, choose the best paying transactions // If the total weight is too high, choose the best paying transactions
if (total_weight > max_backlog_weight) if (total_weight > max_backlog_weight)
std::sort(tmp.begin(), tmp.end(), [](const auto& a, const auto& b){ return a.fee * b.weight > b.fee * a.weight; }); std::stable_sort(tmp.begin(), tmp.end(), [](const auto& a, const auto& b){ return a.fee * b.weight > b.fee * a.weight; });
backlog.clear(); backlog.clear();
uint64_t w = 0; uint64_t w = 0;