small touchups

This commit is contained in:
j-berman 2024-09-16 18:55:39 -07:00
parent 21664f99b2
commit 513dae88dc
3 changed files with 5 additions and 6 deletions

View File

@ -737,11 +737,11 @@ static PreLeafTuple output_to_pre_leaf_tuple(const OutputPair &output_pair)
PreLeafTuple plt; PreLeafTuple plt;
if (!fcmp_pp::point_to_pre_wei_x(O, plt.O_pre_x)) if (!fcmp_pp::point_to_pre_wei_x(O, plt.O_pre_x))
throw std::runtime_error("failed to get pre wei x scalar from O"); throw std::runtime_error("failed to get pre wei x from O");
if (!fcmp_pp::point_to_pre_wei_x(rct::pt2rct(I), plt.I_pre_x)) if (!fcmp_pp::point_to_pre_wei_x(rct::pt2rct(I), plt.I_pre_x))
throw std::runtime_error("failed to get pre wei x scalar from I"); throw std::runtime_error("failed to get pre wei x from I");
if (!fcmp_pp::point_to_pre_wei_x(C, plt.C_pre_x)) if (!fcmp_pp::point_to_pre_wei_x(C, plt.C_pre_x))
throw std::runtime_error("failed to get pre wei x scalar from C"); throw std::runtime_error("failed to get pre wei x from C");
return plt; return plt;
} }

View File

@ -56,7 +56,6 @@ bool point_to_pre_wei_x(const rct::key &pub, PreWeiX &pre_wei_x) {
return false; return false;
fe one; fe one;
fe_1(one); fe_1(one);
// (1+y),(1-y) // (1+y),(1-y)
fe_add(pre_wei_x.one_plus_y, one, y); fe_add(pre_wei_x.one_plus_y, one, y);
fe_sub(pre_wei_x.one_minus_y, one, y); fe_sub(pre_wei_x.one_minus_y, one, y);

View File

@ -391,7 +391,7 @@ TEST(Crypto, batch_inversion)
ASSERT_EQ(fe_frombytes_vartime(init_elems[i], (unsigned char*)kp.pub.data), 0); ASSERT_EQ(fe_frombytes_vartime(init_elems[i], (unsigned char*)kp.pub.data), 0);
} }
for (std::size_t n_elems : {1, 100, 1000}) for (const std::size_t n_elems : test_n_elems)
{ {
// Memory allocations // Memory allocations
fe *batch_inverted = alloc(n_elems); fe *batch_inverted = alloc(n_elems);