Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-08-08 05:32:27 -04:00
Code Issues Projects Releases Packages Wiki Activity

core: remove out sorting from v7 rules

Browse source 
and restore random shuffle of outputs

This turned out to have a flaw (sort order depends on output
index), and this doesn't really bring much anyway
This commit is contained in:
moneromooo-monero 2017-09-26 17:31:15 +01:00
parent 5f7cddeb53
commit 4e115a3a4c
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
2 changed files with 4 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/cryptonote_core/blockchain.cpp
View file

@ -2383,26 +2383,6 @@ bool Blockchain::check_tx_outputs(const transaction& tx, tx_verification_context
}
}
// from v7, sorted outs
if (m_hardfork->get_current_version() >= 7) {
const crypto::public_key *last_key = NULL;
for (size_t n = 0; n < tx.vout.size(); ++n)
{
const tx_out &o = tx.vout[n];
if (o.target.type() == typeid(txout_to_key))
{
const txout_to_key& out_to_key = boost::get<txout_to_key>(o.target);
if (last_key && memcmp(&out_to_key.key, last_key, sizeof(*last_key)) >= 0)
{
MERROR_VER("transaction has unsorted outputs");
tvc.m_invalid_output = true;
return false;
}
last_key = &out_to_key.key;
}
}
}
return true;
}
//------------------------------------------------------------------