Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-14 15:24:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

rpc: Fix get_transactions failing when not found

Browse Source
This commit is contained in:
Nathan Dorfman 2021-09-20 14:15:59 -06:00
parent 665bd8933a
commit 209c031b93
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/rpc/core_rpc_server.cpp
View File

@ -939,14 +939,26 @@ namespace cryptonote
LOG_PRINT_L2("Found " << found_in_pool << "/" << vh.size() << " transactions in the pool"); LOG_PRINT_L2("Found " << found_in_pool << "/" << vh.size() << " transactions in the pool");
} }
std::vector<std::string>::const_iterator txhi = req.txs_hashes.begin(); CHECK_AND_ASSERT_MES(txs.size() + missed_txs.size() == vh.size(), false, "mismatched number of txs");
std::vector<crypto::hash>::const_iterator vhi = vh.begin();
auto txhi = req.txs_hashes.cbegin();
auto vhi = vh.cbegin();
auto missedi = missed_txs.cbegin();
for(auto& tx: txs) for(auto& tx: txs)
{ {
res.txs.push_back(COMMAND_RPC_GET_TRANSACTIONS::entry()); res.txs.push_back(COMMAND_RPC_GET_TRANSACTIONS::entry());
COMMAND_RPC_GET_TRANSACTIONS::entry &e = res.txs.back(); COMMAND_RPC_GET_TRANSACTIONS::entry &e = res.txs.back();
while (missedi != missed_txs.end() && *missedi == *vhi)
{
++vhi;
++txhi;
++missedi;
}
crypto::hash tx_hash = *vhi++; crypto::hash tx_hash = *vhi++;
CHECK_AND_ASSERT_MES(tx_hash == std::get<0>(tx), false, "mismatched tx hash");
e.tx_hash = *txhi++; e.tx_hash = *txhi++;
e.prunable_hash = epee::string_tools::pod_to_hex(std::get<2>(tx)); e.prunable_hash = epee::string_tools::pod_to_hex(std::get<2>(tx));
if (req.split || req.prune || std::get<3>(tx).empty()) if (req.split || req.prune || std::get<3>(tx).empty())