Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-10-01 11:49:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

wallet2: Missing underflow check on low heights

Browse Source 
Lack of it results in `m_refresh_from_block_height` being < 0 (18446744...) on low heights, which blocks `process_new_blockchain_entry` and never process coins on heights less than blocks_per_month.
Follow-up to #2258
This commit is contained in:
landergate 2017-09-27 14:17:48 +03:00 committed by GitHub
parent 5f7cddeb53
commit 180a848cbe
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wallet/wallet2.cpp
View File

@ -2209,7 +2209,7 @@ crypto::secret_key wallet2::generate(const std::string& wallet_, const std::stri
// Set blockchain height calculated from current date/time // Set blockchain height calculated from current date/time
uint64_t approx_blockchain_height = get_approximate_blockchain_height(); uint64_t approx_blockchain_height = get_approximate_blockchain_height();
if(approx_blockchain_height > 0) { if(approx_blockchain_height > 0) {
m_refresh_from_block_height = approx_blockchain_height - blocks_per_month; m_refresh_from_block_height = approx_blockchain_height >= blocks_per_month ? approx_blockchain_height - blocks_per_month : 0;
} }
} }
bool r = store_keys(m_keys_file, password, false); bool r = store_keys(m_keys_file, password, false);