Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-26 15:09:29 -05:00
Code Issues Packages Projects Releases Wiki Activity

crypto: do not use boost::value_initialized to init null skey/pkey

Browse Source
This commit is contained in:
moneromooo-monero 2018-07-20 22:59:18 +01:00
parent 63e342be84
commit 0496c7c91a
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/crypto/crypto.cpp
View File

@ -70,8 +70,8 @@ namespace crypto {
#include "random.h"
}
const crypto::public_key null_pkey = boost::value_initialized<crypto::public_key>();
const crypto::secret_key null_skey = boost::value_initialized<crypto::secret_key>();
const crypto::public_key null_pkey = crypto::public_key{};
const crypto::secret_key null_skey = crypto::secret_key{};
static inline unsigned char *operator &(ec_point &point) {
return &reinterpret_cast<unsigned char &>(point);

1
src/crypto/crypto.h
View File

@ -34,7 +34,6 @@
#include <iostream>
#include <boost/thread/mutex.hpp>
#include <boost/thread/lock_guard.hpp>
#include <boost/utility/value_init.hpp>
#include <boost/optional.hpp>
#include <type_traits>
#include <vector>

8
tests/unit_tests/crypto.cpp
View File

@ -73,3 +73,11 @@ TEST(Crypto, Ostream)
EXPECT_TRUE(is_formatted<crypto::key_derivation>());
EXPECT_TRUE(is_formatted<crypto::key_image>());
}
TEST(Crypto, null_keys)
{
char zero[32];
memset(zero, 0, 32);
ASSERT_EQ(memcmp(crypto::null_skey.data, zero, 32), 0);
ASSERT_EQ(memcmp(crypto::null_pkey.data, zero, 32), 0);
}