Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-28 21:56:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

blockchain: allow marking "tx not found" without an exception

Browse Source 
This is a normal occurence in many cases, and there is no need
to spam the log with those when it is.
This commit is contained in:
moneromooo-monero 2016-12-23 16:38:28 +00:00
parent 049b7e9a93
commit 0478ac6848
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
5 changed files with 33 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/blockchain_db/blockchain_db.h
View File

@ -1019,6 +1019,20 @@ public:
*/
virtual transaction get_tx(const crypto::hash& h) const = 0;
/**
* @brief fetches the transaction with the given hash
*
* The subclass should return the transaction stored which has the given
* hash.
*
* If the transaction does not exist, the subclass should return false.
*
* @param h the hash to look for
*
* @return true iff the transaction was found
*/
virtual bool get_tx(const crypto::hash& h, transaction &tx) const = 0;
/**
* @brief fetches the total number of transactions ever
*

14
src/blockchain_db/lmdb/db_lmdb.cpp
View File

@ -1791,7 +1791,7 @@ uint64_t BlockchainLMDB::get_tx_unlock_time(const crypto::hash& h) const
return ret;
}
transaction BlockchainLMDB::get_tx(const crypto::hash& h) const
bool BlockchainLMDB::get_tx(const crypto::hash& h, transaction &tx) const
{
LOG_PRINT_L3("BlockchainLMDB::" << __func__);
check_open();
@ -1810,19 +1810,27 @@ transaction BlockchainLMDB::get_tx(const crypto::hash& h) const
get_result = mdb_cursor_get(m_cur_txs, &val_tx_id, &result, MDB_SET);
}
if (get_result == MDB_NOTFOUND)
throw1(TX_DNE(std::string("tx with hash ").append(epee::string_tools::pod_to_hex(h)).append(" not found in db").c_str()));
return false;
else if (get_result)
throw0(DB_ERROR(lmdb_error("DB error attempting to fetch tx from hash", get_result).c_str()));
blobdata bd;
bd.assign(reinterpret_cast<char*>(result.mv_data), result.mv_size);
transaction tx;
if (!parse_and_validate_tx_from_blob(bd, tx))
throw0(DB_ERROR("Failed to parse tx from blob retrieved from the db"));
TXN_POSTFIX_RDONLY();
return true;
}
transaction BlockchainLMDB::get_tx(const crypto::hash& h) const
{
transaction tx;
if (!get_tx(h, tx))
throw1(TX_DNE(std::string("tx with hash ").append(epee::string_tools::pod_to_hex(h)).append(" not found in db").c_str()));
return tx;
}

2
src/blockchain_db/lmdb/db_lmdb.h
View File

@ -209,6 +209,8 @@ public:
virtual transaction get_tx(const crypto::hash& h) const;
virtual bool get_tx(const crypto::hash& h, transaction &tx) const;
virtual uint64_t get_tx_count() const;
virtual std::vector<transaction> get_tx_list(const std::vector<crypto::hash>& hlist) const;

10
src/cryptonote_core/blockchain.cpp
View File

@ -1894,11 +1894,11 @@ bool Blockchain::get_transactions(const t_ids_container& txs_ids, t_tx_container
{
try
{
txs.push_back(m_db->get_tx(tx_hash));
}
catch (const TX_DNE& e)
{
missed_txs.push_back(tx_hash);
transaction tx;
if (m_db->get_tx(tx_hash, tx))
txs.push_back(std::move(tx));
else
missed_txs.push_back(tx_hash);
}
catch (const std::exception& e)
{

1
tests/unit_tests/hardfork.cpp
View File

@ -78,6 +78,7 @@ public:
virtual bool tx_exists(const crypto::hash& h, uint64_t& tx_index) const { return false; }
virtual uint64_t get_tx_unlock_time(const crypto::hash& h) const { return 0; }
virtual transaction get_tx(const crypto::hash& h) const { return transaction(); }
virtual bool get_tx(const crypto::hash& h, transaction &tx) const { return false; }
virtual uint64_t get_tx_count() const { return 0; }
virtual std::vector<transaction> get_tx_list(const std::vector<crypto::hash>& hlist) const { return std::vector<transaction>(); }
virtual uint64_t get_tx_block_height(const crypto::hash& h) const { return 0; }