Fix various oversights/bugs in ZMQ RPC server code

- Add some RPC commands (and touch up a couple others)
- some bounds checking
- some better pointer management
- const correctness and error handling

-- Thanks @vtnerd for type help with serialization and CMake changes
This commit is contained in:
Thomas Winget 2017-09-05 12:20:40 -04:00
parent 77986023c3
commit 0299cb77ca
No known key found for this signature in database
GPG key ID: 58131A160789E630
15 changed files with 536 additions and 225 deletions

View file

@ -83,12 +83,6 @@ namespace daemon_args
, std::to_string(config::testnet::ZMQ_RPC_DEFAULT_PORT)
};
const command_line::arg_descriptor<bool> arg_zmq_restricted_rpc = {
"zmq-restricted-rpc"
, "Restrict ZMQ RPC to view only commands"
, false
};
} // namespace daemon_args
#endif // DAEMON_COMMAND_LINE_ARGS_H

View file

@ -92,7 +92,6 @@ int main(int argc, char const * argv[])
command_line::add_arg(core_settings, daemon_args::arg_zmq_rpc_bind_ip);
command_line::add_arg(core_settings, daemon_args::arg_zmq_rpc_bind_port);
command_line::add_arg(core_settings, daemon_args::arg_zmq_testnet_rpc_bind_port);
command_line::add_arg(core_settings, daemon_args::arg_zmq_restricted_rpc);
daemonizer::init_options(hidden_options, visible_options);
daemonize::t_executor::init_options(core_settings);