Git-Mirrors/mev-toolkit
1
0
Fork 0
mirror of https://github.com/autistic-symposium/mev-toolkit.git synced 2025-04-28 11:46:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Create security.md

Browse Source
This commit is contained in:
bt3gl 2022-03-10 18:55:54 +00:00 committed by GitHub
parent 578ef2e769
commit 1a2bdcca46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
solidity/security.md Normal file
View File

@ -0,0 +1,15 @@
## Basic security
* `tx.origin` is used: you want to replace it by “msg.sender” because otherwise any contract you call can act on your behalf.
* potential reetrancy bugs:
```
msg.sender.transfer(amount);
balances[msg.sender] -= amount;
```
* inline assembly used: should be used only in rare cases
* unclear semantics: `now` is alias for `block.timestamp` not current time; use of low level `call`, `callcode`, `delegatecall` should be avoided whenever possible; use `transfer` whenever failure of ether transfer should rollnack the whole transaction.
* Beware of caller contracts: `selfdestruct` can block calling contracts unexpectedly.
* Invocation of local functions via `this`: never use `this` to call functions in the same contract, it only consumes more gas than normal call.
* Transferring Ether in a for/while/do-while loop should be avoid due to the block gas limit.
* ERC20 `decimals` should have `uint8` as return type.