mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2024-09-20 16:15:44 +00:00
d612cad09a
The Database, DatabaseWidget, and DatabaseTabWidget classes share many responsibilities in inconsistent ways resulting in impenetrable and unmaintainable code and a diverse set of bugs and architecture restrictions. This patch reworks the architecture, responsibilities of, and dependencies between these classes. The core changes are: * Move loading and saving logic from widgets into the Database class * Get rid of the DatabaseManagerStruct and move all the information contained in it into the Database * Let database objects keep track of modifications and dirty/clean state instead of handing this to external widgets * Move GUI interactions for loading and saving from the DatabaseTabWidget into the DatabaseWidget (resolves #2494 as a side-effect) * Heavily clean up DatabaseTabWidget and degrade it to a slightly glorified QTabWidget * Use QSharedPointers for all Database objects * Remove the modifiedImmediate signal and replace it with a markAsModified() method * Implement proper tabName() method instead of reading back titles from GUI widgets (resolves #1389 and its duplicates #2146 #855) * Fix unwanted AES-KDF downgrade if database uses Argon2 and has CustomData * Improve code This patch is also the first major step towards solving issues #476 and #2322.
100 lines
2.9 KiB
C++
100 lines
2.9 KiB
C++
/*
|
|
* Copyright (C) 2011 Felix Geyer <debfx@fobos.de>
|
|
* Copyright (C) 2017 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSX_TESTGUI_H
|
|
#define KEEPASSX_TESTGUI_H
|
|
|
|
#include "gui/MainWindow.h"
|
|
#include "util/TemporaryFile.h"
|
|
|
|
#include <QAbstractItemModel>
|
|
#include <QObject>
|
|
#include <QPointer>
|
|
#include <QScopedPointer>
|
|
#include <QSharedPointer>
|
|
|
|
class Database;
|
|
class DatabaseTabWidget;
|
|
class DatabaseWidget;
|
|
class QAbstractItemView;
|
|
|
|
class TestGui : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
protected slots:
|
|
void createDatabaseCallback();
|
|
|
|
private slots:
|
|
void initTestCase();
|
|
void init();
|
|
void cleanup();
|
|
void cleanupTestCase();
|
|
|
|
void testSettingsDefaultTabOrder();
|
|
void testCreateDatabase();
|
|
void testMergeDatabase();
|
|
void testAutoreloadDatabase();
|
|
void testTabs();
|
|
void testEditEntry();
|
|
void testSearchEditEntry();
|
|
void testAddEntry();
|
|
void testPasswordEntryEntropy();
|
|
void testDicewareEntryEntropy();
|
|
void testTotp();
|
|
void testSearch();
|
|
void testDeleteEntry();
|
|
void testCloneEntry();
|
|
void testEntryPlaceholders();
|
|
void testDragAndDropEntry();
|
|
void testDragAndDropGroup();
|
|
void testSaveAs();
|
|
void testSave();
|
|
void testDatabaseSettings();
|
|
void testKeePass1Import();
|
|
void testDatabaseLocking();
|
|
void testDragAndDropKdbxFiles();
|
|
void testTrayRestoreHide();
|
|
|
|
private:
|
|
int addCannedEntries();
|
|
void checkDatabase(QString dbFileName = "");
|
|
void triggerAction(const QString& name);
|
|
void dragAndDropGroup(const QModelIndex& sourceIndex,
|
|
const QModelIndex& targetIndex,
|
|
int row,
|
|
bool expectedResult,
|
|
const QString& expectedParentName,
|
|
int expectedPos);
|
|
void clickIndex(const QModelIndex& index,
|
|
QAbstractItemView* view,
|
|
Qt::MouseButton button,
|
|
Qt::KeyboardModifiers stateKey = 0);
|
|
|
|
QScopedPointer<MainWindow> m_mainWindow;
|
|
QPointer<DatabaseTabWidget> m_tabWidget;
|
|
QPointer<DatabaseWidget> m_dbWidget;
|
|
QSharedPointer<Database> m_db;
|
|
QByteArray m_dbData;
|
|
QScopedPointer<TemporaryFile> m_dbFile;
|
|
QString m_dbFileName;
|
|
QString m_dbFilePath;
|
|
};
|
|
|
|
#endif // KEEPASSX_TESTGUI_H
|