mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2024-12-25 23:39:45 -05:00
e443cde452
This patch implements a new database wizard to guide users through the process of setting up a new database and choosing sane encryption settings. It also reimplements the master key settings to be more user-friendly. Users can now add, change, or remove individual composite key components instead of having to set all components at once. This avoids confusion about a password being reset if the user only wants to add a key file. With these changes comes a major refactor of how database composite keys and key components are handled. Copying of keys is prohibited and each key exists only once in memory and is referenced via shared pointers. GUI components for changing individual keys are encapsulated into separate classes to be more reusable. The password edit and generator widgets have also been refactored to be more reusable.
291 lines
9.8 KiB
C++
291 lines
9.8 KiB
C++
/*
|
|
* Copyright (C) 2010 Felix Geyer <debfx@fobos.de>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "TestKeePass1Reader.h"
|
|
#include "TestGlobal.h"
|
|
|
|
#include <QBuffer>
|
|
|
|
#include "config-keepassx-tests.h"
|
|
#include "core/Metadata.h"
|
|
#include "crypto/Crypto.h"
|
|
#include "format/KeePass1Reader.h"
|
|
#include "format/KeePass2Reader.h"
|
|
#include "format/KeePass2Writer.h"
|
|
#include "keys/FileKey.h"
|
|
#include "keys/PasswordKey.h"
|
|
|
|
QTEST_GUILESS_MAIN(TestKeePass1Reader)
|
|
|
|
void TestKeePass1Reader::initTestCase()
|
|
{
|
|
QVERIFY(Crypto::init());
|
|
|
|
QString filename = QString(KEEPASSX_TEST_DATA_DIR).append("/basic.kdb");
|
|
|
|
KeePass1Reader reader;
|
|
m_db = reader.readDatabase(filename, "masterpw", 0);
|
|
QVERIFY(m_db);
|
|
QVERIFY(!reader.hasError());
|
|
}
|
|
|
|
void TestKeePass1Reader::testBasic()
|
|
{
|
|
QVERIFY(m_db->deletedObjects().isEmpty());
|
|
|
|
QCOMPARE(m_db->rootGroup()->children().size(), 2);
|
|
|
|
Group* group1 = m_db->rootGroup()->children().at(0);
|
|
QVERIFY(!group1->uuid().isNull());
|
|
QCOMPARE(group1->name(), QString("Internet"));
|
|
QCOMPARE(group1->children().size(), 2);
|
|
QCOMPARE(group1->entries().size(), 2);
|
|
QCOMPARE(group1->iconNumber(), 1);
|
|
|
|
Entry* entry11 = group1->entries().at(0);
|
|
QVERIFY(!entry11->uuid().isNull());
|
|
QCOMPARE(entry11->title(), QString("Test entry"));
|
|
QCOMPARE(entry11->iconNumber(), 1);
|
|
QCOMPARE(entry11->username(), QString("I"));
|
|
QCOMPARE(entry11->url(), QString("http://example.com/"));
|
|
QCOMPARE(entry11->password(), QString("secretpassword"));
|
|
QCOMPARE(entry11->notes(), QString("Lorem ipsum\ndolor sit amet"));
|
|
QVERIFY(entry11->timeInfo().expires());
|
|
QCOMPARE(entry11->timeInfo().expiryTime(), genDT(2012, 5, 9, 10, 32));
|
|
QCOMPARE(entry11->attachments()->keys().size(), 1);
|
|
QCOMPARE(entry11->attachments()->keys().at(0), QString("attachment.txt"));
|
|
QCOMPARE(entry11->attachments()->value("attachment.txt"), QByteArray("hello world\n"));
|
|
|
|
Entry* entry12 = group1->entries().at(1);
|
|
QCOMPARE(entry12->title(), QString(""));
|
|
QCOMPARE(entry12->iconNumber(), 0);
|
|
QCOMPARE(entry12->username(), QString(""));
|
|
QCOMPARE(entry12->url(), QString(""));
|
|
QCOMPARE(entry12->password(), QString(""));
|
|
QCOMPARE(entry12->notes(), QString(""));
|
|
QVERIFY(!entry12->timeInfo().expires());
|
|
QCOMPARE(entry12->attachments()->keys().size(), 0);
|
|
|
|
Group* group11 = group1->children().at(0);
|
|
QCOMPARE(group11->name(), QString("Subgroup 1"));
|
|
QCOMPARE(group11->children().size(), 1);
|
|
|
|
Group* group111 = group11->children().at(0);
|
|
QCOMPARE(group111->name(), QString("Unexpanded"));
|
|
QCOMPARE(group111->children().size(), 1);
|
|
|
|
Group* group1111 = group111->children().at(0);
|
|
QCOMPARE(group1111->name(), QString("abc"));
|
|
QCOMPARE(group1111->children().size(), 0);
|
|
|
|
Group* group12 = group1->children().at(1);
|
|
QCOMPARE(group12->name(), QString("Subgroup 2"));
|
|
QCOMPARE(group12->children().size(), 0);
|
|
|
|
Group* group2 = m_db->rootGroup()->children().at(1);
|
|
QCOMPARE(group2->name(), QString("eMail"));
|
|
QCOMPARE(group2->entries().size(), 1);
|
|
QCOMPARE(group2->iconNumber(), 19);
|
|
|
|
reopenDatabase(m_db, "masterpw", QString());
|
|
}
|
|
|
|
void TestKeePass1Reader::testMasterKey()
|
|
{
|
|
QVERIFY(m_db->hasKey());
|
|
QCOMPARE(m_db->kdf()->rounds(), 713);
|
|
}
|
|
|
|
void TestKeePass1Reader::testCustomIcons()
|
|
{
|
|
QCOMPARE(m_db->metadata()->customIcons().size(), 1);
|
|
|
|
Entry* entry = m_db->rootGroup()->children().at(1)->entries().at(0);
|
|
|
|
QCOMPARE(entry->icon().width(), 16);
|
|
QCOMPARE(entry->icon().height(), 16);
|
|
|
|
for (int x = 0; x < 16; x++) {
|
|
for (int y = 0; y < 16; y++) {
|
|
QRgb rgb = entry->icon().pixel(x, y);
|
|
QCOMPARE(qRed(rgb), 8);
|
|
QCOMPARE(qGreen(rgb), 160);
|
|
QCOMPARE(qBlue(rgb), 60);
|
|
}
|
|
}
|
|
}
|
|
|
|
void TestKeePass1Reader::testGroupExpanded()
|
|
{
|
|
QCOMPARE(m_db->rootGroup()->children().at(0)->isExpanded(), true);
|
|
QCOMPARE(m_db->rootGroup()->children().at(0)->children().at(0)->isExpanded(), true);
|
|
QCOMPARE(m_db->rootGroup()->children().at(0)->children().at(0)->children().at(0)->isExpanded(), false);
|
|
}
|
|
|
|
void TestKeePass1Reader::testAutoType()
|
|
{
|
|
Group* group = m_db->rootGroup()->children().at(0)->children().at(0);
|
|
QCOMPARE(group->entries().size(), 2);
|
|
|
|
Entry* entry1 = group->entries().at(0);
|
|
QCOMPARE(entry1->notes(), QString("last line"));
|
|
QCOMPARE(entry1->defaultAutoTypeSequence(), QString("{USERNAME}{ENTER}"));
|
|
QCOMPARE(entry1->autoTypeAssociations()->size(), 5);
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(0).sequence, QString(""));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(0).window, QString("a window"));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(1).sequence, QString(""));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(1).window, QString("a second window"));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(2).sequence, QString("{PASSWORD}{ENTER}"));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(2).window, QString("Window Nr 1a"));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(3).sequence, QString("{PASSWORD}{ENTER}"));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(3).window, QString("Window Nr 1b"));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(4).sequence, QString(""));
|
|
QCOMPARE(entry1->autoTypeAssociations()->get(4).window, QString("Window 2"));
|
|
|
|
Entry* entry2 = group->entries().at(1);
|
|
QCOMPARE(entry2->notes(), QString("start line\nend line"));
|
|
QCOMPARE(entry2->defaultAutoTypeSequence(), QString(""));
|
|
QCOMPARE(entry2->autoTypeAssociations()->size(), 2);
|
|
QCOMPARE(entry2->autoTypeAssociations()->get(0).sequence, QString(""));
|
|
QCOMPARE(entry2->autoTypeAssociations()->get(0).window, QString("Main Window"));
|
|
QCOMPARE(entry2->autoTypeAssociations()->get(1).sequence, QString(""));
|
|
QCOMPARE(entry2->autoTypeAssociations()->get(1).window, QString("Test Window"));
|
|
}
|
|
|
|
void TestKeePass1Reader::testFileKey()
|
|
{
|
|
QFETCH(QString, type);
|
|
|
|
QString name = QString("FileKey").append(type);
|
|
|
|
KeePass1Reader reader;
|
|
|
|
QString dbFilename = QString("%1/%2.kdb").arg(QString(KEEPASSX_TEST_DATA_DIR), name);
|
|
QString keyFilename = QString("%1/%2.key").arg(QString(KEEPASSX_TEST_DATA_DIR), name);
|
|
|
|
Database* db = reader.readDatabase(dbFilename, QString(), keyFilename);
|
|
QVERIFY(db);
|
|
QVERIFY(!reader.hasError());
|
|
QCOMPARE(db->rootGroup()->children().size(), 1);
|
|
QCOMPARE(db->rootGroup()->children().at(0)->name(), name);
|
|
|
|
reopenDatabase(db, QString(), keyFilename);
|
|
|
|
delete db;
|
|
}
|
|
|
|
void TestKeePass1Reader::testFileKey_data()
|
|
{
|
|
QTest::addColumn<QString>("type");
|
|
QTest::newRow("Binary") << QString("Binary");
|
|
QTest::newRow("Hex") << QString("Hex");
|
|
QTest::newRow("Hashed") << QString("Hashed");
|
|
}
|
|
|
|
void TestKeePass1Reader::testCompositeKey()
|
|
{
|
|
QString name = "CompositeKey";
|
|
|
|
KeePass1Reader reader;
|
|
|
|
QString dbFilename = QString("%1/%2.kdb").arg(QString(KEEPASSX_TEST_DATA_DIR), name);
|
|
QString keyFilename = QString("%1/FileKeyHex.key").arg(QString(KEEPASSX_TEST_DATA_DIR));
|
|
|
|
Database* db = reader.readDatabase(dbFilename, "mypassword", keyFilename);
|
|
QVERIFY(db);
|
|
QVERIFY(!reader.hasError());
|
|
QCOMPARE(db->rootGroup()->children().size(), 1);
|
|
QCOMPARE(db->rootGroup()->children().at(0)->name(), name);
|
|
|
|
reopenDatabase(db, "mypassword", keyFilename);
|
|
|
|
delete db;
|
|
}
|
|
|
|
void TestKeePass1Reader::testTwofish()
|
|
{
|
|
QString name = "Twofish";
|
|
|
|
KeePass1Reader reader;
|
|
|
|
QString dbFilename = QString("%1/%2.kdb").arg(QString(KEEPASSX_TEST_DATA_DIR), name);
|
|
|
|
Database* db = reader.readDatabase(dbFilename, "masterpw", 0);
|
|
QVERIFY(db);
|
|
QVERIFY(!reader.hasError());
|
|
QCOMPARE(db->rootGroup()->children().size(), 1);
|
|
QCOMPARE(db->rootGroup()->children().at(0)->name(), name);
|
|
|
|
delete db;
|
|
}
|
|
|
|
void TestKeePass1Reader::testCP1252Password()
|
|
{
|
|
QString name = "CP-1252";
|
|
|
|
KeePass1Reader reader;
|
|
|
|
QString dbFilename = QString("%1/%2.kdb").arg(QString(KEEPASSX_TEST_DATA_DIR), name);
|
|
QString password = QString::fromUtf8("\xe2\x80\x9e\x70\x61\x73\x73\x77\x6f\x72\x64\xe2\x80\x9d");
|
|
|
|
Database* db = reader.readDatabase(dbFilename, password, 0);
|
|
QVERIFY(db);
|
|
QVERIFY(!reader.hasError());
|
|
QCOMPARE(db->rootGroup()->children().size(), 1);
|
|
QCOMPARE(db->rootGroup()->children().at(0)->name(), name);
|
|
|
|
delete db;
|
|
}
|
|
|
|
void TestKeePass1Reader::cleanupTestCase()
|
|
{
|
|
delete m_db;
|
|
}
|
|
|
|
QDateTime TestKeePass1Reader::genDT(int year, int month, int day, int hour, int min)
|
|
{
|
|
QDate date(year, month, day);
|
|
QTime time(hour, min, 0);
|
|
return QDateTime(date, time, Qt::UTC);
|
|
}
|
|
|
|
void TestKeePass1Reader::reopenDatabase(Database* db, const QString& password, const QString& keyfileName)
|
|
{
|
|
QBuffer buffer;
|
|
buffer.open(QIODevice::ReadWrite);
|
|
|
|
KeePass2Writer writer;
|
|
writer.writeDatabase(&buffer, db);
|
|
QVERIFY(!writer.hasError());
|
|
QVERIFY(buffer.seek(0));
|
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
if (!password.isNull()) {
|
|
key->addKey(QSharedPointer<PasswordKey>::create(password));
|
|
}
|
|
if (!keyfileName.isEmpty()) {
|
|
auto fileKey = QSharedPointer<FileKey>::create();
|
|
QVERIFY(fileKey->load(keyfileName));
|
|
key->addKey(fileKey);
|
|
}
|
|
|
|
KeePass2Reader reader;
|
|
QScopedPointer<Database> newDb(reader.readDatabase(&buffer, key));
|
|
QVERIFY(newDb);
|
|
QVERIFY(!reader.hasError());
|
|
}
|