mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-01-08 22:18:27 -05:00
d612cad09a
The Database, DatabaseWidget, and DatabaseTabWidget classes share many responsibilities in inconsistent ways resulting in impenetrable and unmaintainable code and a diverse set of bugs and architecture restrictions. This patch reworks the architecture, responsibilities of, and dependencies between these classes. The core changes are: * Move loading and saving logic from widgets into the Database class * Get rid of the DatabaseManagerStruct and move all the information contained in it into the Database * Let database objects keep track of modifications and dirty/clean state instead of handing this to external widgets * Move GUI interactions for loading and saving from the DatabaseTabWidget into the DatabaseWidget (resolves #2494 as a side-effect) * Heavily clean up DatabaseTabWidget and degrade it to a slightly glorified QTabWidget * Use QSharedPointers for all Database objects * Remove the modifiedImmediate signal and replace it with a markAsModified() method * Implement proper tabName() method instead of reading back titles from GUI widgets (resolves #1389 and its duplicates #2146 #855) * Fix unwanted AES-KDF downgrade if database uses Argon2 and has CustomData * Improve code This patch is also the first major step towards solving issues #476 and #2322.
100 lines
2.9 KiB
C++
100 lines
2.9 KiB
C++
/*
|
|
* Copyright (C) 2018 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSX_DATABASETABWIDGET_H
|
|
#define KEEPASSX_DATABASETABWIDGET_H
|
|
|
|
#include "gui/MessageWidget.h"
|
|
|
|
#include <QTabWidget>
|
|
#include <QPointer>
|
|
|
|
class Database;
|
|
class DatabaseWidget;
|
|
class DatabaseWidgetStateSync;
|
|
class DatabaseOpenWidget;
|
|
class QFile;
|
|
|
|
class DatabaseTabWidget : public QTabWidget
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit DatabaseTabWidget(QWidget* parent = nullptr);
|
|
~DatabaseTabWidget() override;
|
|
void mergeDatabase(const QString& filePath);
|
|
|
|
QString tabName(int index);
|
|
DatabaseWidget* currentDatabaseWidget();
|
|
DatabaseWidget* databaseWidgetFromIndex(int index) const;
|
|
|
|
bool isReadOnly(int index = -1) const;
|
|
bool canSave(int index = -1) const;
|
|
bool isModified(int index = -1) const;
|
|
bool hasLockableDatabases() const;
|
|
|
|
public slots:
|
|
void addDatabaseTab(const QString& filePath);
|
|
void addDatabaseTab(DatabaseWidget* dbWidget);
|
|
bool closeDatabaseTab(int index);
|
|
bool closeDatabaseTab(DatabaseWidget* dbWidget);
|
|
bool closeAllDatabaseTabs();
|
|
bool closeCurrentDatabaseTab();
|
|
bool closeDatabaseTabFromSender();
|
|
void updateTabName(int index = -1);
|
|
|
|
void newDatabase();
|
|
void openDatabase();
|
|
void mergeDatabase();
|
|
void importCsv();
|
|
void importKeePass1Database();
|
|
bool saveDatabase(int index = -1);
|
|
bool saveDatabaseAs(int index = -1);
|
|
void exportToCsv();
|
|
|
|
void lockDatabases();
|
|
void closeDatabaseFromSender();
|
|
void relockPendingDatabase();
|
|
|
|
void changeMasterKey();
|
|
void changeDatabaseSettings();
|
|
void performGlobalAutoType();
|
|
|
|
signals:
|
|
void databaseClosed(const QString& filePath);
|
|
void databaseUnlocked(DatabaseWidget* dbWidget);
|
|
void databaseLocked(DatabaseWidget* dbWidget);
|
|
void activateDatabaseChanged(DatabaseWidget* dbWidget);
|
|
void tabNameChanged();
|
|
void messageGlobal(const QString&, MessageWidget::MessageType type);
|
|
void messageDismissGlobal();
|
|
|
|
private slots:
|
|
void toggleTabbar();
|
|
void emitActivateDatabaseChanged();
|
|
void emitDatabaseLockChanged();
|
|
|
|
private:
|
|
QSharedPointer<Database> execNewDatabaseWizard();
|
|
void updateLastDatabases(const QString& filename);
|
|
|
|
QPointer<DatabaseWidgetStateSync> m_dbWidgetStateSync;
|
|
QPointer<DatabaseWidget> m_dbPendingLock;
|
|
};
|
|
|
|
#endif // KEEPASSX_DATABASETABWIDGET_H
|