mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2024-09-19 23:56:10 +00:00
d612cad09a
The Database, DatabaseWidget, and DatabaseTabWidget classes share many responsibilities in inconsistent ways resulting in impenetrable and unmaintainable code and a diverse set of bugs and architecture restrictions. This patch reworks the architecture, responsibilities of, and dependencies between these classes. The core changes are: * Move loading and saving logic from widgets into the Database class * Get rid of the DatabaseManagerStruct and move all the information contained in it into the Database * Let database objects keep track of modifications and dirty/clean state instead of handing this to external widgets * Move GUI interactions for loading and saving from the DatabaseTabWidget into the DatabaseWidget (resolves #2494 as a side-effect) * Heavily clean up DatabaseTabWidget and degrade it to a slightly glorified QTabWidget * Use QSharedPointers for all Database objects * Remove the modifiedImmediate signal and replace it with a markAsModified() method * Implement proper tabName() method instead of reading back titles from GUI widgets (resolves #1389 and its duplicates #2146 #855) * Fix unwanted AES-KDF downgrade if database uses Argon2 and has CustomData * Improve code This patch is also the first major step towards solving issues #476 and #2322.
95 lines
3.0 KiB
C++
95 lines
3.0 KiB
C++
/*
|
|
* Copyright (C) 2018 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSXC_TESTKEEPASS2FORMAT_H
|
|
#define KEEPASSXC_TESTKEEPASS2FORMAT_H
|
|
|
|
#include <QBuffer>
|
|
#include <QDateTime>
|
|
#include <QObject>
|
|
#include <QSharedPointer>
|
|
|
|
#include "core/Database.h"
|
|
|
|
/**
|
|
* Abstract base class for KeePass2 file format tests.
|
|
*/
|
|
class TestKeePass2Format : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void initTestCase();
|
|
|
|
/**
|
|
* XML Reader / writer tests.
|
|
*/
|
|
void testXmlMetadata();
|
|
void testXmlCustomIcons();
|
|
void testXmlGroupRoot();
|
|
void testXmlGroup1();
|
|
void testXmlGroup2();
|
|
void testXmlEntry1();
|
|
void testXmlEntry2();
|
|
void testXmlEntryHistory();
|
|
void testXmlDeletedObjects();
|
|
void testXmlBroken();
|
|
void testXmlBroken_data();
|
|
void testXmlEmptyUuids();
|
|
void testXmlInvalidXmlChars();
|
|
void testXmlRepairUuidHistoryItem();
|
|
|
|
/**
|
|
* KDBX binary format tests.
|
|
*/
|
|
void testReadBackTargetDb();
|
|
void testKdbxBasic();
|
|
void testKdbxProtectedAttributes();
|
|
void testKdbxAttachments();
|
|
void testKdbxNonAsciiPasswords();
|
|
void testKdbxDeviceFailure();
|
|
void testDuplicateAttachments();
|
|
|
|
protected:
|
|
virtual void initTestCaseImpl() = 0;
|
|
|
|
virtual QSharedPointer<Database> readXml(QBuffer* buf, bool strictMode, bool& hasError, QString& errorString) = 0;
|
|
virtual QSharedPointer<Database> readXml(const QString& path, bool strictMode, bool& hasError, QString& errorString) = 0;
|
|
virtual void writeXml(QBuffer* buf, Database* db, bool& hasError, QString& errorString) = 0;
|
|
|
|
virtual void readKdbx(QIODevice* device,
|
|
QSharedPointer<const CompositeKey> key,
|
|
QSharedPointer<Database> db,
|
|
bool& hasError,
|
|
QString& errorString) = 0;
|
|
virtual void readKdbx(const QString& path,
|
|
QSharedPointer<const CompositeKey> key,
|
|
QSharedPointer<Database> db,
|
|
bool& hasError,
|
|
QString& errorString) = 0;
|
|
virtual void writeKdbx(QIODevice* device, Database* db, bool& hasError, QString& errorString) = 0;
|
|
|
|
QSharedPointer<Database> m_xmlDb;
|
|
QSharedPointer<Database> m_kdbxSourceDb;
|
|
QSharedPointer<Database> m_kdbxTargetDb;
|
|
|
|
private:
|
|
QBuffer m_kdbxTargetBuffer;
|
|
};
|
|
|
|
#endif // KEEPASSXC_TESTKEEPASS2FORMAT_H
|