mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2024-09-19 23:56:10 +00:00
ab153a24ec
Instead of running macdeployqt once for each extra helper binary and plugin (plus the main run for the application itself), collect all the binaries that should be processed and run macdeloyqt only once after all the binaries have been installed. This also moves the main app macdeployqt call from a POST_BUILD step to an install(CODE) step, making increment rebuilds of the app faster. To ensure that macdeployqt is called after all the binaries are installed, a new post_install subdirectory is needed to circumvent CMake's limitation regarding the default order of installation. CMake first runs the current directory install() calls and then it's child subdirectory ones. Because we want macdeployqt to be the last install() call, it needs to be done inside a subdirectory that is added last. Note due to a bug in macdeployqt, the deployed app inside the .dmg file will fail to run on arm macs, due to broken code signature. See https://bugreports.qt.io/browse/QTBUG-101696 for details. For the final release, the release-tool should take care of proper resigning.
62 lines
1.9 KiB
CMake
62 lines
1.9 KiB
CMake
# Running macdeployqt on a POST_BUILD copied binaries is pointless when using CPack because
|
|
# the copied binaries will be overriden by the corresponding install(TARGETS) commands.
|
|
# That's why we run macdeployqt using install(CODE) on the already installed binaries.
|
|
# The precondition is that all install(TARGETS) calls have to be called before this function is
|
|
# called.
|
|
# macdeloyqt is called only once, but it is given all executables that should be processed.
|
|
function(kpxc_run_macdeployqt_at_install_time)
|
|
set(NO_VALUE_OPTIONS)
|
|
set(SINGLE_VALUE_OPTIONS
|
|
APP_NAME
|
|
)
|
|
set(MULTI_VALUE_OPTIONS
|
|
EXTRA_BINARIES
|
|
)
|
|
cmake_parse_arguments(PARSE_ARGV 0 ARG
|
|
"${NO_VALUE_OPTIONS}" "${SINGLE_VALUE_OPTIONS}" "${MULTI_VALUE_OPTIONS}"
|
|
)
|
|
|
|
set(ESCAPED_PREFIX "\${CMAKE_INSTALL_PREFIX}")
|
|
set(APP_BUNDLE_NAME "${ARG_APP_NAME}.app")
|
|
set(APP_BUNDLE_PATH "${ESCAPED_PREFIX}/${APP_BUNDLE_NAME}")
|
|
|
|
# Collect extra binaries and plugins that should be handled by macdpeloyqt.
|
|
set(EXTRA_BINARIES "")
|
|
foreach(EXTRA_BINARY ${ARG_EXTRA_BINARIES})
|
|
set(INSTALLED_BINARY_PATH "${ESCAPED_PREFIX}/${EXTRA_BINARY}")
|
|
list(APPEND EXTRA_BINARIES "-executable=${INSTALLED_BINARY_PATH}")
|
|
endforeach()
|
|
|
|
list(JOIN EXTRA_BINARIES " " EXTRA_BINARIES_STR)
|
|
|
|
if(CMAKE_VERSION VERSION_GREATER "3.14")
|
|
set(COMMAND_ECHO "COMMAND_ECHO STDOUT")
|
|
else()
|
|
set(COMMAND_ECHO "")
|
|
endif()
|
|
|
|
set(COMMAND_ARGS
|
|
${MACDEPLOYQT_EXE}
|
|
${APP_BUNDLE_PATH}
|
|
|
|
# Adjusts dependency rpaths of extra binaries
|
|
${EXTRA_BINARIES_STR}
|
|
|
|
# Silences warnings on subsequent re-installations
|
|
-always-overwrite
|
|
)
|
|
|
|
install(CODE
|
|
"
|
|
execute_process(
|
|
COMMAND ${COMMAND_ARGS}
|
|
${COMMAND_ECHO}
|
|
RESULT_VARIABLE EXIT_CODE
|
|
)
|
|
if(NOT EXIT_CODE EQUAL 0)
|
|
message(FATAL_ERROR
|
|
\"Running ${COMMAND_ARGS} failed with exit code \${EXIT_CODE}.\")
|
|
endif()
|
|
")
|
|
endfunction()
|