mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-03-30 18:08:16 -04:00
80809ace67
Selected the [Botan crypto library](https://github.com/randombit/botan) due to its feature list, maintainer support, availability across all deployment platforms, and ease of use. Also evaluated Crypto++ as a viable candidate, but the additional features of Botan (PKCS#11, TPM, etc) won out. The random number generator received a backend upgrade. Botan prefers hardware-based RNG's and will provide one if available. This is transparent to KeePassXC and a significant improvement over gcrypt. Replaced Argon2 library with built-in Botan implementation that supports i, d, and id. This requires Botan 2.11.0 or higher. Also simplified the parameter test across KDF's. Aligned SymmetricCipher parameters with available modes. All encrypt and decrypt operations are done in-place instead of returning new objects. This allows use of secure vectors in the future with no additional overhead. Took this opportunity to decouple KeeShare from SSH Agent. Removed leftover code from OpenSSHKey and consolidated the SSH Agent code into the same directory. Removed bcrypt and blowfish inserts since they are provided by Botan. Additionally simplified KeeShare settings interface by removing raw certificate byte data from the user interface. KeeShare will be further refactored in a future PR. NOTE: This PR breaks backwards compatibility with KeeShare certificates due to different RSA key storage with Botan. As a result, new "own" certificates will need to be generated and trust re-established. Removed YKChallengeResponseKeyCLI in favor of just using the original implementation with signal/slots. Removed TestRandom stub since it was just faking random numbers and not actually using the backend. TestRandomGenerator now uses the actual RNG. Greatly simplified Secret Service plugin's use of crypto functions with Botan.
69 lines
2.9 KiB
C++
69 lines
2.9 KiB
C++
/*
|
|
* Copyright (C) 2018 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "Signature.h"
|
|
|
|
#include "crypto/Random.h"
|
|
|
|
bool Signature::create(const QByteArray& data, QSharedPointer<Botan::Private_Key> key, QString& signature)
|
|
{
|
|
// TODO HNH: currently we publish the signature in our own non-standard format - it would
|
|
// be better to use a standard format (like ASN1 - but this would be more easy
|
|
// when we integrate a proper library)
|
|
// Even more, we could publish standard self signed certificates with the container
|
|
// instead of the custom certificates
|
|
if (key->algo_name() == "RSA") {
|
|
try {
|
|
Botan::PK_Signer signer(*key, "EMSA3(SHA-256)");
|
|
signer.update(reinterpret_cast<const uint8_t*>(data.constData()), data.size());
|
|
auto s = signer.signature(*randomGen()->getRng());
|
|
|
|
auto hex = QByteArray(reinterpret_cast<char*>(s.data()), s.size()).toHex();
|
|
signature = QString("rsa|%1").arg(QString::fromLatin1(hex));
|
|
return true;
|
|
} catch (std::exception& e) {
|
|
qWarning("KeeShare: Failed to sign data: %s", e.what());
|
|
return false;
|
|
}
|
|
}
|
|
qWarning("Unsupported Public/Private key format");
|
|
return false;
|
|
}
|
|
|
|
bool Signature::verify(const QByteArray& data, QSharedPointer<Botan::Public_Key> key, const QString& signature)
|
|
{
|
|
if (key && key->algo_name() == "RSA") {
|
|
QRegExp extractor("rsa\\|([a-f0-9]+)", Qt::CaseInsensitive);
|
|
if (!extractor.exactMatch(signature) || extractor.captureCount() != 1) {
|
|
qWarning("Could not unpack signature parts");
|
|
return false;
|
|
}
|
|
const QByteArray sig_s = QByteArray::fromHex(extractor.cap(1).toLatin1());
|
|
|
|
try {
|
|
Botan::PK_Verifier verifier(*key, "EMSA3(SHA-256)");
|
|
verifier.update(reinterpret_cast<const uint8_t*>(data.constData()), data.size());
|
|
return verifier.check_signature(reinterpret_cast<const uint8_t*>(sig_s.constData()), sig_s.size());
|
|
} catch (std::exception& e) {
|
|
qWarning("KeeShare: Failed to verify signature: %s", e.what());
|
|
return false;
|
|
}
|
|
}
|
|
qWarning("Unsupported Public/Private key format");
|
|
return false;
|
|
}
|