mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-01-14 16:57:32 -05:00
80809ace67
Selected the [Botan crypto library](https://github.com/randombit/botan) due to its feature list, maintainer support, availability across all deployment platforms, and ease of use. Also evaluated Crypto++ as a viable candidate, but the additional features of Botan (PKCS#11, TPM, etc) won out. The random number generator received a backend upgrade. Botan prefers hardware-based RNG's and will provide one if available. This is transparent to KeePassXC and a significant improvement over gcrypt. Replaced Argon2 library with built-in Botan implementation that supports i, d, and id. This requires Botan 2.11.0 or higher. Also simplified the parameter test across KDF's. Aligned SymmetricCipher parameters with available modes. All encrypt and decrypt operations are done in-place instead of returning new objects. This allows use of secure vectors in the future with no additional overhead. Took this opportunity to decouple KeeShare from SSH Agent. Removed leftover code from OpenSSHKey and consolidated the SSH Agent code into the same directory. Removed bcrypt and blowfish inserts since they are provided by Botan. Additionally simplified KeeShare settings interface by removing raw certificate byte data from the user interface. KeeShare will be further refactored in a future PR. NOTE: This PR breaks backwards compatibility with KeeShare certificates due to different RSA key storage with Botan. As a result, new "own" certificates will need to be generated and trust re-established. Removed YKChallengeResponseKeyCLI in favor of just using the original implementation with signal/slots. Removed TestRandom stub since it was just faking random numbers and not actually using the backend. TestRandomGenerator now uses the actual RNG. Greatly simplified Secret Service plugin's use of crypto functions with Botan.
93 lines
3.0 KiB
C++
93 lines
3.0 KiB
C++
/*
|
|
* Copyright (C) 2014 Kyle Manna <kyle@kylemanna.com>
|
|
* Copyright (C) 2017 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "TestYkChallengeResponseKey.h"
|
|
#include "TestGlobal.h"
|
|
|
|
#include "core/Tools.h"
|
|
#include "crypto/Crypto.h"
|
|
#include "keys/YkChallengeResponseKey.h"
|
|
|
|
#include <QScopedPointer>
|
|
#include <QSignalSpy>
|
|
|
|
QTEST_GUILESS_MAIN(TestYubiKeyChallengeResponse)
|
|
|
|
void TestYubiKeyChallengeResponse::initTestCase()
|
|
{
|
|
// crypto subsystem needs to be initialized for YubiKey testing
|
|
QVERIFY(Crypto::init());
|
|
|
|
if (!YubiKey::instance()->isInitialized()) {
|
|
QSKIP("Unable to initialize YubiKey interface.");
|
|
}
|
|
}
|
|
|
|
void TestYubiKeyChallengeResponse::testDetectDevices()
|
|
{
|
|
YubiKey::instance()->findValidKeys();
|
|
|
|
// Wait for the hardware to respond
|
|
QSignalSpy detected(YubiKey::instance(), SIGNAL(detectComplete(bool)));
|
|
QTRY_VERIFY_WITH_TIMEOUT(detected.count() > 0, 2000);
|
|
|
|
// Look at the information retrieved from the key(s)
|
|
for (auto key : YubiKey::instance()->foundKeys()) {
|
|
auto displayName = YubiKey::instance()->getDisplayName(key);
|
|
QVERIFY(displayName.contains("Challenge Response - Slot") || displayName.contains("Configured Slot -"));
|
|
QVERIFY(displayName.contains(QString::number(key.first)));
|
|
QVERIFY(displayName.contains(QString::number(key.second)));
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Secret key for the YubiKey slot used by the unit test is
|
|
* 1c e3 0f d7 8d 20 dc fa 40 b5 0c 18 77 9a fb 0f 02 28 8d b7
|
|
* This secret can be on either slot but must be passive.
|
|
*/
|
|
void TestYubiKeyChallengeResponse::testKeyChallenge()
|
|
{
|
|
auto keys = YubiKey::instance()->foundKeys();
|
|
if (keys.isEmpty()) {
|
|
QSKIP("No YubiKey devices were detected.");
|
|
}
|
|
|
|
// Find a key that is configured in passive mode
|
|
bool wouldBlock = false;
|
|
YubiKeySlot pKey(0, 0);
|
|
for (auto key : keys) {
|
|
if (YubiKey::instance()->testChallenge(key, &wouldBlock) && !wouldBlock) {
|
|
pKey = key;
|
|
break;
|
|
}
|
|
Tools::wait(100);
|
|
}
|
|
|
|
if (pKey.first == 0) {
|
|
/* Testing active mode in unit tests is unreasonable */
|
|
QSKIP("No YubiKey contains a slot in passive mode.");
|
|
}
|
|
|
|
QScopedPointer<YkChallengeResponseKey> key(new YkChallengeResponseKey(pKey));
|
|
|
|
QByteArray ba("UnitTest");
|
|
QVERIFY(key->challenge(ba));
|
|
QCOMPARE(key->rawKey().size(), 20UL);
|
|
}
|