mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-01-24 05:31:11 -05:00
78ef6f0d04
Resolves #1313 What this commit does: * Whenever the Apply button is pressed, and if the save was successful, then the Apply button is disabled. * Each subwidget used by EditEntryWidget has now a signal called `widgetUpdated` that is emitted when the widgets' internal content changes. The EditEntryWidget subscribes to that signal to know when to enable the Apply button (by calling `entryUpdated()`). * There are some views that are not isolated in their own widgets (`m_advancedUi`, for example) so in those cases I invoked `entryUpdated()` directly whenever I detected an update: * some updates occur directly in a Qt widget like when editing the text of a QLineItem, so in that case I connected the widget's signals directly to the `entryUpdated()` slot. * some updates occur in EditEntryWidget, so in those cases the invocation to `entryUpdated()` is made as soon as the change is detected (for example when the user has confirmed an action in a dialog). A known problem: there are some situations when the Apply button will get enabled even if there are no changes, this is because the app changes the value of a field by itself so it's considered an update (for example, clicking on the "Reveal" button changes the text shown in a text field). The solution to this can be a bit complicated: disabling temporarily the `entryUpdated()` whenever the app is going to do an action with such side-effects. So I preferred to let the Apply button get enabled in those cases.
92 lines
2.3 KiB
C++
92 lines
2.3 KiB
C++
/*
|
|
* Copyright (C) 2012 Felix Geyer <debfx@fobos.de>
|
|
* Copyright (C) 2017 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSX_EDITWIDGETICONS_H
|
|
#define KEEPASSX_EDITWIDGETICONS_H
|
|
|
|
#include <QWidget>
|
|
#include <QSet>
|
|
#include <QUrl>
|
|
|
|
#include "config-keepassx.h"
|
|
#include "core/Global.h"
|
|
#include "core/Uuid.h"
|
|
#include "gui/MessageWidget.h"
|
|
|
|
class Database;
|
|
class DefaultIconModel;
|
|
class CustomIconModel;
|
|
|
|
namespace Ui {
|
|
class EditWidgetIcons;
|
|
}
|
|
|
|
struct IconStruct
|
|
{
|
|
IconStruct();
|
|
|
|
Uuid uuid;
|
|
int number;
|
|
};
|
|
|
|
class EditWidgetIcons : public QWidget
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit EditWidgetIcons(QWidget* parent = nullptr);
|
|
~EditWidgetIcons();
|
|
|
|
IconStruct state();
|
|
void reset();
|
|
void load(const Uuid& currentUuid, Database* database, const IconStruct& iconStruct, const QString& url = "");
|
|
|
|
public slots:
|
|
void setUrl(const QString& url);
|
|
|
|
signals:
|
|
void messageEditEntry(QString, MessageWidget::MessageType);
|
|
void messageEditEntryDismiss();
|
|
void widgetUpdated();
|
|
|
|
private slots:
|
|
void downloadFavicon();
|
|
#ifdef WITH_XC_NETWORKING
|
|
QImage fetchFavicon(const QUrl& url);
|
|
#endif
|
|
void addCustomIconFromFile();
|
|
void addCustomIcon(const QImage& icon);
|
|
void removeCustomIcon();
|
|
void updateWidgetsDefaultIcons(bool checked);
|
|
void updateWidgetsCustomIcons(bool checked);
|
|
void updateRadioButtonDefaultIcons();
|
|
void updateRadioButtonCustomIcons();
|
|
|
|
private:
|
|
const QScopedPointer<Ui::EditWidgetIcons> m_ui;
|
|
Database* m_database;
|
|
Uuid m_currentUuid;
|
|
QString m_url;
|
|
DefaultIconModel* const m_defaultIconModel;
|
|
CustomIconModel* const m_customIconModel;
|
|
|
|
Q_DISABLE_COPY(EditWidgetIcons)
|
|
};
|
|
|
|
#endif // KEEPASSX_EDITWIDGETICONS_H
|