mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2024-12-26 07:49:50 -05:00
ac2b445db6
Refactors the Passkey implementation to include more checks and a structure that is more aligned with the official specification. Notable changes: - _BrowserService_ no longer does the checks by itself. A new class _BrowserPasskeysClient_ constructs the relevant objects, acting as a client. _BrowserService_ only acts as a bridge between the client and _BrowserPasskeys_ (authenticator) and calls the relevant popups for user interaction. - A new helper class _PasskeyUtils_ includes the actual checks and parses the objects. - _BrowserPasskeys_ is pretty much intact, but some functions have been moved to PasskeyUtils. - Fixes Ed25519 encoding in _BrowserCBOR_. - Adds new error messages. - User confirmation for Passkey retrieval is also asked even if `discouraged` is used. This goes against the specification, but currently there's no other way to verify the user. - `cross-platform` is also accepted for compatibility. This could be removed if there's a potential issue with it. - Extension data is now handled correctly during Authentication. - Allowed and excluded credentials are now handled correctly. - `KPEX_PASSKEY_GENERATED_USER_ID` is renamed to `KPEX_PASSKEY_CREDENTIAL_ID` - Adds a new option "Allow localhost with Passkeys" to Browser Integration -> Advanced tab. By default it's not allowed to access HTTP sites, but `http://localhost` can be allowed for debugging and testing purposes for local servers. - Add tag `Passkey` to a Passkey entry, or an entry with an imported Passkey. Fixes #10287.
145 lines
6.0 KiB
C++
145 lines
6.0 KiB
C++
/*
|
|
* Copyright (C) 2024 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "TestUrlTools.h"
|
|
#include <QTest>
|
|
|
|
QTEST_GUILESS_MAIN(TestUrlTools)
|
|
|
|
void TestUrlTools::initTestCase()
|
|
{
|
|
m_urlTools = urlTools();
|
|
}
|
|
|
|
void TestUrlTools::init()
|
|
{
|
|
}
|
|
|
|
void TestUrlTools::testTopLevelDomain()
|
|
{
|
|
// Create list of URLs and expected TLD responses
|
|
QList<QPair<QString, QString>> tldUrls{
|
|
{QString("https://another.example.co.uk"), QString("co.uk")},
|
|
{QString("https://www.example.com"), QString("com")},
|
|
{QString("https://example.com"), QString("com")},
|
|
{QString("https://github.com"), QString("com")},
|
|
{QString("http://test.net"), QString("net")},
|
|
{QString("http://so.many.subdomains.co.jp"), QString("co.jp")},
|
|
{QString("https://192.168.0.1"), QString("192.168.0.1")},
|
|
{QString("https://192.168.0.1:8000"), QString("192.168.0.1")},
|
|
{QString("https://www.nic.ar"), QString("ar")},
|
|
{QString("https://no.no.no"), QString("no")},
|
|
{QString("https://www.blogspot.com.ar"), QString("blogspot.com.ar")}, // blogspot.com.ar is a TLD
|
|
{QString("https://jap.an.ide.kyoto.jp"), QString("ide.kyoto.jp")}, // ide.kyoto.jp is a TLD
|
|
{QString("ar"), QString("ar")},
|
|
};
|
|
|
|
for (const auto& u : tldUrls) {
|
|
QCOMPARE(urlTools()->getTopLevelDomainFromUrl(u.first), u.second);
|
|
}
|
|
|
|
// Create list of URLs and expected base URL responses
|
|
QList<QPair<QString, QString>> baseUrls{
|
|
{QString("https://another.example.co.uk"), QString("example.co.uk")},
|
|
{QString("https://www.example.com"), QString("example.com")},
|
|
{QString("http://test.net"), QString("test.net")},
|
|
{QString("http://so.many.subdomains.co.jp"), QString("subdomains.co.jp")},
|
|
{QString("https://192.168.0.1"), QString("192.168.0.1")},
|
|
{QString("https://192.168.0.1:8000"), QString("192.168.0.1")},
|
|
{QString("https://www.nic.ar"), QString("nic.ar")},
|
|
{QString("https://www.blogspot.com.ar"), QString("www.blogspot.com.ar")}, // blogspot.com.ar is a TLD
|
|
{QString("https://www.arpa"), QString("www.arpa")},
|
|
{QString("https://jap.an.ide.kyoto.jp"), QString("an.ide.kyoto.jp")}, // ide.kyoto.jp is a TLD
|
|
{QString("https://kobe.jp"), QString("kobe.jp")},
|
|
};
|
|
|
|
for (const auto& u : baseUrls) {
|
|
QCOMPARE(urlTools()->getBaseDomainFromUrl(u.first), u.second);
|
|
}
|
|
}
|
|
|
|
void TestUrlTools::testIsIpAddress()
|
|
{
|
|
auto host1 = "example.com"; // Not valid
|
|
auto host2 = "192.168.0.1";
|
|
auto host3 = "278.21.2.0"; // Not valid
|
|
auto host4 = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
|
|
auto host5 = "2001:db8:0:1:1:1:1:1";
|
|
auto host6 = "fe80::1ff:fe23:4567:890a";
|
|
auto host7 = "2001:20::1";
|
|
auto host8 = "2001:0db8:85y3:0000:0000:8a2e:0370:7334"; // Not valid
|
|
auto host9 = "[::]";
|
|
auto host10 = "::";
|
|
auto host11 = "[2001:20::1]";
|
|
|
|
QVERIFY(!urlTools()->isIpAddress(host1));
|
|
QVERIFY(urlTools()->isIpAddress(host2));
|
|
QVERIFY(!urlTools()->isIpAddress(host3));
|
|
QVERIFY(urlTools()->isIpAddress(host4));
|
|
QVERIFY(urlTools()->isIpAddress(host5));
|
|
QVERIFY(urlTools()->isIpAddress(host6));
|
|
QVERIFY(urlTools()->isIpAddress(host7));
|
|
QVERIFY(!urlTools()->isIpAddress(host8));
|
|
QVERIFY(urlTools()->isIpAddress(host9));
|
|
QVERIFY(urlTools()->isIpAddress(host10));
|
|
QVERIFY(urlTools()->isIpAddress(host11));
|
|
}
|
|
|
|
void TestUrlTools::testIsUrlIdentical()
|
|
{
|
|
QVERIFY(urlTools()->isUrlIdentical("https://example.com", "https://example.com"));
|
|
QVERIFY(urlTools()->isUrlIdentical("https://example.com", " https://example.com "));
|
|
QVERIFY(!urlTools()->isUrlIdentical("https://example.com", "https://example2.com"));
|
|
QVERIFY(!urlTools()->isUrlIdentical("https://example.com/", "https://example.com/#login"));
|
|
QVERIFY(urlTools()->isUrlIdentical("https://example.com", "https://example.com/"));
|
|
QVERIFY(urlTools()->isUrlIdentical("https://example.com/", "https://example.com"));
|
|
QVERIFY(urlTools()->isUrlIdentical("https://example.com/ ", " https://example.com"));
|
|
QVERIFY(!urlTools()->isUrlIdentical("https://example.com/", " example.com"));
|
|
QVERIFY(urlTools()->isUrlIdentical("https://example.com/path/to/nowhere", "https://example.com/path/to/nowhere/"));
|
|
QVERIFY(!urlTools()->isUrlIdentical("https://example.com/", "://example.com/"));
|
|
QVERIFY(urlTools()->isUrlIdentical("ftp://127.0.0.1/", "ftp://127.0.0.1"));
|
|
}
|
|
|
|
void TestUrlTools::testIsUrlValid()
|
|
{
|
|
QHash<QString, bool> urls;
|
|
urls["https://github.com/login"] = true;
|
|
urls["https:///github.com/"] = false;
|
|
urls["http://github.com/**//*"] = false;
|
|
urls["http://*.github.com/login"] = false;
|
|
urls["//github.com"] = true;
|
|
urls["github.com/{}<>"] = false;
|
|
urls["http:/example.com"] = false;
|
|
urls["http:/example.com."] = false;
|
|
urls["cmd://C:/Toolchains/msys2/usr/bin/mintty \"ssh jon@192.168.0.1:22\""] = true;
|
|
urls["file:///Users/testUser/Code/test.html"] = true;
|
|
urls["{REF:A@I:46C9B1FFBD4ABC4BBB260C6190BAD20C} "] = true;
|
|
|
|
QHashIterator<QString, bool> i(urls);
|
|
while (i.hasNext()) {
|
|
i.next();
|
|
QCOMPARE(urlTools()->isUrlValid(i.key()), i.value());
|
|
}
|
|
}
|
|
|
|
void TestUrlTools::testDomainHasIllegalCharacters()
|
|
{
|
|
QVERIFY(!urlTools()->domainHasIllegalCharacters("example.com"));
|
|
QVERIFY(urlTools()->domainHasIllegalCharacters("domain has spaces.com"));
|
|
QVERIFY(urlTools()->domainHasIllegalCharacters("example#|.com"));
|
|
}
|