mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-01-24 21:46:54 -05:00
d612cad09a
The Database, DatabaseWidget, and DatabaseTabWidget classes share many responsibilities in inconsistent ways resulting in impenetrable and unmaintainable code and a diverse set of bugs and architecture restrictions. This patch reworks the architecture, responsibilities of, and dependencies between these classes. The core changes are: * Move loading and saving logic from widgets into the Database class * Get rid of the DatabaseManagerStruct and move all the information contained in it into the Database * Let database objects keep track of modifications and dirty/clean state instead of handing this to external widgets * Move GUI interactions for loading and saving from the DatabaseTabWidget into the DatabaseWidget (resolves #2494 as a side-effect) * Heavily clean up DatabaseTabWidget and degrade it to a slightly glorified QTabWidget * Use QSharedPointers for all Database objects * Remove the modifiedImmediate signal and replace it with a markAsModified() method * Implement proper tabName() method instead of reading back titles from GUI widgets (resolves #1389 and its duplicates #2146 #855) * Fix unwanted AES-KDF downgrade if database uses Argon2 and has CustomData * Improve code This patch is also the first major step towards solving issues #476 and #2322. |
||
|---|---|---|
| .. | ||
| Add.cpp | ||
| Add.h | ||
| Clip.cpp | ||
| Clip.h | ||
| CMakeLists.txt | ||
| Command.cpp | ||
| Command.h | ||
| Diceware.cpp | ||
| Diceware.h | ||
| Edit.cpp | ||
| Edit.h | ||
| Estimate.cpp | ||
| Estimate.h | ||
| Extract.cpp | ||
| Extract.h | ||
| Generate.cpp | ||
| Generate.h | ||
| keepassxc-cli.1 | ||
| keepassxc-cli.cpp | ||
| List.cpp | ||
| List.h | ||
| Locate.cpp | ||
| Locate.h | ||
| Merge.cpp | ||
| Merge.h | ||
| Remove.cpp | ||
| Remove.h | ||
| Show.cpp | ||
| Show.h | ||
| TextStream.cpp | ||
| TextStream.h | ||
| Utils.cpp | ||
| Utils.h | ||