mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-03-10 08:09:23 -04:00
1b1643b5d1
* Fixes #11502 - correct improper handling of text qualifiers * Improve layout of csv import widget * Hide error messages when trying to import again
345 lines
8.6 KiB
C++
345 lines
8.6 KiB
C++
/*
|
|
* Copyright (C) 2015 Enrico Mariotti <enricomariotti@yahoo.it>
|
|
* Copyright (C) 2017 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "TestCsvParser.h"
|
|
|
|
#include <QTest>
|
|
|
|
QTEST_GUILESS_MAIN(TestCsvParser)
|
|
|
|
void TestCsvParser::writeToFile(const QString& contents)
|
|
{
|
|
if (!file->open()) {
|
|
QFAIL("Cannot open temporary file!");
|
|
}
|
|
QTextStream out(file.data());
|
|
out.setCodec("UTF-8");
|
|
out << contents;
|
|
out.flush();
|
|
file->close();
|
|
}
|
|
|
|
void TestCsvParser::initTestCase()
|
|
{
|
|
parser.reset(new CsvParser());
|
|
}
|
|
|
|
void TestCsvParser::init()
|
|
{
|
|
file.reset(new QTemporaryFile());
|
|
|
|
parser->setBackslashSyntax(false);
|
|
parser->setComment('#');
|
|
parser->setFieldSeparator(',');
|
|
parser->setTextQualifier(QChar('"'));
|
|
}
|
|
|
|
void TestCsvParser::cleanup()
|
|
{
|
|
file->remove();
|
|
}
|
|
|
|
/****************** TEST CASES ******************/
|
|
void TestCsvParser::testMissingQuote()
|
|
{
|
|
writeToFile("A,B\n:BM,1");
|
|
parser->setTextQualifier(':');
|
|
|
|
QVERIFY(!parser->parse(file.data()));
|
|
QWARN(parser->getStatus().toLatin1());
|
|
}
|
|
|
|
void TestCsvParser::testMalformed()
|
|
{
|
|
writeToFile("A,B,C\n:BM::,1,:2:");
|
|
parser->setTextQualifier(':');
|
|
|
|
QVERIFY(!parser->parse(file.data()));
|
|
QWARN(parser->getStatus().toLatin1());
|
|
}
|
|
|
|
void TestCsvParser::testBackslashSyntax()
|
|
{
|
|
// attended result: one"\t\"wo
|
|
writeToFile("Xone\\\"\\\\t\\\\\\\"w\noX\n"
|
|
"X13X,X2\\X,X,\"\"3\"X\r"
|
|
"3,X\"4\"X,,\n"
|
|
"XX\n"
|
|
"\\");
|
|
|
|
parser->setBackslashSyntax(true);
|
|
parser->setTextQualifier(QChar('X'));
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.at(0).at(0) == "one\"\\t\\\"w\no");
|
|
QVERIFY(t.at(1).at(0) == "13");
|
|
QVERIFY(t.at(1).at(1) == "2X,");
|
|
QVERIFY(t.at(1).at(2) == "\"\"3\"X");
|
|
QVERIFY(t.at(2).at(0) == "3");
|
|
QVERIFY(t.at(2).at(1) == "\"4\"");
|
|
QVERIFY(t.at(2).at(2) == "");
|
|
QVERIFY(t.at(2).at(3) == "");
|
|
QVERIFY(t.at(3).at(0) == "\\");
|
|
QVERIFY(t.size() == 4);
|
|
}
|
|
|
|
void TestCsvParser::testQuoted()
|
|
{
|
|
writeToFile("ro,w,\"end, of \"\"\"\"\"\"row\"\"\"\"\"\n"
|
|
"2\n");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.at(0).at(0) == "ro");
|
|
QVERIFY(t.at(0).at(1) == "w");
|
|
QVERIFY(t.at(0).at(2) == "end, of \"\"\"row\"\"");
|
|
QVERIFY(t.at(1).at(0) == "2");
|
|
QVERIFY(t.size() == 2);
|
|
}
|
|
|
|
void TestCsvParser::testEmptySimple()
|
|
{
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.isEmpty());
|
|
}
|
|
|
|
void TestCsvParser::testEmptyQuoted()
|
|
{
|
|
writeToFile("\"\"");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.isEmpty());
|
|
}
|
|
|
|
void TestCsvParser::testEmptyNewline()
|
|
{
|
|
writeToFile("\"\n\"");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.isEmpty());
|
|
}
|
|
|
|
void TestCsvParser::testEmptyFile()
|
|
{
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.isEmpty());
|
|
}
|
|
|
|
void TestCsvParser::testNewline()
|
|
{
|
|
writeToFile("1,2\n\n\n");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 1);
|
|
QVERIFY(t.at(0).at(0) == "1");
|
|
QVERIFY(t.at(0).at(1) == "2");
|
|
}
|
|
|
|
void TestCsvParser::testCR()
|
|
{
|
|
writeToFile("1,2\r3,4");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 2);
|
|
QVERIFY(t.at(0).at(0) == "1");
|
|
QVERIFY(t.at(0).at(1) == "2");
|
|
QVERIFY(t.at(1).at(0) == "3");
|
|
QVERIFY(t.at(1).at(1) == "4");
|
|
}
|
|
|
|
void TestCsvParser::testLF()
|
|
{
|
|
writeToFile("1,2\n3,4");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 2);
|
|
QVERIFY(t.at(0).at(0) == "1");
|
|
QVERIFY(t.at(0).at(1) == "2");
|
|
QVERIFY(t.at(1).at(0) == "3");
|
|
QVERIFY(t.at(1).at(1) == "4");
|
|
}
|
|
|
|
void TestCsvParser::testCRLF()
|
|
{
|
|
writeToFile("1,2\r\n3,4");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 2);
|
|
QVERIFY(t.at(0).at(0) == "1");
|
|
QVERIFY(t.at(0).at(1) == "2");
|
|
QVERIFY(t.at(1).at(0) == "3");
|
|
QVERIFY(t.at(1).at(1) == "4");
|
|
}
|
|
|
|
void TestCsvParser::testComments()
|
|
{
|
|
writeToFile(" #one\n"
|
|
" \t # two, three \r\n"
|
|
" #, sing\t with\r"
|
|
" #\t me!\n"
|
|
"useful,text #1!");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 1);
|
|
QVERIFY(t.at(0).at(0) == "useful");
|
|
QVERIFY(t.at(0).at(1) == "text #1!");
|
|
}
|
|
|
|
void TestCsvParser::testColumns()
|
|
{
|
|
writeToFile("1,2\n"
|
|
",,,,,,,,,a\n"
|
|
"a,b,c,d\n");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(parser->getCsvCols() == 10);
|
|
}
|
|
|
|
void TestCsvParser::testSimple()
|
|
{
|
|
writeToFile(",,2\r,2,3\n"
|
|
"A,,B\"\n"
|
|
" ,,\n");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 4);
|
|
QVERIFY(t.at(0).at(0) == "");
|
|
QVERIFY(t.at(0).at(1) == "");
|
|
QVERIFY(t.at(0).at(2) == "2");
|
|
QVERIFY(t.at(1).at(0) == "");
|
|
QVERIFY(t.at(1).at(1) == "2");
|
|
QVERIFY(t.at(1).at(2) == "3");
|
|
QVERIFY(t.at(2).at(0) == "A");
|
|
QVERIFY(t.at(2).at(1) == "");
|
|
QVERIFY(t.at(2).at(2) == "B\"");
|
|
QVERIFY(t.at(3).at(0) == " ");
|
|
QVERIFY(t.at(3).at(1) == "");
|
|
QVERIFY(t.at(3).at(2) == "");
|
|
}
|
|
|
|
void TestCsvParser::testSeparator()
|
|
{
|
|
writeToFile("\t\t2\r\t2\t3\n"
|
|
"A\t\tB\"\n"
|
|
" \t\t\n");
|
|
|
|
parser->setFieldSeparator('\t');
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 4);
|
|
QVERIFY(t.at(0).at(0) == "");
|
|
QVERIFY(t.at(0).at(1) == "");
|
|
QVERIFY(t.at(0).at(2) == "2");
|
|
QVERIFY(t.at(1).at(0) == "");
|
|
QVERIFY(t.at(1).at(1) == "2");
|
|
QVERIFY(t.at(1).at(2) == "3");
|
|
QVERIFY(t.at(2).at(0) == "A");
|
|
QVERIFY(t.at(2).at(1) == "");
|
|
QVERIFY(t.at(2).at(2) == "B\"");
|
|
QVERIFY(t.at(3).at(0) == " ");
|
|
QVERIFY(t.at(3).at(1) == "");
|
|
QVERIFY(t.at(3).at(2) == "");
|
|
}
|
|
|
|
void TestCsvParser::testMultiline()
|
|
{
|
|
writeToFile(":1\r\n2a::b:,:3\r4:\n"
|
|
"2\n");
|
|
|
|
parser->setTextQualifier(QChar(':'));
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.at(0).at(0) == "1\n2a:b");
|
|
QVERIFY(t.at(0).at(1) == "3\n4");
|
|
QVERIFY(t.at(1).at(0) == "2");
|
|
QVERIFY(t.size() == 2);
|
|
}
|
|
|
|
void TestCsvParser::testReparsing()
|
|
{
|
|
writeToFile(":te\r\nxt1:,:te\rxt2:,:end of \"this\n string\":\n"
|
|
"2\n");
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
|
|
QCOMPARE(t.at(0).at(0), QString(":te"));
|
|
|
|
parser->setTextQualifier(QChar(':'));
|
|
|
|
QVERIFY(parser->reparse());
|
|
t = parser->getCsvTable();
|
|
QCOMPARE(t.at(0).at(0), QString("te\nxt1"));
|
|
QCOMPARE(t.at(0).at(1), QString("te\nxt2"));
|
|
QCOMPARE(t.at(0).at(2), QString("end of \"this\n string\""));
|
|
QCOMPARE(t.at(1).at(0), QString("2"));
|
|
QCOMPARE(t.size(), 2);
|
|
}
|
|
|
|
void TestCsvParser::testQualifier()
|
|
{
|
|
writeToFile("X1X,X2XX,X,\"\"3\"\"\"X\r"
|
|
"3,X\"4\"X,,\n");
|
|
|
|
parser->setTextQualifier(QChar('X'));
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 2);
|
|
QVERIFY(t.at(0).at(0) == "1");
|
|
QVERIFY(t.at(0).at(1) == "2X,");
|
|
QVERIFY(t.at(0).at(2) == "\"\"3\"\"\"X");
|
|
QVERIFY(t.at(1).at(0) == "3");
|
|
QVERIFY(t.at(1).at(1) == "\"4\"");
|
|
QVERIFY(t.at(1).at(2) == "");
|
|
QVERIFY(t.at(1).at(3) == "");
|
|
}
|
|
|
|
void TestCsvParser::testUnicode()
|
|
{
|
|
// QString m("Texte en fran\u00e7ais");
|
|
// CORRECT QString g("\u20AC");
|
|
// CORRECT QChar g(0x20AC);
|
|
// ERROR QChar g("\u20AC");
|
|
writeToFile("€1A2śA\"3śAż\"Ażac");
|
|
|
|
parser->setFieldSeparator(QChar('A'));
|
|
|
|
QVERIFY(parser->parse(file.data()));
|
|
t = parser->getCsvTable();
|
|
QVERIFY(t.size() == 1);
|
|
QVERIFY(t.at(0).at(0) == "€1");
|
|
QVERIFY(t.at(0).at(1) == "2ś");
|
|
QVERIFY(t.at(0).at(2) == "3śAż");
|
|
QVERIFY(t.at(0).at(3) == "żac");
|
|
}
|