mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-02-11 20:28:30 -05:00
9f8943c89b
* core: database: make UUID searching case-insensitive
4c4d8a5e848c ("Implement search for reference placeholder based on
fields other than ID") changed the semantics of searching-by-reference
in KeePassXC. Unforuntately it contained a bug where it implicitly
became case-sensitive to UUIDs, which broke existing databases that used
references (especially since the default reference format uses a
different case to the UUID used while searching).
The tests didn't catch this because ->toHex() preserves the case that it
was provided, they have been updated to check that UUIDs are case
insensitive.
* cli: show: resolve references in output
Previously, `keepassxc-cli show` would not resolve references. This
would make it quite hard to script around its output (since there's not
interface to resolve references manually either). Fix this by using
resolveMultiplePlaceholders as with all other users of ->password() and
related entry fields.
Fixes: keepassxreboot/keepassxc#1260
* tests: entry: add tests for ref-cloned entries
This ensures that the most "intuitive" current usage of references
(through the clone feature of the GUI) remains self-consistent and
always produces the correct results. In addition, explicitly test that
case insensitivity works as expected. These should avoid similar
regressions in reference handling in the future.
* http: resolve references in AccessControlDialog
The access control dialog previously would not show the "real" username
or "real" title when asking for permission to give access to entries.
Fix this by resolving it, as we do in many other places.
Fixes: keepassxreboot/keepassxc#1269
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
109 lines
3.8 KiB
C++
109 lines
3.8 KiB
C++
/*
|
|
* Copyright (C) 2017 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <cstdlib>
|
|
#include <stdio.h>
|
|
|
|
#include "Show.h"
|
|
|
|
#include <QCommandLineParser>
|
|
#include <QTextStream>
|
|
|
|
#include "core/Database.h"
|
|
#include "core/Entry.h"
|
|
#include "core/Group.h"
|
|
|
|
Show::Show()
|
|
{
|
|
this->name = QString("show");
|
|
this->description = QObject::tr("Show an entry's information.");
|
|
}
|
|
|
|
Show::~Show()
|
|
{
|
|
}
|
|
|
|
int Show::execute(QStringList arguments)
|
|
{
|
|
QTextStream out(stdout);
|
|
|
|
QCommandLineParser parser;
|
|
parser.setApplicationDescription(this->description);
|
|
parser.addPositionalArgument("database", QObject::tr("Path of the database."));
|
|
QCommandLineOption keyFile(QStringList() << "k"
|
|
<< "key-file",
|
|
QObject::tr("Key file of the database."),
|
|
QObject::tr("path"));
|
|
parser.addOption(keyFile);
|
|
QCommandLineOption attributes(QStringList() << "a"
|
|
<< "attributes",
|
|
QObject::tr("Names of the attributes to show. "
|
|
"This option can be specified more than once, with each attribute shown one-per-line in the given order. "
|
|
"If no attributes are specified, a summary of the default attributes is given."),
|
|
QObject::tr("attribute"));
|
|
parser.addOption(attributes);
|
|
parser.addPositionalArgument("entry", QObject::tr("Name of the entry to show."));
|
|
parser.process(arguments);
|
|
|
|
const QStringList args = parser.positionalArguments();
|
|
if (args.size() != 2) {
|
|
out << parser.helpText().replace("keepassxc-cli", "keepassxc-cli show");
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
Database* db = Database::unlockFromStdin(args.at(0), parser.value(keyFile));
|
|
if (db == nullptr) {
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
return this->showEntry(db, parser.values(attributes), args.at(1));
|
|
}
|
|
|
|
int Show::showEntry(Database* database, QStringList attributes, QString entryPath)
|
|
{
|
|
|
|
QTextStream inputTextStream(stdin, QIODevice::ReadOnly);
|
|
QTextStream outputTextStream(stdout, QIODevice::WriteOnly);
|
|
|
|
Entry* entry = database->rootGroup()->findEntry(entryPath);
|
|
if (!entry) {
|
|
qCritical("Could not find entry with path %s.", qPrintable(entryPath));
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
// If no attributes specified, output the default attribute set.
|
|
bool showAttributeNames = attributes.isEmpty();
|
|
if (attributes.isEmpty()) {
|
|
attributes = EntryAttributes::DefaultAttributes;
|
|
}
|
|
|
|
// Iterate over the attributes and output them line-by-line.
|
|
bool sawUnknownAttribute = false;
|
|
for (QString attribute : attributes) {
|
|
if (!entry->attributes()->contains(attribute)) {
|
|
sawUnknownAttribute = true;
|
|
qCritical("ERROR: unknown attribute '%s'.", qPrintable(attribute));
|
|
continue;
|
|
}
|
|
if (showAttributeNames) {
|
|
outputTextStream << attribute << ": ";
|
|
}
|
|
outputTextStream << entry->resolveMultiplePlaceholders(entry->attributes()->value(attribute)) << endl;
|
|
}
|
|
return sawUnknownAttribute ? EXIT_FAILURE : EXIT_SUCCESS;
|
|
}
|