Commit Graph

1894 Commits

Author SHA1 Message Date
Janek Bevendorff
901bf62213 Generate random 128-byte stream instead of legacy XML format when creating key files
Add API documentation for FileKey class
Resolves #1325
2017-12-26 22:37:45 +01:00
Janek Bevendorff
f8b7ffcf8c Add WITH_XC_SSHAGENT flag to build config and use cmake3 package 2017-12-26 13:07:10 +01:00
Jonathan White
cc1ab94a4f Correct regression to ssh-agent from entry attachment refactor 2017-12-25 23:22:10 +01:00
frostasm
80636ab083 Use EntryAttachmentsWidget in details view 2017-12-25 14:36:43 +02:00
frostasm
c490c21cd5 Move attachments view to the separate widget EntryAttachmentsWidget 2017-12-25 14:36:43 +02:00
frostasm
ed0bda98a6 Fix failing entry model test for attachment name and size 2017-12-25 14:36:41 +02:00
frostasm
0c200d360b Add attachments tab to details view 2017-12-24 20:10:12 +02:00
frostasm
90a64dbde2 Add drag and drop support for attachments view in EditEntryWidget 2017-12-24 20:10:12 +02:00
frostasm
bf5b96362f Use a table view to display the list of attachments in EditEntryWidget 2017-12-24 20:10:12 +02:00
Janek Bevendorff
c579736158 Bundle qtbase translations on Windows 2017-12-23 17:47:46 +01:00
Janek Bevendorff
5b525eb9ca Refactor Translator class to load qtbase translations from local directory if available 2017-12-23 17:47:46 +01:00
Yen Chi Hsuan
fc39e8f27d Fix font size of URL label in the preview panel 2017-12-23 16:20:59 +08:00
Sebastian Marsching
470ddb4704
Merge branch 'develop' into issue-1148-msi-package 2017-12-22 12:14:59 +01:00
louib
8037a79673
Add \n in merge request message. (#1310) 2017-12-20 18:08:18 -05:00
Aleksa Sarai
9f8943c89b keepassxc-cli show: resolve references in output (#1280)
* core: database: make UUID searching case-insensitive

4c4d8a5e84 ("Implement search for reference placeholder based on
fields other than ID") changed the semantics of searching-by-reference
in KeePassXC. Unforuntately it contained a bug where it implicitly
became case-sensitive to UUIDs, which broke existing databases that used
references (especially since the default reference format uses a
different case to the UUID used while searching).

The tests didn't catch this because ->toHex() preserves the case that it
was provided, they have been updated to check that UUIDs are case
insensitive.

* cli: show: resolve references in output

Previously, `keepassxc-cli show` would not resolve references. This
would make it quite hard to script around its output (since there's not
interface to resolve references manually either). Fix this by using
resolveMultiplePlaceholders as with all other users of ->password() and
related entry fields.

Fixes: keepassxreboot/keepassxc#1260

* tests: entry: add tests for ref-cloned entries

This ensures that the most "intuitive" current usage of references
(through the clone feature of the GUI) remains self-consistent and
always produces the correct results. In addition, explicitly test that
case insensitivity works as expected. These should avoid similar
regressions in reference handling in the future.

* http: resolve references in AccessControlDialog

The access control dialog previously would not show the "real" username
or "real" title when asking for permission to give access to entries.
Fix this by resolving it, as we do in many other places.

Fixes: keepassxreboot/keepassxc#1269


Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
2017-12-17 10:44:12 -05:00
Aleksa Sarai
8e231dfa95 cli: show: add --attributes flag (#1289)
In order for scripting to be much simpler with `keepassxc-cli show`,
provide a simple --attributesk API which effectively is just a CLI
interface for entry->attributes()->value(...). This allows for more
extensibility and prevents changes in our output formatting from
breaking existing users of keepassxc-cli (if they use --attributes).

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
2017-12-16 19:14:39 -05:00
Toni Spets
76e6d498cf SSH Agent: Split private key selection 2017-12-16 09:59:51 +02:00
Toni Spets
d2a59c556e Refactor fixed font selection into Font class 2017-12-16 09:59:51 +02:00
louib
8b1c8f69f7
Removing password output from Estimate. (#1281)
* Removing password output from Estimate.

* clang-format
2017-12-14 20:22:59 -05:00
Jonathan White
28ad6ed552 Merge branch 'master' into develop 2017-12-11 21:10:25 -05:00
Nicolas Garnier
74dac174db Enable translations for 'Extended ASCII' button 2017-12-08 10:52:40 +01:00
Matt Signorini
fef8f5c453 Tidied up code. 2017-12-06 17:10:25 +01:00
Matt Signorini
8f48ede957 Add keypress handler to the password generator widget so that esc quits
in standalone mode.
2017-12-06 17:10:25 +01:00
TheZ3ro
f2a464f626
Merge branch 'develop' into develop 2017-12-05 17:26:14 +01:00
louib
471e684151
Rename EntropyMeter -> Estimate (#1250)
* EntropyMeter -> Estimate
* Cleaning estimate
* Documentation
* clang-formatting /cli
2017-12-04 09:46:23 -05:00
Sebastian Marsching
1ce77e6f15 Remove WIX from default list of CPack generators.
This ensures that MSI packages are only built when explicitly requested
by using the "-G" parameter of cpack.
2017-12-03 17:49:15 +01:00
Mike Woudenberg
938cf8fce2 Adds listener for Gnome specific screensaver activation 2017-12-03 13:17:43 +01:00
frostasm
c4bbb76da4 Remove "Can't resolve placeholder" warning (#1137) 2017-11-30 20:07:16 +02:00
frostasm
d99dee9c40 Small refactoring related to references placeholders 2017-11-30 20:07:16 +02:00
Martin Unzner
b44092ac43 Add capability to resolve UUID 2017-11-30 20:07:16 +02:00
frostasm
4c4d8a5e84 Implement search for reference placeholder based on fields other than ID 2017-11-30 20:07:16 +02:00
frostasm
8c7ef64fab Show "Can't resolve placeholder" warning only in debug mode 2017-11-30 20:07:16 +02:00
alterratz
468519cd46
Merge branch 'develop' into feature/autoopen 2017-11-28 17:29:05 +01:00
Michal Kaptur
0ff75e7a88 Fixed memory leaks in non-gui tests
Fixed 2 memory leaks in production code and a few in testcases. As a
result leak_check_at_exit ASAN option does not need to turned off for
non-gui tests.
Smart pointers should be used elsewhere for consistency, but the sooner
this fixes are delivered, the lesser memory leaks are introduced.
2017-11-27 23:36:09 +01:00
Janek Bevendorff
d35f3fc573 Treat warning as errors 2017-11-27 20:57:55 +01:00
Weslly
5fa76dfd66
Remove ShowToolbar from config 2017-11-26 22:59:48 -02:00
Weslly
525d5de30c
Remove empty context menu from toolbar 2017-11-26 22:23:15 -02:00
Janek Bevendorff
8651736e61
Merge branch 'release/2.2.3' into develop 2017-11-26 18:23:48 +01:00
Janek Bevendorff
8905fe5a54 Use Consolas on Windows for PasswordEdit instead of the default Courier New, resolves #1226 2017-11-26 17:53:15 +01:00
Jonathan White
e17b3d24bf Corrected database corruption when locked [#1113] 2017-11-23 21:32:56 +01:00
thez3ro
135e8419ae
refactor saveLastDir code 2017-11-22 22:20:38 +01:00
thez3ro
cd1e0571a5
forget keyfile path, fix #1151 2017-11-22 22:20:38 +01:00
Louis-Bertrand Varin
2cd5006260 Formatting 2017-11-21 14:06:40 -05:00
Louis-Bertrand Varin
94ea323836 Extracting default clone flags. 2017-11-21 14:06:40 -05:00
Louis-Bertrand Varin
2ff56fe86c Only updating custom group icon if set. 2017-11-21 14:06:40 -05:00
Louis-Bertrand Varin
9603c91877 Merge : Synchronising groups. 2017-11-21 14:06:40 -05:00
Vladimir Svyatski
236846baa7 Add menu shortcut Alt+m (underlined letter) for "Empty recycle bin" for consistency with other items in the same submenu which all have "Alt+underlined letter" style shortcuts. 2017-11-21 02:12:55 +01:00
Balázs Meskó
a4d1293eaf I18n fixes in Service.cpp (#875)
Fix plural strings
2017-11-21 02:12:14 +01:00
Weslly
19ac36b965
Change QTotp class name to Totp 2017-11-20 22:25:09 -02:00
Joel Smith
8ca52ba8f9 Add initial Steam TOTP support
* Add the concept of custom TOTP encoders, each with potential for custom
  code alphabet, length, step interval and code direction (i.e. reversed)
* Select custom encoder via overload of the digits field of a loaded entry
* Allow selection of custom encoders via the "TOTP Settings" field's
  size, as currently done by KeeTrayTOTP for Steam. Use "S" for the
  short name of the Steam custom encoder
* Allow selection of custom encoders via the "otp" field by appending
  a "&encoder=<name>" field to the URL query. For example,
  "&encoder=steam"
* Update TOTP set-up dialog to permit selection between (default,
  steam, custom) settings.
2017-11-20 17:08:01 -07:00
Weslly
afe48da4b1
Change MacPasteboard init object to QScopedPointer 2017-11-20 17:25:27 -02:00
Weslly
806248ebd4
Review fixes 2017-11-20 16:50:56 -02:00
Weslly
dc7322cc4a
Improve macOS pasteboard handling 2017-11-20 16:09:42 -02:00
Weslly
f0a34de3c0
Revert 5bc000c to fix startup delay 2017-11-20 15:36:30 -02:00
Weslly
3b8d49104c
Focus database unlock dialog on macOS, fix #1023 2017-11-20 04:26:53 -02:00
Toni Spets
4840c2c64f SSH agent support 2017-11-19 14:38:59 +02:00
Toni Spets
248ae9d4ba SymmetricCipher: Add keySize(), don't rely on state for sizes
This additionally makes keySize() and blockSize() work before
setting the key and IV. Required for SSH agent decryption.
2017-11-19 14:38:59 +02:00
Toni Spets
a81a5fa31b SymmetricCipher: Support CTR mode
Includes AES-256-CTR non-stream tests
2017-11-19 14:38:59 +02:00
Adolfo E. García
cc6be754f7 Remove deprecated Optional.h 2017-11-12 12:09:35 -06:00
Adolfo E. García
c9895dd5c7 Improve Base32.cpp 2017-11-12 12:09:35 -06:00
frostasm
f34b090b42 Add support for working with multiple entry attachments at once 2017-11-12 17:41:53 +02:00
frostasm
2987895370 Fix usage of LastAttachmentDir in entry attachments 2017-11-12 17:41:53 +02:00
Adolfo E. García
3427a1aff4 Fix #1156
- Fix multiple activations of updateTotp by different QTimer instance timeouts.
- Fix call to updateTotp with invalid, uninitialized state
- Fix tooltip description
2017-11-11 16:25:20 -06:00
thez3ro
c3c67f18b8
add test for DB creation 2017-11-02 20:07:41 +01:00
frostasm
afaa0a3493 Fix formatting brackets in DatabaseWidgetStateSync::setActive function 2017-11-02 20:47:54 +02:00
frostasm
8b00d0580b Synchronize the height of the preview panel for all open databases 2017-11-02 19:09:36 +02:00
frostasm
6bbd42bfd1 Allow to change the height of the preview panel (#1135) 2017-11-02 19:09:36 +02:00
Sebastian Marsching
3e9067fe8e Add build of MSI packages (#1148) 2017-10-30 15:41:20 +01:00
frostasm
ffe344ce90 Save the geometry of main window only if the window is visible 2017-10-29 11:19:43 +02:00
thez3ro
7e54bd4956
prevent crash with empty database 2017-10-28 21:30:24 +02:00
Jonathan White
4e7f2c6a4f
Fix apply button not saving new entries 2017-10-28 09:23:45 -04:00
frostasm
2027429d87 Add support for placeholders on the KeePassHTTP custom fields 2017-10-26 14:30:20 +03:00
thez3ro
9840470df8
hide note option 2017-10-26 13:13:31 +02:00
Joe Brown
ff01a7da1e
Hint is displayed when notes section is hidden.
The alignment is a bit off, however.  A better option may be simply
disabling the QPlainTextEdit widget and stashing the actual notes
in another buffer somewhere.
2017-10-26 13:12:32 +02:00
Joe Brown
fdceeb368e
Do not hide notes by default. 2017-10-26 13:12:32 +02:00
Joe Brown
0c2d71c2ce
Notes section no longer visible by default.
There is a simple checkbox that allows your notes to become visible
again.  This is always disabled by default, as the use case
referenced in issue #342 (and my own use case) has confidential data
in that field.

Passes all tests (YubiKey is N/A) on Ubuntu 16.04.2 with Qt 5.5.1.
2017-10-26 13:12:32 +02:00
Joe Brown
5bc000cc31
Use fixed-width font for Notes
Fixed width, and a smaller font size, make for easier readability
in the notes section.
2017-10-26 13:12:32 +02:00
Jonathan White
f3d85ae219
Cleaned up url display code 2017-10-26 12:19:23 +02:00
Jonathan White
b9fd609bb2
Resolve placeholders in entry details url 2017-10-26 12:19:23 +02:00
thez3ro
8416d69f1e
fix protected transalation 2017-10-26 12:19:23 +02:00
thez3ro
71ae2a3458
remember last selected tab, hide passwords by default 2017-10-26 12:19:23 +02:00
thez3ro
9279bf7628
fix group layout, add autotype associations 2017-10-26 12:19:23 +02:00
thez3ro
d0f8d43739
remove root group from path, resize icons to 16x16 2017-10-26 12:19:23 +02:00
thez3ro
eb65822665
layout update 2017-10-26 12:19:23 +02:00
thez3ro
4a5fc2104f
fix notes label 2017-10-26 12:19:23 +02:00
thez3ro
0e6fedc056
fix group parent, add details update by keyboard 2017-10-26 12:19:23 +02:00
thez3ro
1a87e30b95
add preview panel for entries and groups 2017-10-26 12:19:23 +02:00
Francois Ferrand
263bee3c09 Detect session lock on Xfce/XUbuntu 16.04
The current code does not work with XUbuntu 16.04, which uses
light-locker to lock the screen.

I am not using a screensaver, but I suspect the screensaver activation
may have been detected by the existing events, and using it could thus
mask the issue.
2017-10-25 17:09:00 +02:00
Louis-Bertrand Varin
055ba4f14e Q_NULLPTR -> nullptr 2017-10-25 10:15:37 -04:00
Louis-Bertrand Varin
ecfbad0443 Disable reload prompt when db is locked 2017-10-24 20:26:02 -04:00
thez3ro
4076b37378
disable the save button if there isn't anything to save 2017-10-24 20:40:53 +02:00
thez3ro
ca59ae4f4f
remove useless View menu 2017-10-24 20:40:53 +02:00
Janek Bevendorff
be88e93820
Merge branch 'release/2.2.3' into develop 2017-10-24 18:00:38 +02:00
Janek Bevendorff
05d02b702a Restrict global menu fix to Qt < 5.9.0, resolves #691 2017-10-24 17:58:27 +02:00
Janek Bevendorff
f6933a8868 Ensure that YubiKey is only polled once, even if showEvent() is called twice 2017-10-24 17:58:27 +02:00
frostasm
b6387f7709 AutoType: resolve placeholders in window associations list 2017-10-23 22:55:22 +03:00
frostasm
7f2bd47849 AutoType: resolve placeholders for title in window associations 2017-10-23 22:55:22 +03:00
Janek Bevendorff
067da8223d
Fix build after merge 2017-10-21 22:38:24 +02:00
Janek Bevendorff
b510243dd8
Merge branch 'release/2.2.2' into develop 2017-10-21 22:23:27 +02:00
Peter Nirschl
a895729b9e 🐛 Fix result propagation in SymmetricCipherGcrypt::process
The boolean 'ok' has always been set to true, regardless of possible errors.
2017-10-21 20:00:28 +02:00
Adolfo E. García
7198f20d69 Improve building of macOS target 2017-10-21 10:12:28 -06:00
Janek Bevendorff
aba2acb062 Use QSharedPointer 2017-10-21 14:19:00 +02:00
Louis-Bertrand Varin
a1aad5d165 Using QScopedPointer 2017-10-21 14:19:00 +02:00
Louis-Bertrand Varin
0fe06b3fbb Fix double warning display for database open 2017-10-21 14:19:00 +02:00
Janek Bevendorff
7cc6f6f2a3 Merge pull request #1059 from frostasm/add-auto-hide-functionality-to-inline-message-widget
Add auto hide functionality to inline message widget (#1006)
2017-10-21 13:47:06 +02:00
Adolfo E. García
86cd2c09a4 Improve readability of code 2017-10-21 13:15:02 +02:00
Adolfo E. García
f1d99dd0ed Improve testing of Base32 2017-10-21 13:15:02 +02:00
Adolfo E. García
c731f8e5c0 Fix bug in Base32::decode and add bounds check
The bug that was fixed, was affecting how the number of bytes of decoded data was  calculated and thus, even though it didn't truncate the result, it was causing the array to be resized unnecessarily.
2017-10-21 13:15:02 +02:00
Adolfo E. García
24f560aaa2 Replace Optional with QVariant 2017-10-21 13:15:02 +02:00
Adolfo E. García
905e104ba2 Revert formatting change 2017-10-21 13:15:02 +02:00
Adolfo E. García
d21ae0f94a Fix for loop's variable increment style 2017-10-21 13:15:02 +02:00
Adolfo E. García
95b0ad15ef Fix code style 2017-10-21 13:15:02 +02:00
Adolfo E. García
19eb6a8a60 Add new Base32 implementation 2017-10-21 13:15:02 +02:00
Janek Bevendorff
f634f20ccc
Merge branch 'release/2.2.2' into develop 2017-10-20 23:08:04 +02:00
Jonathan White
37aa4f0257 Unlock previously opened databases with --pw-stdin 2017-10-20 01:21:32 +02:00
Janek Bevendorff
190d3a1da9 Merge pull request #1078 from frostasm/implement-recursive-resolving-for-placeholders
Implement recursive resolving for placeholders
2017-10-19 21:50:57 +02:00
Janek Bevendorff
8592f7e672 Merge branch 'release/2.2.2' into develop 2017-10-19 21:45:49 +02:00
frostasm
f0fcc19915 Implement recursive resolving for placeholders 2017-10-19 22:40:26 +03:00
frostasm
e81d8beb19 Refactor Entry::resolvePlaceholder function 2017-10-19 22:40:26 +03:00
frostasm
5e0df62d7a Add processing of the url placeholders 2017-10-19 22:40:26 +03:00
frostasm
f38fe5a9dd Disable automatic hiding of an information message for YubiKey 2017-10-19 22:22:10 +03:00
frostasm
75cfe1c5dd Add the auto hide functionality to the MessageWidget 2017-10-19 22:22:10 +03:00
Janek Bevendorff
ec8c99c3b2 Fix remaining uses of KEEPASSXC_SNAP_BUILD 2017-10-19 15:52:46 +02:00
Janek Bevendorff
bae9dbc407 Add distribution information to debug info screen 2017-10-19 15:52:46 +02:00
rockihack
c6f83b9ca6 Fix: Regenerate transform seed and transform master key on save. 2017-10-18 23:04:37 -04:00
alterratz
6c3d6b7c28 Merge branch 'develop' into feature/autoopen 2017-10-13 22:38:51 +02:00
Bernhard Rieder
0fc8c37f23 changed file:/ to file:// 2017-10-12 23:30:51 +02:00
Janek Bevendorff
ab21f718ba Merge branch 'release/2.2.2' into develop 2017-10-12 14:10:20 +02:00
frostasm
24333d0a19 Add toolbar button for copy url to clipboard 2017-10-12 11:46:01 +03:00
frostasm
60215cf2cf Add button for auto-type in the toolbar (#1026) 2017-10-12 11:46:01 +03:00
Jonathan White
3bc8a79b9b Both slots on Yubikey are now polled for challenge/response 2017-10-09 09:39:47 -04:00
Bernhard Rieder
6d569a86f9 added autoopen functionality (#477) 2017-10-09 13:26:24 +02:00
TheZ3ro
e9dd6e6c90 Merge branch 'develop' into middle-mouse-click-status-icon 2017-10-07 17:57:38 +02:00
Louis-Bertrand Varin
2e81751131 Backporting #1008 2017-10-07 11:03:24 -04:00
louib
242faa138b Add custom icons when merging. (#1008)
* Adding missing custom icons on merge.
* qDebug when adding icon
* Adding test for merge custom icons.
2017-10-07 10:40:29 -04:00
Jonathan White
157f1134bf
Select custom icon radio button after successful download 2017-10-07 08:49:14 -04:00
Jonathan White
4277364e91 Fixed cast warning 2017-10-07 07:36:25 -04:00
frostasm
4e903e4c50
Fix memory leak in DatabaseTabWidget::openDatabase function 2017-10-05 18:03:01 -04:00
frostasm
2481367ab4 Fix memory leak in DatabaseTabWidget::openDatabase function 2017-10-05 18:01:54 -04:00
Jonathan White
5098866413 Rewrote resolveUrl function to conform to various test cases 2017-10-03 18:40:32 -04:00
Jonathan White
91d746c5c0 Corrected issues with desktop and tray icons in snap build 2017-10-03 15:43:52 -04:00
rockihack
e53754d202
Fix build on mac os with qt 5.9.1 2017-10-03 15:01:54 -04:00
thez3ro
eb21eeb214 Fix GoogleFallback/Screnlock settings 2017-10-03 17:37:26 +02:00
Jonathan White
14e3d9d576
Merge remote-tracking branch 'origin/master' into develop
# Conflicts:
#	src/core/Group.cpp
2017-10-01 11:10:10 -04:00
Jonathan White
de5f8082de Check for mismatched passwords BEFORE saving to prevent data loss 2017-09-29 18:11:53 -04:00
Jonathan White
59786d7bd7 Mask passwords in URL column in Entry View 2017-09-29 16:14:41 -04:00
Jonathan White
cb0b948603 Multiple fixes to custom icon downloading
* Fixes #904, icons are saved at or below 128x128
* Fixes #403, crash occurs due to dialog on non-gui thread
* Fixes #232, icon hashes calculated and compared against
2017-09-29 09:01:55 -04:00
Jonathan White
2e4f1a21b4 Clear LastDatabases and LastKeyFiles when they are disabled in settings 2017-09-28 12:07:21 -04:00
Jonathan White
649a14db84 Set "Don't Modify for Non-Data Changes" to true by default 2017-09-28 12:07:21 -04:00
Jonathan White
9ebe0b61eb Correct latent single instance lock file preventing launch
* Fixes #893
2017-09-27 18:33:59 -04:00