Git-Mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-08-08 22:42:34 -04:00
Code Issues Projects Releases Packages Wiki Activity

Replace QMap with QHash when the key is a pointer

Browse source 
QHash gives faster lookups than QMap when the key is a pointer.
This commit is contained in:
Gianluca Recchia 2019-01-17 06:03:58 +01:00 • committed by Jonathan White
parent 9a5bbea2e4
commit ffea029001
No known key found for this signature in database
GPG key ID: 440FC65F2E0C6E01
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/gui/MessageBox.cpp
View file

@ -20,8 +20,8 @@
MessageBox::Button MessageBox::m_nextAnswer(MessageBox::NoButton); MessageBox::Button MessageBox::m_nextAnswer(MessageBox::NoButton);
QMap<QAbstractButton*, MessageBox::Button> MessageBox::m_addedButtonLookup = QHash<QAbstractButton*, MessageBox::Button> MessageBox::m_addedButtonLookup =
QMap<QAbstractButton*, MessageBox::Button>(); QHash<QAbstractButton*, MessageBox::Button>();
QMap<MessageBox::Button, std::pair<QString, QMessageBox::ButtonRole>> MessageBox::m_buttonDefs = QMap<MessageBox::Button, std::pair<QString, QMessageBox::ButtonRole>> MessageBox::m_buttonDefs =
QMap<MessageBox::Button, std::pair<QString, QMessageBox::ButtonRole>>(); QMap<MessageBox::Button, std::pair<QString, QMessageBox::ButtonRole>>();

3
src/gui/MessageBox.h
View file

@ -19,6 +19,7 @@
#ifndef KEEPASSX_MESSAGEBOX_H #ifndef KEEPASSX_MESSAGEBOX_H
#define KEEPASSX_MESSAGEBOX_H #define KEEPASSX_MESSAGEBOX_H
#include <QHash>
#include <QMap> #include <QMap>
#include <QMessageBox> #include <QMessageBox>
#include <QPushButton> #include <QPushButton>
@ -102,7 +103,7 @@ public:
private: private:
static Button m_nextAnswer; static Button m_nextAnswer;
static QMap<QAbstractButton*, Button> m_addedButtonLookup; static QHash<QAbstractButton*, Button> m_addedButtonLookup;
static QMap<Button, std::pair<QString, QMessageBox::ButtonRole>> m_buttonDefs; static QMap<Button, std::pair<QString, QMessageBox::ButtonRole>> m_buttonDefs;
static Button messageBox(QWidget* parent, static Button messageBox(QWidget* parent,