Git-Mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2024-12-25 07:19:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improve testing of Base32

Browse Source
This commit is contained in:
Adolfo E. García 2017-10-20 18:31:17 -06:00 committed by Janek Bevendorff
parent c731f8e5c0
commit f1d99dd0ed
2 changed files with 49 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/core/Base32.cpp
View File

@ -135,6 +135,7 @@ QVariant Base32::decode(const QByteArray& encodedData)
} }
} }
Q_ASSERT(encodedData.size() == i);
Q_ASSERT(nBytes == o); Q_ASSERT(nBytes == o);
return QVariant::fromValue(data); return QVariant::fromValue(data);

64
tests/TestBase32.cpp
View File

@ -26,55 +26,73 @@ void TestBase32::testDecode()
// 3 quanta, all upper case + padding // 3 quanta, all upper case + padding
QByteArray encodedData = "JBSWY3DPEB3W64TMMQXC4LQ="; QByteArray encodedData = "JBSWY3DPEB3W64TMMQXC4LQ=";
QVariant data = Base32::decode(encodedData); QVariant data = Base32::decode(encodedData);
QString expectedData = "Hello world...";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("Hello world...")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// 4 quanta, all upper case // 4 quanta, all upper case
encodedData = "GEZDGNBVGY3TQOJQGEZDGNBVGY3TQOJQ"; encodedData = "GEZDGNBVGY3TQOJQGEZDGNBVGY3TQOJQ";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "12345678901234567890";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("12345678901234567890")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// 4 quanta, all lower case // 4 quanta, all lower case
encodedData = "gezdgnbvgy3tqojqgezdgnbvgy3tqojq"; encodedData = "gezdgnbvgy3tqojqgezdgnbvgy3tqojq";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "12345678901234567890";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("12345678901234567890")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// 4 quanta, mixed upper and lower case // 4 quanta, mixed upper and lower case
encodedData = "Gezdgnbvgy3tQojqgezdGnbvgy3tQojQ"; encodedData = "Gezdgnbvgy3tQojqgezdGnbvgy3tQojQ";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "12345678901234567890";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("12345678901234567890")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// 1 pad characters // 1 pad characters
encodedData = "ORSXG5A="; encodedData = "ORSXG5A=";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "test";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("test")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// 3 pad characters // 3 pad characters
encodedData = "L5PV6==="; encodedData = "L5PV6===";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "___";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("___")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// 4 pad characters // 4 pad characters
encodedData = "MZXW6IDCMFZA===="; encodedData = "MZXW6IDCMFZA====";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "foo bar";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("foo bar")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// six pad characters // six pad characters
encodedData = "MZXW6YTBOI======"; encodedData = "MZXW6YTBOI======";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "foobar";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("foobar")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
encodedData = "IA======"; encodedData = "IA======";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "@";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("@")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
// error: illegal character // error: illegal character
encodedData = "1MZXW6YTBOI====="; encodedData = "1MZXW6YTBOI=====";
@ -89,38 +107,52 @@ void TestBase32::testDecode()
// RFC 4648 test vectors // RFC 4648 test vectors
encodedData = ""; encodedData = "";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
encodedData = "MY======"; encodedData = "MY======";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "f";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("f")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
encodedData = "MZXQ===="; encodedData = "MZXQ====";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "fo";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("fo")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
encodedData = "MZXW6==="; encodedData = "MZXW6===";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("foo")); expectedData = "foo";
QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
encodedData = "MZXW6YQ="; encodedData = "MZXW6YQ=";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "foob";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("foob")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
encodedData = "MZXW6YTB"; encodedData = "MZXW6YTB";
expectedData = "fooba";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("fooba")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
encodedData = "MZXW6YTBOI======"; encodedData = "MZXW6YTBOI======";
data = Base32::decode(encodedData); data = Base32::decode(encodedData);
expectedData = "foobar";
QVERIFY(!data.isNull()); QVERIFY(!data.isNull());
QCOMPARE(data.toString(), QString("foobar")); QCOMPARE(data.toString(), expectedData);
QVERIFY(data.value<QByteArray>().size() == expectedData.size());
} }
void TestBase32::testEncode() void TestBase32::testEncode()