Ask PR authors to remove lines that don't apply instead of changing emoji (#159)

* Ask user to remove lines that don't apply instead of changing emoji
* Replace KeePassXR with KeePassXC
* Add help text how to find KeePassXC version [skip ci]
* Combine documentation requirements into one [skip ci]
This commit is contained in:
Janek Bevendorff 2017-01-14 21:09:59 +02:00 committed by Jonathan White
parent 995420ee87
commit d1793d9bcf
2 changed files with 16 additions and 18 deletions

View File

@ -26,7 +26,7 @@
## Your Environment ## Your Environment
<!--- Include relevant details about the environment you experienced the bug in --> <!--- Include relevant details about the environment you experienced the bug in -->
* KeePassXR version/commit used: * KeePassXC version/commit used: (can be found under Help -> About)
* Qt version (e.g. Qt 5.3): * Qt version (e.g. Qt 5.3):
* Compiler (e.g. Clang++3.6.0): * Compiler (e.g. Clang++3.6.0):
* Operating System and version: * Operating System and version:

View File

@ -1,4 +1,4 @@
<!--- Provide a general summary of your changes in the Title above --> <!--- Provide a general summary of your changes in the title above -->
## Description ## Description
<!--- Describe your changes in detail --> <!--- Describe your changes in detail -->
@ -15,21 +15,19 @@
## Screenshots (if appropriate): ## Screenshots (if appropriate):
## Types of changes ## Types of changes
<!--- What types of changes does your code introduce? If it apply to your pull request, --> <!--- What types of changes does your code introduce? -->
<!--- replace all the `:negative_squared_cross_mark:` with `:white_check_mark:` --> <!--- Please remove all lines which don't apply. -->
<!--- Everybody loves emoji --> - ✅ Bug fix (non-breaking change which fixes an issue)
- :negative_squared_cross_mark: Bug fix (non-breaking change which fixes an issue) - ✅ New feature (non-breaking change which adds functionality)
- :negative_squared_cross_mark: New feature (non-breaking change which adds functionality) - ✅ Breaking change (fix or feature that would cause existing functionality to change)
- :negative_squared_cross_mark: Breaking change (fix or feature that would cause existing functionality to change)
## Checklist: ## Checklist:
<!--- Go over all the following points, if it apply to your pull request, --> <!--- Please go over all the following points. -->
<!--- replace all the `:negative_squared_cross_mark:` with `:white_check_mark:`. --> <!--- Again, remove any lines which don't apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!--- Pull Requests that don't fulfill all [REQUIRED] requisites are likely -->
<!--- Pull Requests that fail the [REQUIRED] field will likely be sent back for corrections or rejected --> <!--- to be sent back to you for correction or will be rejected. -->
- :negative_squared_cross_mark: I have read the **CONTRIBUTING** document. [REQUIRED] - ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]**
- :negative_squared_cross_mark: My code follows the code style of this project. [REQUIRED] - ✅ My code follows the code style of this project. **[REQUIRED]**
- :negative_squared_cross_mark: All new and existing tests passed. [REQUIRED] - ✅ All new and existing tests passed. **[REQUIRED]**
- :negative_squared_cross_mark: My change requires a change to the documentation. - ✅ My change requires a change to the documentation and I have updated it accordingly.
- :negative_squared_cross_mark: I have updated the documentation accordingly. - ✅ I have added tests to cover my changes.
- :negative_squared_cross_mark: I have added tests to cover my changes.