Fix all Qt 5.15 deprecation warnings (#7783)

* Deprecated qSort() -> std::sort()
* Replace QDateTime::toString(Qt::DefaultLocaleShortDate) with Clock::toString()
* Replace QDateTime::toString(Qt::SystemLocaleShortDate) with QLocale::system().toString(..., QLocale::ShortFormat)
* Use QDateTime::startOfDay() instead of QDate(QDateTime)
  Note: QDateTime::startOfDay() is only available in Qt 5.14, we need to guard it
* Replace QString::SkipEmptyParts with Qt::SkipEmptyParts
  Note: Its designated replacement, Qt::SplitBehavior, was only added in Qt 5.14.
* Don't call deprecated QFlags(nullptr) constructor
* QSet::{toList->values}
* Replace QList::toSet, QSet::fromList with Tools::asSet()
* QHash::insertMulti -> QMultiHash::insert
* QProcess::startDetached: non-deprecated overload
* QProcess::{pid->processId}
* QPainter::{HighQuality->}Antialiasing
* QPalette::{background->window}()
* Use Qt::{Background,Foreground}Role
* endl -> Qt::endl, flush -> Qt::flush
* Make YubiKey::s_interfaceMutex non-recursive
* OpenSSHKeyGenDialog: use non-deprecated QComboBox::sizeAdjustPolicy setting
This commit is contained in:
Jonathan White 2025-10-25 19:16:31 -04:00
parent df1035a31d
commit cb9fe40ebb
No known key found for this signature in database
GPG key ID: 440FC65F2E0C6E01
65 changed files with 329 additions and 236 deletions

View file

@ -18,6 +18,7 @@
#include "Estimate.h"
#include "Utils.h"
#include "core/Global.h"
#include "core/PasswordHealth.h"
#include <QCommandLineParser>
@ -45,7 +46,7 @@ static void estimate(const char* pwd, bool advanced)
// clang-format off
out << QObject::tr("Length %1").arg(len, 0) << '\t'
<< QObject::tr("Entropy %1").arg(e, 0, 'f', 3) << '\t'
<< QObject::tr("Log10 %1").arg(e * 0.301029996, 0, 'f', 3) << endl;
<< QObject::tr("Log10 %1").arg(e * 0.301029996, 0, 'f', 3) << Qt::endl;
// clang-format on
} else {
int pwdLen = 0;
@ -60,7 +61,7 @@ static void estimate(const char* pwd, bool advanced)
out << QObject::tr("Length %1").arg(len) << '\t'
<< QObject::tr("Entropy %1").arg(e, 0, 'f', 3) << '\t'
<< QObject::tr("Log10 %1").arg(e * 0.301029996, 0, 'f', 3) << "\n "
<< QObject::tr("Multi-word extra bits %1").arg(m, 0, 'f', 1) << endl;
<< QObject::tr("Multi-word extra bits %1").arg(m, 0, 'f', 1) << Qt::endl;
// clang-format on
p = info;
pwdLen = 0;
@ -133,13 +134,13 @@ static void estimate(const char* pwd, bool advanced)
for (n = 0; n < p->Length; ++n, ++pwd) {
out << *pwd;
}
out << endl;
out << Qt::endl;
p = p->Next;
}
ZxcvbnFreeInfo(info);
if (pwdLen != len) {
out << QObject::tr("*** Password length (%1) != sum of length of parts (%2) ***").arg(len).arg(pwdLen)
<< endl;
<< Qt::endl;
}
}
}