Small cleanup in cli/Show.cpp

This commit is contained in:
louib 2020-01-23 20:54:36 -05:00 committed by Jonathan White
parent b78ca924fd
commit c97ee5395b

View File

@ -78,7 +78,7 @@ int Show::executeWithDatabase(QSharedPointer<Database> database, QSharedPointer<
} }
// If no attributes specified, output the default attribute set. // If no attributes specified, output the default attribute set.
bool showAttributeNames = attributes.isEmpty() && !showTotp; bool showDefaultAttributes = attributes.isEmpty() && !showTotp;
if (attributes.isEmpty() && !showTotp) { if (attributes.isEmpty() && !showTotp) {
attributes = EntryAttributes::DefaultAttributes; attributes = EntryAttributes::DefaultAttributes;
} }
@ -91,10 +91,10 @@ int Show::executeWithDatabase(QSharedPointer<Database> database, QSharedPointer<
errorTextStream << QObject::tr("ERROR: unknown attribute %1.").arg(attributeName) << endl; errorTextStream << QObject::tr("ERROR: unknown attribute %1.").arg(attributeName) << endl;
continue; continue;
} }
if (showAttributeNames) { if (showDefaultAttributes) {
outputTextStream << attributeName << ": "; outputTextStream << attributeName << ": ";
} }
if (entry->attributes()->isProtected(attributeName) && showAttributeNames && !showProtectedAttributes) { if (entry->attributes()->isProtected(attributeName) && showDefaultAttributes && !showProtectedAttributes) {
outputTextStream << "PROTECTED" << endl; outputTextStream << "PROTECTED" << endl;
} else { } else {
outputTextStream << entry->resolveMultiplePlaceholders(entry->attributes()->value(attributeName)) << endl; outputTextStream << entry->resolveMultiplePlaceholders(entry->attributes()->value(attributeName)) << endl;
@ -102,9 +102,6 @@ int Show::executeWithDatabase(QSharedPointer<Database> database, QSharedPointer<
} }
if (showTotp) { if (showTotp) {
if (showAttributeNames) {
outputTextStream << "TOTP: ";
}
outputTextStream << entry->totp() << endl; outputTextStream << entry->totp() << endl;
} }