From c736ba7059e35675d4ba54bb8a2c8f78d5790cd7 Mon Sep 17 00:00:00 2001 From: denk-mal Date: Fri, 19 Jun 2015 13:19:30 +0200 Subject: [PATCH] set error to response if list is empty (avoid ChromeIPass hanging) --- src/http/Server.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/http/Server.cpp b/src/http/Server.cpp index 576d55bf5..727d98825 100644 --- a/src/http/Server.cpp +++ b/src/http/Server.cpp @@ -75,14 +75,19 @@ void Server::getLogins(const Request &r, Response *protocolResp) if (!r.CheckVerifier(key)) return; - protocolResp->setSuccess(); protocolResp->setId(r.id()); protocolResp->setVerifier(key); QList entries = findMatchingEntries(r.id(), r.url(), r.submitUrl(), r.realm()); //TODO: filtering, request confirmation [in db adaptation layer?] - if (r.sortSelection()) { - //TODO: sorting (in db adaptation layer? here?) + if (entries.count() == 0) { + protocolResp->setError("url not found!"); + } + else { + if (r.sortSelection()) { + //TODO: sorting (in db adaptation layer? here?) + } + protocolResp->setSuccess(); + protocolResp->setEntries(entries); } - protocolResp->setEntries(entries); } void Server::getLoginsCount(const Request &r, Response *protocolResp)