From c01e14c879983d339eb576786913a009502c00d7 Mon Sep 17 00:00:00 2001 From: Gianluca Recchia Date: Thu, 17 Jan 2019 07:31:23 +0100 Subject: [PATCH] Wrap static literal strings with QStringLiteral The strings in the deprecation map are never modified in the program and they're known at compile time. An internal resizable buffer is not needed for these strings so we can allocate them statically. --- src/core/Config.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/Config.cpp b/src/core/Config.cpp index 14b47c34c..86ed04e38 100644 --- a/src/core/Config.cpp +++ b/src/core/Config.cpp @@ -32,13 +32,13 @@ */ static const QMap deprecationMap = { // >2.3.4 - {"security/hidepassworddetails", "security/HidePasswordPreviewPanel"}, + {QStringLiteral("security/hidepassworddetails"), QStringLiteral("security/HidePasswordPreviewPanel")}, // >2.3.4 - {"GUI/HideDetailsView", "GUI/HidePreviewPanel"}, + {QStringLiteral("GUI/HideDetailsView"), QStringLiteral("GUI/HidePreviewPanel")}, // >2.3.4 - {"GUI/DetailSplitterState", "GUI/PreviewSplitterState"}, + {QStringLiteral("GUI/DetailSplitterState"), QStringLiteral("GUI/PreviewSplitterState")}, // >2.3.4 - {"security/IconDownloadFallbackToGoogle", "security/IconDownloadFallback"}, + {QStringLiteral("security/IconDownloadFallbackToGoogle"), QStringLiteral("security/IconDownloadFallback")}, }; Config* Config::m_instance(nullptr);