diff --git a/CMakeLists.txt b/CMakeLists.txt index 5c9c57a72..1f89c958d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -290,15 +290,6 @@ check_add_gcc_compiler_flag("-Werror=format-security") check_add_gcc_compiler_flag("-Werror=implicit-function-declaration" C) check_add_gcc_compiler_flag("-Wcast-align") -if(WITH_COVERAGE AND CMAKE_COMPILER_IS_CLANGXX) - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fprofile-instr-generate -fcoverage-mapping") - # then: - # $ llvm-profdata merge -sparse default.profraw -o default.profdata - # $ llvm-cov show ./tests/${the_test_binary} \ - # -format=html -instr-profile=default.profdata -output-dir=./coverages \ - # `find src -iname '*.h' -or -iname '*.cpp'` -endif() - if(UNIX AND NOT APPLE) check_add_gcc_compiler_flag("-Qunused-arguments") check_add_gcc_compiler_flag("-fPIC") @@ -394,16 +385,37 @@ endif(WITH_TESTS) if(WITH_COVERAGE) # Include code coverage, use with -DCMAKE_BUILD_TYPE=Debug include(CodeCoverage) - set(COVERAGE_GCOVR_EXCLUDES + set(COVERAGE_EXCLUDES "\\(.+/\\)?tests/.\\*" + "\\(.+/\\)?build/.\\*" + "\\(.+/\\)?thirdparty/.\\*" + "\\(.+/\\)?CMakeFiles/.\\*" + "src/main.cpp" ".\\*/moc_\\[^/\\]+\\.cpp" ".\\*/ui_\\[^/\\]+\\.h" - "\\(.+/\\)?zxcvbn/.\\*") + ".\\*/\\[^/\\]+_autogen/.\\*" + "\\(.+/\\)?zxcvbn/.\\*" + "/Applications/.\\*" + "/opt/.\\*") append_coverage_compiler_flags() - setup_target_for_coverage_gcovr_html( - NAME coverage - EXECUTABLE $(MAKE) && $(MAKE) test - ) + + if(WITH_COVERAGE AND CMAKE_COMPILER_IS_CLANGXX) + set(MAIN_BINARIES + "$" + "$" + "$") + setup_target_for_coverage_llvm( + NAME coverage + EXECUTABLE $(MAKE) test + BINARY ${MAIN_BINARIES} + SOURCES ${CMAKE_SOURCE_DIR}/src + ) + else() + setup_target_for_coverage_gcovr( + NAME coverage + EXECUTABLE $(MAKE) test + ) + endif() endif() include(CLangFormat) diff --git a/cmake/CodeCoverage.cmake b/cmake/CodeCoverage.cmake index 3dbb3c958..78633dee8 100644 --- a/cmake/CodeCoverage.cmake +++ b/cmake/CodeCoverage.cmake @@ -1,4 +1,5 @@ # Copyright (c) 2012 - 2017, Lars Bilke +# Copyright (c) 2021 KeePassXC Team # All rights reserved. # # Redistribution and use in source and binary forms, with or without modification, @@ -25,279 +26,200 @@ # ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -# -# CHANGES: -# -# 2012-01-31, Lars Bilke -# - Enable Code Coverage -# -# 2013-09-17, Joakim Söderberg -# - Added support for Clang. -# - Some additional usage instructions. -# -# 2016-02-03, Lars Bilke -# - Refactored functions to use named parameters -# -# 2017-06-02, Lars Bilke -# - Merged with modified version from github.com/ufz/ogs -# -# -# USAGE: -# -# 1. Copy this file into your cmake modules path. -# -# 2. Add the following line to your CMakeLists.txt: -# include(CodeCoverage) -# -# 3. Append necessary compiler flags: -# APPEND_COVERAGE_COMPILER_FLAGS() -# -# 4. If you need to exclude additional directories from the report, specify them -# using the COVERAGE_LCOV_EXCLUDES variable before calling SETUP_TARGET_FOR_COVERAGE_LCOV. -# Example: -# set(COVERAGE_LCOV_EXCLUDES 'dir1/*' 'dir2/*') -# -# 5. Use the functions described below to create a custom make target which -# runs your test executable and produces a code coverage report. -# -# 6. Build a Debug build: -# cmake -DCMAKE_BUILD_TYPE=Debug .. -# make -# make my_coverage_target -# include(CMakeParseArguments) # Check prereqs -find_program( GCOV_PATH gcov ) -find_program( LCOV_PATH NAMES lcov lcov.bat lcov.exe lcov.perl) -find_program( GENHTML_PATH NAMES genhtml genhtml.perl genhtml.bat ) -find_program( GCOVR_PATH gcovr PATHS ${CMAKE_SOURCE_DIR}/scripts/test) -find_program( SIMPLE_PYTHON_EXECUTABLE python ) +find_program(GCOV_PATH gcov) +find_program(LLVM_COV_PATH llvm-cov) +find_program(LLVM_PROFDATA_PATH llvm-profdata) +find_program(XCRUN_PATH xcrun) +find_program(GENHTML_PATH NAMES genhtml genhtml.perl genhtml.bat) +find_program(GCOVR_PATH gcovr PATHS ${CMAKE_SOURCE_DIR}/scripts/test) -if(NOT GCOV_PATH) - message(FATAL_ERROR "gcov not found! Aborting...") -endif() # NOT GCOV_PATH - -if("${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?[Cc]lang") - if("${CMAKE_CXX_COMPILER_VERSION}" VERSION_LESS 3) - message(FATAL_ERROR "Clang version must be 3.0.0 or greater! Aborting...") - endif() -elseif(NOT CMAKE_COMPILER_IS_GNUCXX) - message(FATAL_ERROR "Compiler is not GNU gcc! Aborting...") +set(COVERAGE_COMPILER_FLAGS "-g -O0" CACHE INTERNAL "") +if(CMAKE_COMPILER_IS_GNUCXX) + set(COVERAGE_COMPILER_FLAGS "${COVERAGE_COMPILER_FLAGS} --coverage -fprofile-arcs -ftest-coverage") +elseif(CMAKE_COMPILER_IS_CLANGXX) + set(COVERAGE_COMPILER_FLAGS "${COVERAGE_COMPILER_FLAGS} -fprofile-instr-generate -fcoverage-mapping") endif() -set(COVERAGE_COMPILER_FLAGS "-g -O0 --coverage -fprofile-arcs -ftest-coverage" - CACHE INTERNAL "") +set(CMAKE_COVERAGE_FORMAT + "html" "txt" + CACHE STRING "Coverage report output format.") +set_property(CACHE CMAKE_COVERAGE_FORMAT PROPERTY STRINGS "html" "txt") set(CMAKE_CXX_FLAGS_COVERAGE ${COVERAGE_COMPILER_FLAGS} - CACHE STRING "Flags used by the C++ compiler during coverage builds." - FORCE ) + CACHE STRING "Flags used by the C++ compiler during coverage builds.") set(CMAKE_C_FLAGS_COVERAGE ${COVERAGE_COMPILER_FLAGS} - CACHE STRING "Flags used by the C compiler during coverage builds." - FORCE ) + CACHE STRING "Flags used by the C compiler during coverage builds.") set(CMAKE_EXE_LINKER_FLAGS_COVERAGE "" - CACHE STRING "Flags used for linking binaries during coverage builds." - FORCE ) + CACHE STRING "Flags used for linking binaries during coverage builds.") set(CMAKE_SHARED_LINKER_FLAGS_COVERAGE "" - CACHE STRING "Flags used by the shared libraries linker during coverage builds." - FORCE ) + CACHE STRING "Flags used by the shared libraries linker during coverage builds.") mark_as_advanced( + CMAKE_COVERAGE_FORMAT CMAKE_CXX_FLAGS_COVERAGE CMAKE_C_FLAGS_COVERAGE CMAKE_EXE_LINKER_FLAGS_COVERAGE - CMAKE_SHARED_LINKER_FLAGS_COVERAGE ) + CMAKE_SHARED_LINKER_FLAGS_COVERAGE) if(NOT CMAKE_BUILD_TYPE_LOWER STREQUAL "debug") message(WARNING "Code coverage results with an optimised (non-Debug) build may be misleading") endif() # NOT CMAKE_BUILD_TYPE STREQUAL "Debug" -if(CMAKE_C_COMPILER_ID STREQUAL "GNU") +if(CMAKE_COMPILER_IS_GNUCXX) + if(NOT GCOV_PATH) + message(FATAL_ERROR "gcov not found! Aborting...") + endif() # NOT GCOV_PATH link_libraries(gcov) -else() - set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} --coverage") endif() + # Defines a target for running and collection code coverage information # Builds dependencies, runs the given executable and outputs reports. # NOTE! The executable should always have a ZERO as exit code otherwise # the coverage generation will not complete. # -# SETUP_TARGET_FOR_COVERAGE_LCOV( -# NAME testrunner_coverage # New target name -# EXECUTABLE testrunner -j ${PROCESSOR_COUNT} # Executable in PROJECT_BINARY_DIR -# DEPENDENCIES testrunner # Dependencies to build first +# SETUP_TARGET_FOR_COVERAGE_GCOVR( +# NAME ctest_coverage # New target name +# EXECUTABLE ctest -j ${PROCESSOR_COUNT} # Executable in PROJECT_BINARY_DIR +# DEPENDENCIES executable_target # Dependencies to build first # ) -function(SETUP_TARGET_FOR_COVERAGE_LCOV) +function(SETUP_TARGET_FOR_COVERAGE_GCOVR) set(options NONE) set(oneValueArgs NAME) set(multiValueArgs EXECUTABLE EXECUTABLE_ARGS DEPENDENCIES) cmake_parse_arguments(Coverage "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) - if(NOT LCOV_PATH) - message(FATAL_ERROR "lcov not found! Aborting...") - endif() # NOT LCOV_PATH + if(NOT GCOVR_PATH) + message(FATAL_ERROR "gcovr not found! Aborting...") + endif() # NOT GCOVR_PATH - if(NOT GENHTML_PATH) - message(FATAL_ERROR "genhtml not found! Aborting...") - endif() # NOT GENHTML_PATH + # Combine excludes to several -e arguments + set(GCOVR_EXCLUDES "") + foreach(EXCLUDE ${COVERAGE_EXCLUDES}) + list(APPEND GCOVR_EXCLUDES "-e") + list(APPEND GCOVR_EXCLUDES "${EXCLUDE}") + endforeach() - # Setup target add_custom_target(${Coverage_NAME} - - # Cleanup lcov - COMMAND ${LCOV_PATH} --gcov-tool ${GCOV_PATH} -directory . --zerocounters - # Create baseline to make sure untouched files show up in the report - COMMAND ${LCOV_PATH} --gcov-tool ${GCOV_PATH} -c -i -d . -o ${Coverage_NAME}.base - # Run tests + COMMAND $(MAKE) COMMAND ${Coverage_EXECUTABLE} - # Capturing lcov counters and generating report - COMMAND ${LCOV_PATH} --gcov-tool ${GCOV_PATH} --directory . --capture --output-file ${Coverage_NAME}.info - # add baseline counters - COMMAND ${LCOV_PATH} --gcov-tool ${GCOV_PATH} -a ${Coverage_NAME}.base -a ${Coverage_NAME}.info --output-file ${Coverage_NAME}.total - COMMAND ${LCOV_PATH} --gcov-tool ${GCOV_PATH} --remove ${Coverage_NAME}.total ${COVERAGE_LCOV_EXCLUDES} --output-file ${PROJECT_BINARY_DIR}/${Coverage_NAME}.info.cleaned - COMMAND ${GENHTML_PATH} -o ${Coverage_NAME} ${PROJECT_BINARY_DIR}/${Coverage_NAME}.info.cleaned - COMMAND ${CMAKE_COMMAND} -E remove ${Coverage_NAME}.base ${Coverage_NAME}.total ${PROJECT_BINARY_DIR}/${Coverage_NAME}.info.cleaned - - WORKING_DIRECTORY ${PROJECT_BINARY_DIR} - DEPENDS ${Coverage_DEPENDENCIES} - COMMENT "Resetting code coverage counters to zero.\nProcessing code coverage counters and generating report." - ) - - # Show where to find the lcov info report - add_custom_command(TARGET ${Coverage_NAME} POST_BUILD - COMMAND ; - COMMENT "Lcov code coverage info report saved in ${Coverage_NAME}.info." - ) - - # Show info where to find the report - add_custom_command(TARGET ${Coverage_NAME} POST_BUILD - COMMAND ; - COMMENT "Open ./${Coverage_NAME}/index.html in your browser to view the coverage report." - ) - -endfunction() # SETUP_TARGET_FOR_COVERAGE_LCOV - -# Defines a target for running and collection code coverage information -# Builds dependencies, runs the given executable and outputs reports. -# NOTE! The executable should always have a ZERO as exit code otherwise -# the coverage generation will not complete. -# -# SETUP_TARGET_FOR_COVERAGE_GCOVR_XML( -# NAME ctest_coverage # New target name -# EXECUTABLE ctest -j ${PROCESSOR_COUNT} # Executable in PROJECT_BINARY_DIR -# DEPENDENCIES executable_target # Dependencies to build first -# ) -function(SETUP_TARGET_FOR_COVERAGE_GCOVR_XML) - - set(options NONE) - set(oneValueArgs NAME) - set(multiValueArgs EXECUTABLE EXECUTABLE_ARGS DEPENDENCIES) - cmake_parse_arguments(Coverage "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) - - if(NOT SIMPLE_PYTHON_EXECUTABLE) - message(FATAL_ERROR "python not found! Aborting...") - endif() # NOT SIMPLE_PYTHON_EXECUTABLE - - if(NOT GCOVR_PATH) - message(FATAL_ERROR "gcovr not found! Aborting...") - endif() # NOT GCOVR_PATH - - # Combine excludes to several -e arguments - set(GCOVR_EXCLUDES "") - foreach(EXCLUDE ${COVERAGE_GCOVR_EXCLUDES}) - list(APPEND GCOVR_EXCLUDES "-e") - list(APPEND GCOVR_EXCLUDES "${EXCLUDE}") - endforeach() - - add_custom_target(${Coverage_NAME} - # Run tests - ${Coverage_EXECUTABLE} - - # Running gcovr - COMMAND ${GCOVR_PATH} --xml - -r ${PROJECT_SOURCE_DIR} ${GCOVR_EXCLUDES} - --object-directory=${PROJECT_BINARY_DIR} - -o ${Coverage_NAME}.xml - WORKING_DIRECTORY ${PROJECT_BINARY_DIR} - DEPENDS ${Coverage_DEPENDENCIES} - COMMENT "Running gcovr to produce Cobertura code coverage report." - ) - - # Show info where to find the report - add_custom_command(TARGET ${Coverage_NAME} POST_BUILD - COMMAND ; - COMMENT "Cobertura code coverage report saved in ${Coverage_NAME}.xml." - ) - -endfunction() # SETUP_TARGET_FOR_COVERAGE_GCOVR_XML - -# Defines a target for running and collection code coverage information -# Builds dependencies, runs the given executable and outputs reports. -# NOTE! The executable should always have a ZERO as exit code otherwise -# the coverage generation will not complete. -# -# SETUP_TARGET_FOR_COVERAGE_GCOVR_HTML( -# NAME ctest_coverage # New target name -# EXECUTABLE ctest -j ${PROCESSOR_COUNT} # Executable in PROJECT_BINARY_DIR -# DEPENDENCIES executable_target # Dependencies to build first -# ) -function(SETUP_TARGET_FOR_COVERAGE_GCOVR_HTML) - - set(options NONE) - set(oneValueArgs NAME) - set(multiValueArgs EXECUTABLE EXECUTABLE_ARGS DEPENDENCIES) - cmake_parse_arguments(Coverage "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) - - if(NOT SIMPLE_PYTHON_EXECUTABLE) - message(FATAL_ERROR "python not found! Aborting...") - endif() # NOT SIMPLE_PYTHON_EXECUTABLE - - if(NOT GCOVR_PATH) - message(FATAL_ERROR "gcovr not found! Aborting...") - endif() # NOT GCOVR_PATH - - # Combine excludes to several -e arguments - set(GCOVR_EXCLUDES "") - foreach(EXCLUDE ${COVERAGE_GCOVR_EXCLUDES}) - list(APPEND GCOVR_EXCLUDES "-e") - list(APPEND GCOVR_EXCLUDES "${EXCLUDE}") - endforeach() - - add_custom_target(${Coverage_NAME} - # Run tests - ${Coverage_EXECUTABLE} - # Create folder COMMAND ${CMAKE_COMMAND} -E make_directory ${PROJECT_BINARY_DIR}/${Coverage_NAME} - - # Running gcovr - COMMAND ${GCOVR_PATH} --html --html-details - -r ${PROJECT_SOURCE_DIR} ${GCOVR_EXCLUDES} - --object-directory=${PROJECT_BINARY_DIR} - -o ${Coverage_NAME}/index.html WORKING_DIRECTORY ${PROJECT_BINARY_DIR} DEPENDS ${Coverage_DEPENDENCIES} - COMMENT "Running gcovr to produce HTML code coverage report." ) - # Show info where to find the report - add_custom_command(TARGET ${Coverage_NAME} POST_BUILD - COMMAND ; - COMMENT "Open ./${Coverage_NAME}/index.html in your browser to view the coverage report." - ) + if("html" IN_LIST CMAKE_COVERAGE_FORMAT) + add_custom_command(TARGET ${Coverage_NAME} POST_BUILD + # Running gcovr HTML + COMMAND ${GCOVR_PATH} --html --html-details + -r ${PROJECT_SOURCE_DIR} ${GCOVR_EXCLUDES} + --object-directory=${PROJECT_BINARY_DIR} + -o ${Coverage_NAME}-html/index.html + WORKING_DIRECTORY ${PROJECT_BINARY_DIR} + COMMENT "Running gcovr to produce HTML code coverage report ${Coverage_NAME}-html." + ) + endif() + + if("txt" IN_LIST CMAKE_COVERAGE_FORMAT) + add_custom_command(TARGET ${Coverage_NAME} POST_BUILD + # Running gcovr XML + COMMAND ${GCOVR_PATH} + -r ${PROJECT_SOURCE_DIR} ${GCOVR_EXCLUDES} + --object-directory=${PROJECT_BINARY_DIR} + -o ${Coverage_NAME}.txt + WORKING_DIRECTORY ${PROJECT_BINARY_DIR} + COMMENT "Running gcovr to produce TXT code coverage report ${Coverage_NAME}.txt." + ) + endif() + +endfunction() # SETUP_TARGET_FOR_COVERAGE_GCOVR + +# Defines a target for running and collection code coverage information +# Builds dependencies, runs the given executable and outputs reports. +# NOTE! The executable should always have a ZERO as exit code otherwise +# the coverage generation will not complete. +# +# SETUP_TARGET_FOR_COVERAGE_LLVM( +# NAME ctest_coverage # New target name +# EXECUTABLE ctest -j ${PROCESSOR_COUNT} # Executable in PROJECT_BINARY_DIR +# DEPENDENCIES executable_target # Dependencies to build first +# ) +function(SETUP_TARGET_FOR_COVERAGE_LLVM) + + set(options NONE) + set(oneValueArgs NAME PROF_FILE) + set(multiValueArgs EXECUTABLE BINARY EXECUTABLE_ARGS SOURCES DEPENDENCIES) + cmake_parse_arguments(Coverage "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) + + if(XCRUN_PATH) + set(LLVM_COV_PATH ${XCRUN_PATH} llvm-cov) + set(LLVM_PROFDATA_PATH ${XCRUN_PATH} llvm-profdata) + else() + if(NOT LLVM_COV_PATH) + message(FATAL_ERROR "llvm-cov not found! Aborting...") + endif() # NOT LLVM_COV_PATH + if(NOT LLVM_PROFDATA_PATH) + message(FATAL_ERROR "llvm-profdata not found! Aborting...") + endif() # NOT LLVM_PROFDATA_PATH + endif() # XCRUN_PATH + + set(LLVM_PROFILE_DIR ${PROJECT_BINARY_DIR}/llvm_profile) + file(REMOVE_RECURSE ${LLVM_PROFILE_DIR}) + + set(COV_EXCLUDES "") + foreach(EXCLUDE ${COVERAGE_EXCLUDES}) + list(APPEND COV_EXCLUDES "-ignore-filename-regex=${EXCLUDE}") + endforeach() + + list(GET Coverage_BINARY 0 COV_BINARY) + if(Coverage_BINARY) + list(REMOVE_AT Coverage_BINARY 0) + foreach(BIN ${Coverage_BINARY}) + list(APPEND COV_BINARY -object ${BIN}) + endforeach() + endif() + + add_custom_target(${Coverage_NAME} + COMMAND $(MAKE) + COMMAND ${CMAKE_COMMAND} -E env LLVM_PROFILE_FILE=${LLVM_PROFILE_DIR}/profile-%p.profraw ${Coverage_EXECUTABLE} + + COMMAND ${LLVM_PROFDATA_PATH} merge -sparse ${LLVM_PROFILE_DIR}/* -o coverage.profdata + WORKING_DIRECTORY ${PROJECT_BINARY_DIR} + DEPENDS ${Coverage_DEPENDENCIES}) + + if("html" IN_LIST CMAKE_COVERAGE_FORMAT) + add_custom_command(TARGET ${Coverage_NAME} POST_BUILD + COMMAND ${LLVM_COV_PATH} show -instr-profile=coverage.profdata ${COV_BINARY} + --format=html --output-dir=${Coverage_NAME}-html ${COV_EXCLUDES} ${Coverage_SOURCES} + WORKING_DIRECTORY ${PROJECT_BINARY_DIR} + COMMENT "Running llvm-cov to produce HTML code coverage report ${Coverage_NAME}-html") + endif() + + if("txt" IN_LIST CMAKE_COVERAGE_FORMAT) + add_custom_command(TARGET ${Coverage_NAME} POST_BUILD + COMMAND ${LLVM_COV_PATH} show -instr-profile=coverage.profdata ${COV_BINARY} + --format=text ${COV_EXCLUDES} ${Coverage_SOURCES} > ${Coverage_NAME}.txt + + WORKING_DIRECTORY ${PROJECT_BINARY_DIR} + COMMENT "Running llvm-cov to produce TXT code coverage report ${Coverage_NAME}.txt.") + endif() + +endfunction() # SETUP_TARGET_FOR_COVERAGE_LLVM -endfunction() # SETUP_TARGET_FOR_COVERAGE_GCOVR_HTML function(APPEND_COVERAGE_COMPILER_FLAGS) + message(STATUS "Appending code coverage compiler flags: ${COVERAGE_COMPILER_FLAGS}") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${COVERAGE_COMPILER_FLAGS}" PARENT_SCOPE) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${COVERAGE_COMPILER_FLAGS}" PARENT_SCOPE) - message(STATUS "Appending code coverage compiler flags: ${COVERAGE_COMPILER_FLAGS}") endfunction() # APPEND_COVERAGE_COMPILER_FLAGS diff --git a/codecov.yaml b/codecov.yaml new file mode 100644 index 000000000..e671b003b --- /dev/null +++ b/codecov.yaml @@ -0,0 +1,6 @@ +coverage: + range: 60..80 + round: nearest + precision: 2 +comment: + require_changes: true diff --git a/src/gui/PasswordEdit.cpp b/src/gui/PasswordEdit.cpp index c83402610..5f9272b1b 100644 --- a/src/gui/PasswordEdit.cpp +++ b/src/gui/PasswordEdit.cpp @@ -51,9 +51,9 @@ PasswordEdit::PasswordEdit(QWidget* parent) // Prevent conflicts with global Mac shortcuts (force Control on all platforms) #ifdef Q_OS_MAC - auto modifier = Qt::META; + constexpr auto modifier = Qt::MetaModifier; #else - auto modifier = Qt::CTRL; + constexpr auto modifier = Qt::ControlModifier; #endif m_toggleVisibleAction = new QAction( diff --git a/tests/gui/TestGui.cpp b/tests/gui/TestGui.cpp index 6047c3426..2a669c41d 100644 --- a/tests/gui/TestGui.cpp +++ b/tests/gui/TestGui.cpp @@ -658,7 +658,11 @@ void TestGui::testPasswordEntryEntropy() QVERIFY(passwordEdit); QTest::mouseClick(passwordEdit, Qt::LeftButton); +#ifdef Q_OS_MAC + QTest::keyClick(passwordEdit, Qt::Key_G, Qt::MetaModifier); +#else QTest::keyClick(passwordEdit, Qt::Key_G, Qt::ControlModifier); +#endif TEST_MODAL(PasswordGeneratorWidget * pwGeneratorWidget; QTRY_VERIFY(pwGeneratorWidget = m_dbWidget->findChild()); @@ -739,7 +743,11 @@ void TestGui::testDicewareEntryEntropy() QVERIFY(passwordEdit); QTest::mouseClick(passwordEdit, Qt::LeftButton); +#ifdef Q_OS_MAC + QTest::keyClick(passwordEdit, Qt::Key_G, Qt::MetaModifier); +#else QTest::keyClick(passwordEdit, Qt::Key_G, Qt::ControlModifier); +#endif TEST_MODAL(PasswordGeneratorWidget * pwGeneratorWidget; QTRY_VERIFY(pwGeneratorWidget = m_dbWidget->findChild()); @@ -854,6 +862,7 @@ void TestGui::testSearch() QTRY_VERIFY(helpPanel->isVisible()); QTest::mouseClick(searchTextEdit, Qt::LeftButton); QTRY_VERIFY(helpPanel->isVisible()); + QApplication::processEvents(); helpButton->trigger(); QTRY_VERIFY(!helpPanel->isVisible()); // Search for "ZZZ" @@ -1480,6 +1489,7 @@ void TestGui::testTrayRestoreHide() QSKIP("QSystemTrayIcon::isSystemTrayAvailable() = false, skipping tray restore/hide test…"); } +#ifndef Q_OS_MACOS m_mainWindow->hideWindow(); QVERIFY(!m_mainWindow->isVisible()); @@ -1507,6 +1517,7 @@ void TestGui::testTrayRestoreHide() // Ensure window is visible at the end trayIcon->activated(QSystemTrayIcon::DoubleClick); QTRY_VERIFY(m_mainWindow->isVisible()); +#endif } void TestGui::testAutoType()