From bba7700f1967f4407db16994bdce969ebfd8643c Mon Sep 17 00:00:00 2001 From: Sven Strickroth Date: Thu, 6 Nov 2025 20:36:02 +0100 Subject: [PATCH 1/2] Fix warning C4244 'argument': conversion from 'size_t' to 'int', possible loss of data Use explicit cast. Signed-off-by: Sven Strickroth --- src/format/BitwardenReader.cpp | 4 ++-- src/keeshare/KeeShareSettings.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/format/BitwardenReader.cpp b/src/format/BitwardenReader.cpp index 43b2a34f3..e2f47f618 100644 --- a/src/format/BitwardenReader.cpp +++ b/src/format/BitwardenReader.cpp @@ -388,11 +388,11 @@ QSharedPointer BitwardenReader::convert(const QString& path, const QSt // Derive the MAC Key auto stretched_mac = hkdf->derive_key(32, reinterpret_cast(key.data()), key.size(), "", "mac"); - auto mac = QByteArray(reinterpret_cast(stretched_mac.data()), stretched_mac.size()); + auto mac = QByteArray(reinterpret_cast(stretched_mac.data()), static_cast(stretched_mac.size())); // Stretch the Master Key auto stretched_key = hkdf->derive_key(32, reinterpret_cast(key.data()), key.size(), "", "enc"); - key = QByteArray(reinterpret_cast(stretched_key.data()), stretched_key.size()); + key = QByteArray(reinterpret_cast(stretched_key.data()), static_cast(stretched_key.size())); // Validate the encryption key auto keyList = json.value("encKeyValidation_DO_NOT_EDIT").toString().split("."); diff --git a/src/keeshare/KeeShareSettings.cpp b/src/keeshare/KeeShareSettings.cpp index 4f53fc25f..c53f09cfc 100644 --- a/src/keeshare/KeeShareSettings.cpp +++ b/src/keeshare/KeeShareSettings.cpp @@ -66,7 +66,7 @@ namespace KeeShareSettings return; } auto berKey = Botan::PKCS8::BER_encode(*certificate.key); - auto baKey = QByteArray::fromRawData(reinterpret_cast(berKey.data()), berKey.size()); + auto baKey = QByteArray::fromRawData(reinterpret_cast(berKey.data()), static_cast(berKey.size())); writer.writeStartElement("Signer"); writer.writeCharacters(certificate.signer); @@ -148,7 +148,7 @@ namespace KeeShareSettings return; } auto berKey = Botan::PKCS8::BER_encode(*key.key); - auto baKey = QByteArray::fromRawData(reinterpret_cast(berKey.data()), berKey.size()); + auto baKey = QByteArray::fromRawData(reinterpret_cast(berKey.data()), static_cast(berKey.size())); writer.writeCharacters(baKey.toBase64()); } From 1b56a81bbe90bdd08037881027a3b4db7c39c5ec Mon Sep 17 00:00:00 2001 From: Sven Strickroth Date: Sat, 8 Nov 2025 14:08:37 +0100 Subject: [PATCH 2/2] Fix warning C4244 'argument': conversion from 'size_t' to 'uint', possible loss of data Use explicit cast. Signed-off-by: Sven Strickroth --- src/keeshare/KeeShareSettings.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/keeshare/KeeShareSettings.cpp b/src/keeshare/KeeShareSettings.cpp index c53f09cfc..a3f2bec75 100644 --- a/src/keeshare/KeeShareSettings.cpp +++ b/src/keeshare/KeeShareSettings.cpp @@ -374,8 +374,8 @@ namespace KeeShareSettings QByteArray rsaKeySerialized; QDataStream stream(&rsaKeySerialized, QIODevice::WriteOnly); stream.writeBytes("ssh-rsa", 7); - stream.writeBytes(reinterpret_cast(rsaE.data()), rsaE.size()); - stream.writeBytes(reinterpret_cast(rsaN.data()), rsaN.size()); + stream.writeBytes(reinterpret_cast(rsaE.data()), static_cast(rsaE.size())); + stream.writeBytes(reinterpret_cast(rsaN.data()), static_cast(rsaN.size())); return xmlSerialize([&](QXmlStreamWriter& writer) { writer.writeStartElement("Signature");