From 91dea9cbc4de91ddd44c8ecb0eff02bf6d570a8c Mon Sep 17 00:00:00 2001 From: Jonathan White Date: Sun, 1 Nov 2020 08:20:40 -0500 Subject: [PATCH] Use strict check for std::sort to prevent recursion * Fixes #5596 --- src/browser/BrowserService.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/BrowserService.cpp b/src/browser/BrowserService.cpp index 1271c083d..2d458cb5d 100644 --- a/src/browser/BrowserService.cpp +++ b/src/browser/BrowserService.cpp @@ -751,7 +751,7 @@ BrowserService::sortEntries(QList& pwEntries, const QString& siteUrlStr, // Sort same priority entries by Title or UserName auto entries = priorities.values(key); std::sort(entries.begin(), entries.end(), [&sortField](Entry* left, Entry* right) { - return QString::localeAwareCompare(left->attribute(sortField), right->attribute(sortField)); + return QString::localeAwareCompare(left->attribute(sortField), right->attribute(sortField)) < 0; }); results << entries; if (browserSettings()->bestMatchOnly() && !results.isEmpty()) {