clang-tidy: use override

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2022-04-11 16:33:11 -07:00 committed by Jonathan White
parent 44333fef0a
commit 7e44b67906
37 changed files with 50 additions and 48 deletions

View File

@ -24,9 +24,9 @@ class AddGroup : public DatabaseCommand
{
public:
AddGroup();
~AddGroup();
~AddGroup() override;
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser);
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser) override;
};
#endif // KEEPASSXC_ADDGROUP_H

View File

@ -25,7 +25,7 @@ class Info : public DatabaseCommand
public:
Info();
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser);
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser) override;
};
#endif // KEEPASSXC_INFO_H

View File

@ -24,9 +24,9 @@ class Move : public DatabaseCommand
{
public:
Move();
~Move();
~Move() override;
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser);
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser) override;
};
#endif // KEEPASSXC_MOVE_H

View File

@ -25,7 +25,7 @@ class Remove : public DatabaseCommand
public:
Remove();
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser);
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser) override;
};
#endif // KEEPASSXC_REMOVE_H

View File

@ -24,9 +24,9 @@ class RemoveGroup : public DatabaseCommand
{
public:
RemoveGroup();
~RemoveGroup();
~RemoveGroup() override;
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser);
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser) override;
};
#endif // KEEPASSXC_REMOVEGROUP_H

View File

@ -25,7 +25,7 @@ class Show : public DatabaseCommand
public:
Show();
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser);
int executeWithDatabase(QSharedPointer<Database> db, QSharedPointer<QCommandLineParser> parser) override;
static const QCommandLineOption TotpOption;
static const QCommandLineOption AttributesOption;

View File

@ -79,7 +79,7 @@ class Entry : public ModifiableObject
public:
Entry();
~Entry();
~Entry() override;
const QUuid& uuid() const;
const QString uuidToHex() const;
int iconNumber() const;

View File

@ -34,7 +34,7 @@ class EntryAttachments : public ModifiableObject
public:
explicit EntryAttachments(QObject* parent = nullptr);
virtual ~EntryAttachments();
~EntryAttachments() override;
QList<QString> keys() const;
bool hasKey(const QString& key) const;
QSet<QByteArray> values() const;

View File

@ -78,7 +78,7 @@ public:
};
Group();
~Group();
~Group() override;
const QUuid& uuid() const;
const QString uuidToHex() const;

View File

@ -37,7 +37,7 @@ signals:
void inactivityDetected();
protected:
bool eventFilter(QObject* watched, QEvent* event);
bool eventFilter(QObject* watched, QEvent* event) override;
private slots:
void timeout();

View File

@ -32,7 +32,7 @@ class AboutDialog : public QDialog
public:
explicit AboutDialog(QWidget* parent = nullptr);
~AboutDialog();
~AboutDialog() override;
protected slots:
void copyToClipboard();

View File

@ -46,7 +46,7 @@ class ApplicationSettingsWidget : public EditWidget
public:
explicit ApplicationSettingsWidget(QWidget* parent = nullptr);
~ApplicationSettingsWidget();
~ApplicationSettingsWidget() override;
void addSettingsPage(ISettingsPage* page);
void loadSettings();

View File

@ -35,7 +35,7 @@ class CategoryListWidget : public QWidget
public:
CategoryListWidget(QWidget* parent = nullptr);
~CategoryListWidget();
~CategoryListWidget() override;
int currentCategory();
void setCurrentCategory(int index);

View File

@ -32,7 +32,7 @@ class CloneDialog : public QDialog
public:
explicit CloneDialog(DatabaseWidget* parent = nullptr, Database* db = nullptr, Entry* entry = nullptr);
~CloneDialog();
~CloneDialog() override;
private:
QScopedPointer<Ui::CloneDialog> m_ui;

View File

@ -39,7 +39,7 @@ class DatabaseOpenWidget : public DialogyWidget
public:
explicit DatabaseOpenWidget(QWidget* parent = nullptr);
~DatabaseOpenWidget();
~DatabaseOpenWidget() override;
void load(const QString& filename);
QString filename();
void clearForms();

View File

@ -39,7 +39,7 @@ class EditWidget : public DialogyWidget
public:
explicit EditWidget(QWidget* parent = nullptr);
~EditWidget();
~EditWidget() override;
void addPage(const QString& labelText, const QIcon& icon, QWidget* widget);
bool hasPage(QWidget* widget);

View File

@ -62,7 +62,7 @@ class EditWidgetIcons : public QWidget
public:
explicit EditWidgetIcons(QWidget* parent = nullptr);
~EditWidgetIcons();
~EditWidgetIcons() override;
IconStruct state();
void reset();

View File

@ -38,7 +38,7 @@ class EditWidgetProperties : public QWidget
public:
explicit EditWidgetProperties(QWidget* parent = nullptr);
~EditWidgetProperties();
~EditWidgetProperties() override;
void setFields(const TimeInfo& timeInfo, const QUuid& uuid);
void setCustomData(CustomData* customData);

View File

@ -130,8 +130,8 @@ public:
/**
* Destructor.
*/
~KMessageWidget();
~KMessageWidget() override;
/**
* Get the text of this message widget.
* @see setText()

View File

@ -48,7 +48,7 @@ class MainWindow : public QMainWindow
public:
MainWindow();
~MainWindow();
~MainWindow() override;
QList<DatabaseWidget*> getOpenDatabases();
void restoreConfigState();

View File

@ -45,7 +45,7 @@ public:
};
explicit PasswordGeneratorWidget(QWidget* parent = nullptr);
~PasswordGeneratorWidget();
~PasswordGeneratorWidget() override;
void loadSettings();
void saveSettings();
@ -86,7 +86,7 @@ private:
bool m_passwordGenerated = false;
int m_firstCustomWordlistIndex;
void closeEvent(QCloseEvent* event);
void closeEvent(QCloseEvent* event) override;
PasswordGenerator::CharClasses charClasses();
PasswordGenerator::GeneratorFlags generatorFlags();

View File

@ -32,7 +32,7 @@ class TotpExportSettingsDialog : public QDialog
public:
explicit TotpExportSettingsDialog(DatabaseWidget* parent = nullptr, Entry* entry = nullptr);
~TotpExportSettingsDialog();
~TotpExportSettingsDialog() override;
private slots:
void copyToClipboard();

View File

@ -32,7 +32,7 @@ class WelcomeWidget : public QWidget
public:
explicit WelcomeWidget(QWidget* parent = nullptr);
~WelcomeWidget();
~WelcomeWidget() override;
void refreshLastDatabases();
signals:

View File

@ -37,7 +37,7 @@ class CsvImportWidget : public QWidget
public:
explicit CsvImportWidget(QWidget* parent = nullptr);
~CsvImportWidget();
~CsvImportWidget() override;
void load(const QString& filename, Database* const db);
signals:

View File

@ -30,7 +30,7 @@ class CsvParserModel : public QAbstractTableModel, public CsvParser
public:
explicit CsvParserModel(QObject* parent = nullptr);
~CsvParserModel();
~CsvParserModel() override;
void setFilename(const QString& filename);
QString getFileInfo();
bool parse();

View File

@ -37,7 +37,7 @@ class EntryAttachmentsWidget : public QWidget
Q_PROPERTY(bool isButtonsVisible READ isButtonsVisible WRITE setButtonsVisible NOTIFY buttonsVisibleChanged)
public:
explicit EntryAttachmentsWidget(QWidget* parent = nullptr);
~EntryAttachmentsWidget();
~EntryAttachmentsWidget() override;
const EntryAttachments* attachments() const;
bool isReadOnly() const;

View File

@ -55,7 +55,7 @@ class EditGroupWidget : public EditWidget
public:
explicit EditGroupWidget(QWidget* parent = nullptr);
~EditGroupWidget();
~EditGroupWidget() override;
void loadGroup(Group* group, bool create, const QSharedPointer<Database>& database);
void clear();

View File

@ -82,7 +82,7 @@ signals:
protected:
explicit OSUtilsBase(QObject* parent = nullptr);
virtual ~OSUtilsBase();
~OSUtilsBase() override;
};
#endif // KEEPASSXC_OSUTILSBASE_H

View File

@ -27,7 +27,7 @@ class ScreenLockListener : public QObject
public:
ScreenLockListener(QWidget* parent = nullptr);
~ScreenLockListener();
~ScreenLockListener() override;
signals:
void screenLocked();

View File

@ -43,7 +43,7 @@ class ReportsWidgetHibp : public QWidget
Q_OBJECT
public:
explicit ReportsWidgetHibp(QWidget* parent = nullptr);
~ReportsWidgetHibp();
~ReportsWidgetHibp() override;
void loadSettings(QSharedPointer<Database> db);
void saveSettings();

View File

@ -34,7 +34,7 @@ class ReportsWidgetStatistics : public QWidget
Q_OBJECT
public:
explicit ReportsWidgetStatistics(QWidget* parent = nullptr);
~ReportsWidgetStatistics();
~ReportsWidgetStatistics() override;
void loadSettings(QSharedPointer<Database> db);
void saveSettings();

View File

@ -51,7 +51,7 @@ private slots:
void updateElidedText();
private:
void resizeEvent(QResizeEvent* event);
void resizeEvent(QResizeEvent* event) override;
Qt::TextElideMode m_elideMode;
QString m_rawText;

View File

@ -29,7 +29,7 @@ class HashedBlockStream : public LayeredStream
public:
explicit HashedBlockStream(QIODevice* baseDevice);
HashedBlockStream(QIODevice* baseDevice, qint32 blockSize);
~HashedBlockStream();
~HashedBlockStream() override;
bool reset() override;
void close() override;

View File

@ -29,7 +29,7 @@ class HmacBlockStream : public LayeredStream
public:
explicit HmacBlockStream(QIODevice* baseDevice, QByteArray key);
HmacBlockStream(QIODevice* baseDevice, QByteArray key, qint32 blockSize);
~HmacBlockStream();
~HmacBlockStream() override;
bool reset() override;
void close() override;

View File

@ -26,7 +26,7 @@ class LayeredStream : public QIODevice
public:
explicit LayeredStream(QIODevice* baseDevice);
virtual ~LayeredStream();
~LayeredStream() override;
bool isSequential() const override;
bool open(QIODevice::OpenMode mode) override;

View File

@ -30,7 +30,7 @@ class SymmetricCipherStream : public LayeredStream
public:
SymmetricCipherStream(QIODevice* baseDevice);
~SymmetricCipherStream();
~SymmetricCipherStream() override;
bool
init(SymmetricCipher::Mode mode, SymmetricCipher::Direction direction, const QByteArray& key, const QByteArray& iv);
bool open(QIODevice::OpenMode mode) override;

View File

@ -56,18 +56,20 @@ Q_OBJECT
public:
enum StreamFormat { ZlibFormat, GzipFormat, RawZipFormat };
QtIOCompressor(QIODevice *device, int compressionLevel = 6, int bufferSize = 65500);
~QtIOCompressor();
~QtIOCompressor() override;
void setStreamFormat(StreamFormat format);
StreamFormat streamFormat() const;
static bool isGzipSupported();
bool isSequential() const;
bool open(OpenMode mode);
void close();
bool isSequential() const override;
bool open(OpenMode mode) override;
void close() override;
void flush();
qint64 bytesAvailable() const;
qint64 bytesAvailable() const override;
protected:
qint64 readData(char * data, qint64 maxSize);
qint64 writeData(const char * data, qint64 maxSize);
qint64 readData(char* data, qint64 maxSize) override;
qint64 writeData(const char* data, qint64 maxSize) override;
private:
static bool checkGzipSupport(const char * const versionString);
QtIOCompressorPrivate *d_ptr;