From 79ca00604aab9721a741c848940998b3cdf36708 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sami=20V=C3=A4nttinen?= <sami.vanttinen@ahmala.org>
Date: Fri, 8 Mar 2024 15:43:06 +0200
Subject: [PATCH] Skip a few Passkeys tests with Botan <= 2.14 (#10360)

Botan version less than 2.14.0 miscalculates ECDSA signatures.

---------

Co-authored-by: Jonathan White <support@dmapps.us>
---
 tests/TestPasskeys.cpp | 6 ++++++
 tests/TestPasskeys.h   | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestPasskeys.cpp b/tests/TestPasskeys.cpp
index 9ab66d99b..fc101db5e 100644
--- a/tests/TestPasskeys.cpp
+++ b/tests/TestPasskeys.cpp
@@ -194,6 +194,9 @@ void TestPasskeys::testDecodeResponseData()
 
 void TestPasskeys::testLoadingECPrivateKeyFromPem()
 {
+#if BOTAN_VERSION_CODE < BOTAN_VERSION_CODE_FOR(2, 14, 0)
+    QSKIP("ECDSA Signature is broken on Botan < 2.14.0");
+#endif
     const auto publicKeyCredentialRequestOptions =
         browserMessageBuilder()->getJsonObject(PublicKeyCredentialRequestOptions.toUtf8());
     const auto privateKeyPem = QString("-----BEGIN PRIVATE KEY-----"
@@ -412,6 +415,9 @@ void TestPasskeys::testRegister()
 
 void TestPasskeys::testGet()
 {
+#if BOTAN_VERSION_CODE < BOTAN_VERSION_CODE_FOR(2, 14, 0)
+    QSKIP("ECDSA Signature is broken on Botan < 2.14.0");
+#endif
     const auto privateKeyPem = QString("-----BEGIN PRIVATE KEY-----"
                                        "MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQg5DX2R6I37nMSZqCp"
                                        "XfHlE3UeitkGGE03FqGsdfxIBoOhRANCAAQG7K80W2KRYW0ZWQOmUCrKMcSVqGnl"
diff --git a/tests/TestPasskeys.h b/tests/TestPasskeys.h
index b3882804f..b1c8dbc4e 100644
--- a/tests/TestPasskeys.h
+++ b/tests/TestPasskeys.h
@@ -18,9 +18,9 @@
 #ifndef KEEPASSXC_TESTPASSKEYS_H
 #define KEEPASSXC_TESTPASSKEYS_H
 
-#include <QObject>
-
 #include "browser/BrowserPasskeys.h"
+#include <QObject>
+#include <botan/version.h>
 
 class TestPasskeys : public QObject
 {