Git-Mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-11-25 17:16:33 -05:00
Code Issues Projects Releases Packages Wiki Activity

Fix crash when removing custom data

Browse source
This commit is contained in:
varjolintu 2019-09-05 08:32:32 +03:00 • committed by Jonathan White
parent 72c1783b5b
commit 77be468670
5 changed files with 271 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/gui/EditWidgetProperties.cpp
View file

@ -71,6 +71,11 @@ void EditWidgetProperties::setCustomData(CustomData* customData)
void EditWidgetProperties::removeSelectedPluginData()
{
QModelIndexList indexes = m_ui->customDataTable->selectionModel()->selectedRows(0);
if (indexes.isEmpty()) {
return;
}
auto result = MessageBox::question(this,
tr("Delete plugin data?"),
tr("Do you really want to delete the selected plugin data?\n"
@ -82,14 +87,18 @@ void EditWidgetProperties::removeSelectedPluginData()
return;
}
const QItemSelectionModel* itemSelectionModel = m_ui->customDataTable->selectionModel();
if (itemSelectionModel) {
for (const QModelIndex& index : itemSelectionModel->selectedRows(0)) {
const QString key = index.data().toString();
m_customData->remove(key);
}
update();
QStringList selectedData;
for (const auto& index : indexes) {
const QString key = index.data().toString();
selectedData.append(key);
}
std::sort(selectedData.begin(), selectedData.end());
for (const auto& key : selectedData) {
m_customData->remove(key);
}
update();
}
void EditWidgetProperties::toggleRemoveButton(const QItemSelection& selected)